[PATCH] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment

[PATCH] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment

[Primoz Fiser]

The dailink_master label was incorrectly placed on the codec sub-node,
causing simple-audio-card to configure TLV320AIC3007 as the I2S bitclock
and frame master with SAI2 in consumer mode. This contradicts the SAI2
node configuration (assigned-clock-parents, assigned-clock-rates,
fsl,sai-mclk-direction-output) which requires provider/master mode.

Restore dailink_master to the CPU sub-node so SAI2 drives BCLK and LRCLK
with the codec operating as I2S slave. Also remove the spurious clocks
property from the codec sub-node which had no effect in this topology.

This fixes the broken audio on PHYTEC phyBOARD-Pollux-i.MX8MP board with
PEB-AV-10 Audio/Video expansion board.

Fixes: 7012f551081f ("arm64: dts: imx8mp pollux: add expansion board overlay")
Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
---
 .../boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
index bb740f845855..8957b24a7ad2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
@@ -77,13 +77,12 @@ sound {
 			"MIC3R", "Microphone Jack",
 			"Microphone Jack", "Mic Bias";
 
-		simple-audio-card,cpu {
+		dailink_master: simple-audio-card,cpu {
 			sound-dai = <&sai2>;
 		};
 
-		dailink_master: simple-audio-card,codec {
+		simple-audio-card,codec {
 			sound-dai = <&codec>;
-			clocks = <&clk IMX8MP_CLK_SAI2>;
 		};
 	};
 };
-- 
2.34.1

Re: [PATCH] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment

[Chancel Liu]

> The dailink_master label was incorrectly placed on the codec sub-node,
> causing simple-audio-card to configure TLV320AIC3007 as the I2S bitclock
> and frame master with SAI2 in consumer mode. This contradicts the SAI2
> node configuration (assigned-clock-parents, assigned-clock-rates,
> fsl,sai-mclk-direction-output) which requires provider/master mode.

Just a small question about the commit message. As far as I understand,
these SAI2 node configurations only describe SAI2 providing MCLK to the
codec. A topology where the SAI provides MCLK while the codec is the
bclk/fs provider is common. So the original configuration seems
self-consistent, not contradictory.

Regards,
Chancel Liu

> Restore dailink_master to the CPU sub-node so SAI2 drives BCLK and LRCLK
> with the codec operating as I2S slave. Also remove the spurious clocks
> property from the codec sub-node which had no effect in this topology.
> 
> This fixes the broken audio on PHYTEC phyBOARD-Pollux-i.MX8MP board with
> PEB-AV-10 Audio/Video expansion board.
> 
> Fixes: 7012f551081f ("arm64: dts: imx8mp pollux: add expansion board overlay")
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
>  .../boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
> index bb740f845855..8957b24a7ad2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
> @@ -77,13 +77,12 @@ sound {
>  			"MIC3R", "Microphone Jack",
>  			"Microphone Jack", "Mic Bias";
>  
> -		simple-audio-card,cpu {
> +		dailink_master: simple-audio-card,cpu {
>  			sound-dai = <&sai2>;
>  		};
>  
> -		dailink_master: simple-audio-card,codec {
> +		simple-audio-card,codec {
>  			sound-dai = <&codec>;
> -			clocks = <&clk IMX8MP_CLK_SAI2>;
>  		};
>  	};
>  };

Re: [PATCH] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment

[Primoz Fiser]

Hi,

On 8/27/26 10:56, Chancel Liu wrote:
>> The dailink_master label was incorrectly placed on the codec sub-node,
>> causing simple-audio-card to configure TLV320AIC3007 as the I2S bitclock
>> and frame master with SAI2 in consumer mode. This contradicts the SAI2
>> node configuration (assigned-clock-parents, assigned-clock-rates,
>> fsl,sai-mclk-direction-output) which requires provider/master mode.
> 
> Just a small question about the commit message. As far as I understand,
> these SAI2 node configurations only describe SAI2 providing MCLK to the
> codec. A topology where the SAI provides MCLK while the codec is the
> bclk/fs provider is common. So the original configuration seems
> self-consistent, not contradictory.
> 

You are right. Such configuration are possible.

However, on this board's wiring, SAI has to be bus master for BCLK/FSYNC.

Shall I reword commit message or is this explanation enough?

BR,
Primoz


> Regards,
> Chancel Liu
> 
>> Restore dailink_master to the CPU sub-node so SAI2 drives BCLK and LRCLK
>> with the codec operating as I2S slave. Also remove the spurious clocks
>> property from the codec sub-node which had no effect in this topology.
>>
>> This fixes the broken audio on PHYTEC phyBOARD-Pollux-i.MX8MP board with
>> PEB-AV-10 Audio/Video expansion board.
>>
>> Fixes: 7012f551081f ("arm64: dts: imx8mp pollux: add expansion board overlay")
>> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
>> ---
>>  .../boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
>> index bb740f845855..8957b24a7ad2 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mp-phyboard-pollux-peb-av-10.dtsi
>> @@ -77,13 +77,12 @@ sound {
>>  			"MIC3R", "Microphone Jack",
>>  			"Microphone Jack", "Mic Bias";
>>  
>> -		simple-audio-card,cpu {
>> +		dailink_master: simple-audio-card,cpu {
>>  			sound-dai = <&sai2>;
>>  		};
>>  
>> -		dailink_master: simple-audio-card,codec {
>> +		simple-audio-card,codec {
>>  			sound-dai = <&codec>;
>> -			clocks = <&clk IMX8MP_CLK_SAI2>;
>>  		};
>>  	};
>>  };
> 

-- 
Primoz Fiser
phone: +386-41-390-545
email: primoz.fiser@norik.com
--
Norik systems d.o.o.
Your embedded software partner
Slovenia, EU
phone: +386-41-540-545
email: info@norik.com

Re: [PATCH] arm64: dts: imx8mp-phyboard-pollux-peb-av-10: Fix SAI master assignment

[Chancel Liu]

> Hi,
> 
> On 8/27/26 10:56, Chancel Liu wrote:
>>> The dailink_master label was incorrectly placed on the codec sub-node,
>>> causing simple-audio-card to configure TLV320AIC3007 as the I2S bitclock
>>> and frame master with SAI2 in consumer mode. This contradicts the SAI2
>>> node configuration (assigned-clock-parents, assigned-clock-rates,
>>> fsl,sai-mclk-direction-output) which requires provider/master mode.
>>
>> Just a small question about the commit message. As far as I understand,
>> these SAI2 node configurations only describe SAI2 providing MCLK to the
>> codec. A topology where the SAI provides MCLK while the codec is the
>> bclk/fs provider is common. So the original configuration seems
>> self-consistent, not contradictory.
>>
> 
> You are right. Such configuration are possible.
> 
> However, on this board's wiring, SAI has to be bus master for BCLK/FSYNC.
> 
> Shall I reword commit message or is this explanation enough?
> 
> BR,
> Primoz
>

I'd prefer rewording, as current message is a bit confusing.

Regards,
Chancel Liu