Re: [PATCH 1/3] dt-bindings: media: qcom,qcm2290-venus: document shikra Iris compatible

[Vikash Garodia <vikash.garodia@oss.qualcomm.com>]

On 6/10/2026 2:07 AM, Bryan O'Donoghue wrote:
> On 09/06/2026 17:15, Vikash Garodia wrote:
>> Document the iris video accelerator used on shikra platforms by adding
>> the qcom,shikra-iris compatible.
>>
>> Although QCM2290 and shikra share the same video hardware and overall
>> integration, their SMMU programming differs. QCM2290 exposes separate
>> stream IDs for the video hardware and the Xtensa path, requiring two
>> explicit IOMMU entries, whereas shikra uses a masked SMR to collapse
>> equivalent stream IDs into a single mapping. Due to QCM2290’s SID layout
>> and Xtensa isolation requirements, such SMR masking is not applicable on
>> QCM2290 platforms.
>> Since shikra uses the same video hardware as QCM2290 and shares the same
>> programming model and capabilities, it is added as a fallback compatible
>> to qcom,qcm2290-venus, with conditional handling to allow either one or
>> two IOMMU entries.
>>
>> Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
>> ---
>>   .../bindings/media/qcom,qcm2290-venus.yaml           | 20 ++++++++++ 
>> ++++++----
>>   1 file changed, 16 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290- 
>> venus.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290- 
>> venus.yaml
>> index 
>> 5977e7d0a71b4fb5681f1c2094439c251366f01f..895533b9756690d075fd7729e3f805c8e72ff0df 100644
>> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
>> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-venus.yaml
>> @@ -15,12 +15,27 @@ description:
>>
>>   allOf:
>>     - $ref: qcom,venus-common.yaml#
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: qcom,shikra-iris
> 
> Should this be "iris" in a venus yaml ?

given the vpu core was first enabled on venus and now it same core on a 
different SOC being enabled on iris. There are 2 ways to do this
1. Add the compat to existing schema which defines the binding for that 
core i.e existing patch
2. Write a new schema (or say duplicate it) with ...shikra-iris.yaml, 
but again, the shikra compat would fallback to "qcom,qcm2290-venus" 
compat. hence even iris yaml would then need to carry the venus *string*.

I followed the first option.

Regards,
Vikash

> 
>> +    then:
>> +      properties:
>> +        iommus:
>> +          maxItems: 1
>> +    else:
>> +      properties:
>> +        iommus:
>> +          maxItems: 2
>>
>>   properties:
>>     compatible:
>>       oneOf:
>>         - items:
>> -          - const: qcom,sm6115-venus
>> +          - enum:
>> +              - qcom,sm6115-venus
>> +              - qcom,shikra-iris
>>             - const: qcom,qcm2290-venus
>>         - const: qcom,qcm2290-venus
>>
>> @@ -45,9 +60,6 @@ properties:
>>         - const: vcodec0_core
>>         - const: vcodec0_bus
>>
>> -  iommus:
>> -    maxItems: 2
>> -
>>     interconnects:
>>       maxItems: 2
>>
>>
>> -- 
>> 2.34.1
>>
> 
> ---
> bod