From: Mugunthan V N <mugunthanvnm@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Tony Lindgren <tony@atomide.com>,
netdev@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-omap@vger.kernel.org, David Miller <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control
Date: Wed, 12 Oct 2016 13:43:57 +0530 [thread overview]
Message-ID: <bc9a985b-0623-b1fd-8cc1-575d8b318560@ti.com> (raw)
In-Reply-To: <20161010131841.GA8391@rob-hp-laptop>
On Monday 10 October 2016 06:48 PM, Rob Herring wrote:
> On Thu, Oct 06, 2016 at 10:43:52AM +0530, Mugunthan V N wrote:
>> Add documention of ti,impedance-control which can be used to
>
> Needs updating.
Oops, will update this in next version.
>
>> correct MAC impedance mismatch using phy extended registers.
>>
>> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
>> ---
>> Documentation/devicetree/bindings/net/ti,dp83867.txt | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.txt b/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> index 5d21141..85bf945 100644
>> --- a/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.txt
>> @@ -9,6 +9,18 @@ Required properties:
>> - ti,fifo-depth - Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h
>> for applicable values
>>
>> +Optional property:
>> + - ti,min-output-impedance - MAC Interface Impedance control to set
>> + the programmable output impedance to
>> + minimum value (35 ohms).
>> + - ti,max-output-impedance - MAC Interface Impedance control to set
>> + the programmable output impedance to
>> + maximum value (70 ohms).
>
> Define what are valid range of values for these.
The values are already mentioned in documentation as 35/70 ohms.
Are you mentioning about the register values?
Regards
Mugunthan V N
next prev parent reply other threads:[~2016-10-12 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 5:13 [PATCH v3 0/4] add support for impedance control for TI dp83867 phy and fix 2nd ethernet on dra72 rev C evm Mugunthan V N
[not found] ` <20161006051355.15947-1-mugunthanvnm-l0cyMroinI0@public.gmane.org>
2016-10-06 5:13 ` [PATCH v3 1/4] net: phy: dp83867: Add documentation for optional impedance control Mugunthan V N
2016-10-10 13:18 ` Rob Herring
2016-10-12 8:13 ` Mugunthan V N [this message]
2016-10-06 5:13 ` [PATCH v3 2/4] net: phy: dp83867: add support for MAC impedance configuration Mugunthan V N
2016-10-06 5:13 ` [PATCH v3 3/4] ARM: dts: dra72-evm-revc: add phy impedance settings Mugunthan V N
2016-10-06 5:13 ` [PATCH v3 4/4] ARM: dts: dra72-evm-revc: fix correct phy delay Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc9a985b-0623-b1fd-8cc1-575d8b318560@ti.com \
--to=mugunthanvnm@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox