From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Taniya Das <taniya.das@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Imran Shaik <imran.shaik@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili
Date: Fri, 17 Jul 2026 12:11:39 +0200 [thread overview]
Message-ID: <bd067052-ea72-41f4-a665-2f54242d12a6@oss.qualcomm.com> (raw)
In-Reply-To: <20260713-maili_initial_clock-v2-4-79548f0bb58f@oss.qualcomm.com>
On 7/13/26 11:04 AM, Taniya Das wrote:
> Add support for the global clock controller (GCC) on the Qualcomm Maili
> SoC by extending the Hawi global clock controller since Maili is identical
> to Hawi and has few additional clocks.
>
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
[...]
> + /*
> + * Maili-only clocks: NULL here to size the array to the highest Maili
> + * clock index.
> + */
> + [GCC_QUPV3_WRAP_5_S_AHB_CLK] = NULL,
This is unnecessary/wrong, as desc->num_clks validates the index in
qcom_cc_clk_hw_get().
Without this, we'd get an -EINVAL, with this we get a silent nullptr
Konrad
next prev parent reply other threads:[~2026-07-17 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 9:04 [PATCH v2 0/5] clk: qcom: Introduce initial clock controllers for Maili SoC Taniya Das
2026-07-13 9:04 ` [PATCH v2 1/5] dt-bindings: clock: qcom-rpmhcc: Add RPMH clock controller for Maili Taniya Das
2026-07-13 9:04 ` [PATCH v2 2/5] dt-bindings: clock: qcom: Add Maili TCSR clock controller Taniya Das
2026-07-13 9:04 ` [PATCH v2 3/5] dt-bindings: clock: qcom: Add Maili global " Taniya Das
2026-07-13 9:12 ` sashiko-bot
2026-07-15 11:33 ` Krzysztof Kozlowski
2026-07-13 9:04 ` [PATCH v2 4/5] clk: qcom: gcc-hawi: Add support for global clock controller on Maili Taniya Das
2026-07-17 10:11 ` Konrad Dybcio [this message]
2026-07-13 9:04 ` [PATCH v2 5/5] dt-bindings: mailbox: qcom: Document Maili CPUCP mailbox controller Taniya Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd067052-ea72-41f4-a665-2f54242d12a6@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vivek.aknurwar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox