[PATCH] arm64: dts: qcom: sm8150-microsoft-surface-duo: fix da7280 pinctrl state name

[PATCH] arm64: dts: qcom: sm8150-microsoft-surface-duo: fix da7280 pinctrl state name

[Ivan Verbovoy via B4 Relay]

From: Ivan Verbovoy <ivanverbovoy@gmail.com>

The pinctrl core applies a device's "default" state by itself and the
da7280 driver requests no state of its own, so the state named
"da7280_default" is never selected: gpio42 stays as the firmware left it
and its pull-up is not applied. The interrupt line is open-drain and
level-low; after a suspend/resume cycle it stays low and the threaded
handler runs continuously (about 2900 times a second) with no event in
the chip, which slows the whole system down.

Name the state "default" so it is applied at probe.

Fixes: d1f781db47a8 ("arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo")
Signed-off-by: Ivan Verbovoy <ivanverbovoy@gmail.com>
---
 arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
index f37e11bde067..4078a7521a2e 100644
--- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
+++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
@@ -372,7 +372,7 @@ da7280@4a {
 		compatible = "dlg,da7280";
 		reg = <0x4a>;
 		interrupts-extended = <&tlmm 42 IRQ_TYPE_LEVEL_LOW>;
-		pinctrl-names = "da7280_default";
+		pinctrl-names = "default";
 		pinctrl-0 = <&da7280_intr_default>;
 
 		dlg,actuator-type = "LRA";

---
base-commit: d6bcfc94eb4da6e089c5473970cd96727292fd97
change-id: 20261103-a1-duo-da7280-pinctrl-beddacac8298

Best regards,
--  
Ivan Verbovoy <ivanverbovoy@gmail.com>

Re: [PATCH] arm64: dts: qcom: sm8150-microsoft-surface-duo: fix da7280 pinctrl state name

[Konrad Dybcio]

On 11/3/26 8:27 PM, Ivan Verbovoy via B4 Relay wrote:
> From: Ivan Verbovoy <ivanverbovoy@gmail.com>
> 
> The pinctrl core applies a device's "default" state by itself and the
> da7280 driver requests no state of its own, so the state named
> "da7280_default" is never selected: gpio42 stays as the firmware left it
> and its pull-up is not applied. The interrupt line is open-drain and
> level-low; after a suspend/resume cycle it stays low and the threaded
> handler runs continuously (about 2900 times a second) with no event in
> the chip, which slows the whole system down.
> 
> Name the state "default" so it is applied at probe.
> 
> Fixes: d1f781db47a8 ("arm64: dts: qcom: add initial device-tree for Microsoft Surface Duo")
> Signed-off-by: Ivan Verbovoy <ivanverbovoy@gmail.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] arm64: dts: qcom: sm8150-microsoft-surface-duo: fix da7280 pinctrl state name

[Bjorn Andersson]

On Tue, 03 Nov 2026 21:27:19 +0200, Ivan Verbovoy wrote:
> The pinctrl core applies a device's "default" state by itself and the
> da7280 driver requests no state of its own, so the state named
> "da7280_default" is never selected: gpio42 stays as the firmware left it
> and its pull-up is not applied. The interrupt line is open-drain and
> level-low; after a suspend/resume cycle it stays low and the threaded
> handler runs continuously (about 2900 times a second) with no event in
> the chip, which slows the whole system down.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sm8150-microsoft-surface-duo: fix da7280 pinctrl state name
      commit: 9c4d2fc8911a9be378c6f6ee19bc792858e15c32

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>