From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: marijn.suijten@somainline.org,
Loic Poulain <loic.poulain@linaro.org>,
Robert Foss <robert.foss@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles
Date: Tue, 13 Dec 2022 20:28:25 +0100 [thread overview]
Message-ID: <c1a2634e-8917-e70a-ca7a-61363dea62de@linaro.org> (raw)
In-Reply-To: <96fd8fc1-96ba-2efe-f6ae-5786131d9c94@linaro.org>
On 13/12/2022 20:20, Konrad Dybcio wrote:
>
>>
>>> then:
>>> properties:
>>> clocks:
>>> @@ -105,10 +116,12 @@ allOf:
>>> - if:
>>> properties:
>>> compatible:
>>> - contains:
>>> - enum:
>>> - - qcom,msm8916-cci
>>> - - qcom,msm8996-cci
>>> + oneOf:
>>> + - contains:
>>> + enum:
>>> + - qcom,msm8916-cci
>>> +
>>> + - const: qcom,msm8996-cci
>>
>> The same comment.
> e.g. the 845 example contains 8996 but does not fall in this category,
> reverting this change causes errors.
Ah, I see, indeed. Looks reasonable:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-13 19:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 18:33 [PATCH v2 1/6] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles Konrad Dybcio
2022-12-13 18:33 ` [PATCH v2 2/6] arm64: dts: qcom: msm8916: Add fallback CCI compatible Konrad Dybcio
2022-12-13 18:33 ` [PATCH v2 3/6] arm64: dts: qcom: sdm845: " Konrad Dybcio
2022-12-13 18:33 ` [PATCH v2 4/6] arm64: dts: qcom: sm8250: " Konrad Dybcio
2022-12-13 18:33 ` [PATCH v2 5/6] arm64: dts: qcom: sm8450: " Konrad Dybcio
2022-12-13 18:33 ` [PATCH v2 6/6] i2c: qcom-cci: Deprecate duplicated compatibles Konrad Dybcio
2022-12-13 19:17 ` Krzysztof Kozlowski
2023-01-09 12:07 ` Wolfram Sang
2022-12-13 19:16 ` [PATCH v2 1/6] dt-bindings: i2c: qcom,i2c-cci: Fall back to common compatibles Krzysztof Kozlowski
2022-12-13 19:20 ` Konrad Dybcio
2022-12-13 19:28 ` Krzysztof Kozlowski [this message]
2023-01-09 12:06 ` Wolfram Sang
2023-01-11 5:09 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1a2634e-8917-e70a-ca7a-61363dea62de@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=marijn.suijten@somainline.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox