[PATCH] dt-bindings: usb: ti,tps6598x: add TPS6699x compatible

[PATCH] dt-bindings: usb: ti,tps6598x: add TPS6699x compatible

[Radhey Shyam Pandey]

Add a ti,tps6699x compatible to explicitly identify TPS6699x devices.
The TPS6699x family is not host-interface compatible with TPS6598x, so
a distinct compatible is required.

Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
---
 Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
index 1745e28b3110..76c9cc392a40 100644
--- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
@@ -4,13 +4,14 @@
 $id: http://devicetree.org/schemas/usb/ti,tps6598x.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Texas Instruments 6598x Type-C Port Switch and Power Delivery controller
+title: Texas Instruments Type-C port switch and USB Power Delivery controllers
 
 maintainers:
   - Bryan O'Donoghue <bryan.odonoghue@linaro.org>
 
 description: |
-  Texas Instruments 6598x Type-C Port Switch and Power Delivery controller
+  Texas Instruments devices (6598x/6699x) that combine a USB Type-C port
+  switch and Power Delivery controller.
 
   A variant of this controller known as Apple CD321x or Apple ACE is also
   present on hardware with Apple SoCs such as the M1.
@@ -19,6 +20,7 @@ properties:
   compatible:
     enum:
       - ti,tps6598x
+      - ti,tps6699x
       - apple,cd321x
       - ti,tps25750
 

base-commit: c425609d6ac4012c8bbf01ec2e10e801b1923a7b
-- 
2.49.1

Re: [PATCH] dt-bindings: usb: ti,tps6598x: add TPS6699x compatible

[Krzysztof Kozlowski]

On Sat, Jun 13, 2026 at 09:53:35PM +0530, Radhey Shyam Pandey wrote:
 +  switch and Power Delivery controller.
>  
>    A variant of this controller known as Apple CD321x or Apple ACE is also
>    present on hardware with Apple SoCs such as the M1.
> @@ -19,6 +20,7 @@ properties:
>    compatible:
>      enum:
>        - ti,tps6598x
> +      - ti,tps6699x

Family compatibles are not allowed. Please use specific models,
expressing compatibility (my slides of DTS101 talkmight help you if
something is unclear).

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: usb: ti,tps6598x: add TPS6699x compatible

[Krzysztof Kozlowski]

On 13/06/2026 21:08, Krzysztof Kozlowski wrote:
> On Sat, Jun 13, 2026 at 09:53:35PM +0530, Radhey Shyam Pandey wrote:
>  +  switch and Power Delivery controller.
>>  
>>    A variant of this controller known as Apple CD321x or Apple ACE is also
>>    present on hardware with Apple SoCs such as the M1.
>> @@ -19,6 +20,7 @@ properties:
>>    compatible:
>>      enum:
>>        - ti,tps6598x
>> +      - ti,tps6699x
> 
> Family compatibles are not allowed. Please use specific models,
> expressing compatibility (my slides of DTS101 talkmight help you if
> something is unclear).


And where is any user of this? Why do we want this binding in the first
place?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: usb: ti,tps6598x: add TPS6699x compatible

[Pandey, Radhey Shyam]

> On 13/06/2026 21:08, Krzysztof Kozlowski wrote:
>> On Sat, Jun 13, 2026 at 09:53:35PM +0530, Radhey Shyam Pandey wrote:
>>   +  switch and Power Delivery controller.
>>>   
>>>     A variant of this controller known as Apple CD321x or Apple ACE is also
>>>     present on hardware with Apple SoCs such as the M1.
>>> @@ -19,6 +20,7 @@ properties:
>>>     compatible:
>>>       enum:
>>>         - ti,tps6598x
>>> +      - ti,tps6699x
>>
>> Family compatibles are not allowed. Please use specific models,
>> expressing compatibility (my slides of DTS101 talkmight help you if
>> something is unclear).

Thanks for pointing it out and the recent DTS 101 talk at OSS India.
It's clear now , will rename the compatible to match the exact
device i.e ti,tps66993 and send out v2.
> 
> 
> And where is any user of this? Why do we want this binding in the first
> place?

There is a user of it and will include the driver patch as well in v2.

Thanks,
Radhey