public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Judith Mendez <jm@ti.com>
To: Nishanth Menon <nm@ti.com>, Jan Kiszka <jan.kiszka@siemens.com>,
	<devicetree@vger.kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	<linux-kernel@vger.kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 6/6] arm64: dts: ti: k3-am65: Add ESM nodes
Date: Wed, 14 Aug 2024 09:05:34 -0500	[thread overview]
Message-ID: <c5c378e1-e503-43e6-a5ce-1fd53da19375@ti.com> (raw)
In-Reply-To: <20240813230312.3289428-7-jm@ti.com>

Hi all,

On 8/13/24 6:03 PM, Judith Mendez wrote:
> Add Error Signaling Module (ESM) instances in MCU and MAIN
> domains, set ESM interrupt sources for rti as per TRM [0] 9.4
> Interrupt Sources.
> 
> Add comments to describe what interrupt sources are routed to
> ESM modules.
> 
> [0] https://www.ti.com/lit/ug/spruid7e/spruid7e.pdf
> 
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> Changes since v1:
> - Add patch 6/6 for am65x
> ---
>   arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++
>   arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi  | 8 ++++++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index 1af3dedde1f67..07c9f043dac0b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -54,6 +54,14 @@ gic_its: msi-controller@1820000 {
>   		};
>   	};
>   
> +	main_esm: esm@700000 {
> +		compatible = "ti,j721e-esm";
> +		reg = <0x00 0x700000 0x00 0x1000>;
> +		/* Interrupt sources: rti0, rti1, rti2, rti3 */
> +		ti,esm-pins = <224>, <225>, <226>, <227>;

I am not sure if someone knows the answer to this question, but..

I noticed that for rti, the interrupt source id's are different
for SR1 vs SR2, so which should be used here in k3-am65-main?

Here, I assumed SR2.

~ Judith


> +		bootph-pre-ram;
> +	};
> +
>   	serdes0: serdes@900000 {
>   		compatible = "ti,phy-am654-serdes";
>   		reg = <0x0 0x900000 0x0 0x2000>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 43c6118d2bf0f..e10cb9f483698 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -440,6 +440,14 @@ mcu_r5fss0_core1: r5f@41400000 {
>   		};
>   	};
>   
> +	mcu_esm: esm@40800000 {
> +		compatible = "ti,j721e-esm";
> +		reg = <0x00 0x40800000 0x00 0x1000>;
> +		/* Interrupt sources: mrti0, mrti1 */
> +		ti,esm-pins = <104>, <105>;
> +		bootph-pre-ram;
> +	};
> +
>   	mcu_rti1: watchdog@40610000 {
>   		compatible = "ti,j7-rti-wdt";
>   		reg = <0x0 0x40610000 0x0 0x100>;


  reply	other threads:[~2024-08-14 14:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-13 23:03 [PATCH v2 0/6] Add and fix ESM nodes Judith Mendez
2024-08-13 23:03 ` [PATCH v2 1/6] arm64: dts: ti: k3-am62a: Add " Judith Mendez
2024-08-13 23:03 ` [PATCH v2 2/6] arm64: dts: ti: k3-am62p: Fix ESM interrupt sources Judith Mendez
2024-08-13 23:03 ` [PATCH v2 3/6] arm64: dts: ti: k3-am62p: Remove 'reserved' status for ESM Judith Mendez
2024-08-13 23:03 ` [PATCH v2 4/6] arm64: dts: ti: k3-am62: Add comments to ESM nodes Judith Mendez
2024-08-13 23:03 ` [PATCH v2 5/6] arm64: dts: ti: k3-am64: Add more ESM interrupt sources Judith Mendez
2024-08-13 23:03 ` [PATCH v2 6/6] arm64: dts: ti: k3-am65: Add ESM nodes Judith Mendez
2024-08-14 14:05   ` Judith Mendez [this message]
2024-08-15 12:32     ` Nishanth Menon
2024-08-15 14:20       ` Jan Kiszka
2024-08-14  4:04 ` [PATCH v2 0/6] Add and fix " Jan Kiszka
2024-08-14 13:59   ` Judith Mendez
2024-08-15 12:29     ` Nishanth Menon
2024-08-15 14:19       ` Jan Kiszka
2024-08-15 14:27       ` Judith Mendez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5c378e1-e503-43e6-a5ce-1fd53da19375@ti.com \
    --to=jm@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox