Devicetree
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: Conor Dooley <conor@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Patil, Shubham Sanjay" <shubpati@amd.com>,
	Shubham Patil <shubhamsanjay.patil@amd.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, "git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties
Date: Wed, 19 Aug 2026 07:40:53 +0200	[thread overview]
Message-ID: <c624a688-3fab-4c38-86e0-9f84751aa167@amd.com> (raw)
In-Reply-To: <20260819-spoken-tiring-445e92a78235@spud>



On 8/19/26 01:29, Conor Dooley wrote:
> On Tue, Aug 18, 2026 at 08:36:16PM +0200, Krzysztof Kozlowski wrote:
>> On 18/08/2026 14:02, Patil, Shubham Sanjay wrote:
>>> Hi Krzysztof,
>>>
>>> On 8/17/2026 2:20 PM, Krzysztof Kozlowski wrote:
>>>> [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>>
>>>> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>>>>
>>>>
>>>> On Fri, Aug 14, 2026 at 05:21:53PM +0530, Shubham Patil wrote:
>>>>> In-Band Interrupt and Hot-Join are synthesis-time options of the AXI I3C
>>>>> IP. Describe them with two boolean properties.
>>>>>
>>>>> A Hot-Join request is acknowledged by the IBI machinery, so a hot-join
>>>>> capable design is always IBI capable as well. Both events are reported
>>>>> through the controller interrupt, which is therefore required whenever
>>>>> the capability is present.
>>>>>
>>>>> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
>>>>> ---
>>>>>    .../bindings/i3c/xlnx,axi-i3c-1.0.yaml        | 23 +++++++++++++++++++
>>>>>    1 file changed, 23 insertions(+)
>>>>>
>>>>
>>>> So the same SoC using this core will have different synthesis options?
>>>> IOW, why isn't this implied by a specific compatible?
>>>
>>> Yes. This core is not part of the SoC's fixed hardware: it is a design
>>> compiled into the FPGA fabric. When the core is added to a design in
>>> Vivado, IBI and Hot-Join are options that are turned on or off, so two
>>> builds -- or two instances in the same build -- can use the identical IP
>>> version and still differ in which features are present.
>>>
>>> The compatible string identifies the IP core and its version. It says
>>
>> Well, you miss SoC compatibles so you cannot use argument of IP core.
>> Although I do accept argument of two instances in a SoC having this
>> different.
> 
> How are SoC compatibles relevant here? It's an IP for FPGA fabric, so
> even if you made some sort of zynq specific compatible (which I am not
> advocating for to be clear) the IP configuration options may vary
> between synthesis runs, so a SoC-specific compatible doesn't help.

SOC compatibility make no sense here. It is soft IP. It can be in any fpga board 
with/without hard blocks (ARM cores) in different configuration per instance.
You can have unlimited (obviously resource limited) amount of IPs in mixed 
configuration in the same device if you want/need.

Thanks,
Michal




  reply	other threads:[~2026-08-19  5:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 11:51 [PATCH 0/3] i3c: master: amd: Add IBI and hot-join support Shubham Patil
2026-08-14 11:51 ` [PATCH 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties Shubham Patil
2026-08-14 15:38   ` Conor Dooley
2026-08-18 10:38     ` Patil, Shubham Sanjay
2026-08-14 17:07   ` Frank Li
2026-08-18 11:59     ` Patil, Shubham Sanjay
2026-08-18 16:51       ` Frank Li
2026-08-17  8:50   ` Krzysztof Kozlowski
2026-08-18 12:02     ` Patil, Shubham Sanjay
2026-08-18 18:36       ` Krzysztof Kozlowski
2026-08-18 23:29         ` Conor Dooley
2026-08-19  5:40           ` Michal Simek [this message]
2026-08-14 11:51 ` [PATCH 2/3] i3c: master: amd: Add support for in-band interrupts Shubham Patil
2026-08-14 12:05   ` sashiko-bot
2026-08-14 11:51 ` [PATCH 3/3] i3c: master: amd: Add hot-join support Shubham Patil
2026-08-14 12:05   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c624a688-3fab-4c38-86e0-9f84751aa167@amd.com \
    --to=michal.simek@amd.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@amd.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shubhamsanjay.patil@amd.com \
    --cc=shubpati@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox