From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Guido Günther" <agx@sigxcpu.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards
Date: Mon, 20 Oct 2025 12:16:32 +0200 [thread overview]
Message-ID: <c754eaa1-555b-4ec7-8539-b98a037bc2c0@oss.qualcomm.com> (raw)
In-Reply-To: <20251020-shift6mq-dt-v1-1-8714087118b8@sigxcpu.org>
On 10/20/25 9:55 AM, Guido Günther wrote:
> They're used in the parent to describe the panel's reg property.
>
> Fixes the
>
> linux/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dtb: panel@0 (visionox,rm69299-shift): '#address-cells', '#size-cells' do not match any of the regexes: '^pinctrl-[0-9]+$'
>
> warning.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 89260fce6513..44e7b5015d26 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -472,6 +472,9 @@ &mdss_dsi0 {
> status = "okay";
> vdda-supply = <&vdda_mipi_dsi0_1p2>;
>
> + #address-cells = <1>;
> + #size-cells = <0>;
These are already defined in sdm845. you can simply delete the lines
below
Konrad
> +
> panel@0 {
> compatible = "visionox,rm69299-shift";
> status = "okay";
> @@ -479,9 +482,6 @@ panel@0 {
> vdda-supply = <&vreg_l14a_1p88>;
> vdd3p3-supply = <&vreg_l28a_3p0>;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
>
> pinctrl-names = "default", "sleep";
>
> ---
> base-commit: f406055cb18c6e299c4a783fc1effeb16be41803
> change-id: 20251019-shift6mq-dt-e4b9e7dc7169
>
> Best regards,
next prev parent reply other threads:[~2025-10-20 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 7:55 [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards Guido Günther
2025-10-20 10:16 ` Konrad Dybcio [this message]
2025-10-20 11:06 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c754eaa1-555b-4ec7-8539-b98a037bc2c0@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=agx@sigxcpu.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox