* [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards
@ 2025-10-20 7:55 Guido Günther
2025-10-20 10:16 ` Konrad Dybcio
2025-10-20 11:06 ` Dmitry Baryshkov
0 siblings, 2 replies; 3+ messages in thread
From: Guido Günther @ 2025-10-20 7:55 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel,
Guido Günther
They're used in the parent to describe the panel's reg property.
Fixes the
linux/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dtb: panel@0 (visionox,rm69299-shift): '#address-cells', '#size-cells' do not match any of the regexes: '^pinctrl-[0-9]+$'
warning.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 89260fce6513..44e7b5015d26 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -472,6 +472,9 @@ &mdss_dsi0 {
status = "okay";
vdda-supply = <&vdda_mipi_dsi0_1p2>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
panel@0 {
compatible = "visionox,rm69299-shift";
status = "okay";
@@ -479,9 +482,6 @@ panel@0 {
vdda-supply = <&vreg_l14a_1p88>;
vdd3p3-supply = <&vreg_l28a_3p0>;
- #address-cells = <1>;
- #size-cells = <0>;
-
reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default", "sleep";
---
base-commit: f406055cb18c6e299c4a783fc1effeb16be41803
change-id: 20251019-shift6mq-dt-e4b9e7dc7169
Best regards,
--
Guido Günther <agx@sigxcpu.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards
2025-10-20 7:55 [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards Guido Günther
@ 2025-10-20 10:16 ` Konrad Dybcio
2025-10-20 11:06 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2025-10-20 10:16 UTC (permalink / raw)
To: Guido Günther, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, phone-devel
On 10/20/25 9:55 AM, Guido Günther wrote:
> They're used in the parent to describe the panel's reg property.
>
> Fixes the
>
> linux/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dtb: panel@0 (visionox,rm69299-shift): '#address-cells', '#size-cells' do not match any of the regexes: '^pinctrl-[0-9]+$'
>
> warning.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 89260fce6513..44e7b5015d26 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -472,6 +472,9 @@ &mdss_dsi0 {
> status = "okay";
> vdda-supply = <&vdda_mipi_dsi0_1p2>;
>
> + #address-cells = <1>;
> + #size-cells = <0>;
These are already defined in sdm845. you can simply delete the lines
below
Konrad
> +
> panel@0 {
> compatible = "visionox,rm69299-shift";
> status = "okay";
> @@ -479,9 +482,6 @@ panel@0 {
> vdda-supply = <&vreg_l14a_1p88>;
> vdd3p3-supply = <&vreg_l28a_3p0>;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
>
> pinctrl-names = "default", "sleep";
>
> ---
> base-commit: f406055cb18c6e299c4a783fc1effeb16be41803
> change-id: 20251019-shift6mq-dt-e4b9e7dc7169
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards
2025-10-20 7:55 [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards Guido Günther
2025-10-20 10:16 ` Konrad Dybcio
@ 2025-10-20 11:06 ` Dmitry Baryshkov
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2025-10-20 11:06 UTC (permalink / raw)
To: Guido Günther
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
phone-devel
On Mon, Oct 20, 2025 at 09:55:13AM +0200, Guido Günther wrote:
> They're used in the parent to describe the panel's reg property.
>
> Fixes the
>
> linux/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dtb: panel@0 (visionox,rm69299-shift): '#address-cells', '#size-cells' do not match any of the regexes: '^pinctrl-[0-9]+$'
>
> warning.
>
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> index 89260fce6513..44e7b5015d26 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> @@ -472,6 +472,9 @@ &mdss_dsi0 {
> status = "okay";
> vdda-supply = <&vdda_mipi_dsi0_1p2>;
>
> + #address-cells = <1>;
> + #size-cells = <0>;
They are already a part of the device node.
> +
> panel@0 {
> compatible = "visionox,rm69299-shift";
> status = "okay";
> @@ -479,9 +482,6 @@ panel@0 {
> vdda-supply = <&vreg_l14a_1p88>;
> vdd3p3-supply = <&vreg_l28a_3p0>;
>
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
>
> pinctrl-names = "default", "sleep";
>
> ---
> base-commit: f406055cb18c6e299c4a783fc1effeb16be41803
> change-id: 20251019-shift6mq-dt-e4b9e7dc7169
>
> Best regards,
> --
> Guido Günther <agx@sigxcpu.org>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-20 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-20 7:55 [PATCH] arm64: dts: qcom: sdm845-shift-axolotl: Move address and size cells upwards Guido Günther
2025-10-20 10:16 ` Konrad Dybcio
2025-10-20 11:06 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox