From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ramshouriesh <rshouriesh@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Aleksandrs Vinarskis <alex@vinarskis.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-phy@lists.infradead.org
Subject: Re: [PATCH 6/9] arm64: dts/media: qcom: keep PLL8 out of Purwa camss hot path
Date: Wed, 10 Jun 2026 14:13:28 +0200 [thread overview]
Message-ID: <cae24847-407b-459f-9886-4b49c4efd511@kernel.org> (raw)
In-Reply-To: <20260610-a14-himax-hm1092-v1-6-0c9907da47ed@gmail.com>
On 10/06/2026 13:09, Ramshouriesh wrote:
> cam_cc_pll8 (defined in camcc-x1e80100.c) doesn't latch on Purwa
> silicon. "Lucid PLL latch failed. Output may be unstable!" fires from
> wait_for_pll() whenever something asks for a PLL8-sourced rate, and
> the camera pipeline ends up dead with "Failed to start media
> pipeline: -32" even after the qcom,x1p42100-camss compatible is in
> place.
>
> PLL8 sneaks into the streaming path via two RCG freq tables: the
> slow_ahb RCG defaults to its 64 MHz entry (PLL8-sourced) when CSID
> pulls it during csid_set_power, and vfe_lite picks its highest entry
> (480 MHz, also PLL8) at streamon.
>
> Fix this from the DT side:
>
> * pin slow_ahb at 80 MHz via assigned-clock-rates in purwa.dtsi so
> the RCG is reprogrammed to PLL0_OUT_EVEN at clk-init time and
> never reaches PLL8;
> * drop the 480 MHz entry from the Purwa vfe_lite clock_rate array
> so the driver caps at 400 MHz (PLL0_OUT_ODD).
>
> I went poking at the Qualcomm Windows BSP shipped for the UX3407QA to
> see what rates the vendor side actually uses. The AeoB resource blob
> at qccamplatform_ext8380/CAMP_{PERF,RES}_MTP.bin lists the camera
> clocks Windows enables, and PLL8 isn't referenced once. For CCI in
> particular Windows runs at 37.5 MHz off PLL0_OUT_EVEN, not the
> 30 MHz/PLL8 alternative the Linux driver happens to pick first.
> Whether PLL8 is fused off, trust-zone-only, or just unwired on this
> SoC I don't know, but treating it as unavailable matches what the
> vendor does.
>
> Signed-off-by: Ramshouriesh <rshouriesh@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/purwa.dtsi | 12 ++++++++++++
> drivers/media/platform/qcom/camss/camss.c | 16 ++++++++--------
You cannot combine such changes. DTS must be separate, see submitting
patches in DT, DTS coding style, SoC maintainer profile...
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-10 12:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 11:09 [PATCH 0/9] media/arm64: HM1092 IR camera and ASUS Zenbook A14 (X1P42100) camera support Ramshouriesh
2026-06-10 11:09 ` [PATCH 1/9] arm64: dts: qcom: x1-asus-zenbook-a14: Add on OV02C10 RGB sensor on CSIPHY4 Ramshouriesh
2026-06-10 11:09 ` [PATCH 2/9] media: dt-bindings: Add Himax HM1092 NIR sensor Ramshouriesh
2026-06-10 12:21 ` Bryan O'Donoghue
2026-06-10 11:09 ` [PATCH 3/9] media: i2c: hm1092: add Himax HM1092 mono NIR sensor driver Ramshouriesh
2026-06-10 12:11 ` Bryan O'Donoghue
2026-06-10 11:09 ` [PATCH 4/9] MAINTAINERS: add entry for the Himax HM1092 " Ramshouriesh
2026-06-10 12:24 ` Bryan O'Donoghue
2026-06-10 11:09 ` [PATCH 5/9] arm64: dts: qcom: x1-asus-zenbook-a14: add HM1092 IR camera and wire cameras to camss Ramshouriesh
2026-06-10 11:09 ` [PATCH 6/9] arm64: dts/media: qcom: keep PLL8 out of Purwa camss hot path Ramshouriesh
2026-06-10 12:13 ` Krzysztof Kozlowski [this message]
2026-06-10 11:09 ` [PATCH 7/9] arm64: dts: qcom: hamoa: reorder csiphy power-domains for v8 CSI2-PHY Ramshouriesh
2026-06-10 12:24 ` Bryan O'Donoghue
2026-06-10 11:09 ` [PATCH 8/9] dt-bindings: phy: qcom: add MIPI CSI2 mode constants Ramshouriesh
2026-06-10 11:09 ` [PATCH 9/9] phy: qcom-mipi-csi2: accept PHY_QCOM_CSI2_MODE_DPHY phy-cell Ramshouriesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae24847-407b-459f-9886-4b49c4efd511@kernel.org \
--to=krzk@kernel.org \
--cc=alex@vinarskis.com \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=rshouriesh@gmail.com \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox