Devicetree
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bod@kernel.org>
To: Frank Li <Frank.li@oss.nxp.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema
Date: Wed, 22 Jul 2026 02:53:10 +0100	[thread overview]
Message-ID: <cc9b087c-b985-416c-999a-a08f2abbf202@kernel.org> (raw)
In-Reply-To: <amAaKalbD749uZuK@SMW015318>

On 22/07/2026 02:17, Frank Li wrote:
>> Such design has a number of flaws and in general it looks overly
>> complicated. From the beginning it's unclear how to distinguish
>> a clock lane from a data lane, how to specify lane frequencies etc.
> Thanks, but phy-cell support more than one argument. like
> 
> 	<&phy 0 mode_cphy link_freq>
> 
> I ask these because simiar other phys may connect to display panel, some
> phys combine csi and dsi together.

For a combined CSI/DSI PHY that's a good model, and it re-establishes
the principle that the consumer chooses the mode.

For our simpler camera-only case the cell has less work to do. The
series carries #phy-cells = 1 per Rob's feedback and an RB from Krzysztof.

That's reviewed, tested and mergeable.

The one alternative under discussion with Vinod is bus-type in the CSID 
controller's endpoint with the mode conveyed via phy_configure(). Either 
way the consumer decides.

---
bod

  reply	other threads:[~2026-07-22  1:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20  1:11 [PATCH v13 0/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-07-20  1:11 ` [PATCH v13 1/2] dt-bindings: phy: qcom: Add CSI2 C-PHY/DPHY schema Bryan O'Donoghue
2026-07-20  1:20   ` sashiko-bot
2026-07-21  8:15   ` Neil Armstrong
2026-07-21  8:17   ` Vladimir Zapolskiy
2026-07-21  9:39     ` Bryan O'Donoghue
2026-07-21  9:56       ` Vladimir Zapolskiy
2026-07-21 10:47         ` Bryan O'Donoghue
2026-07-21 11:05           ` Vladimir Zapolskiy
2026-07-21 11:24             ` Bryan O'Donoghue
2026-07-21 13:19               ` Bryan O'Donoghue
2026-07-21 13:35                 ` Vladimir Zapolskiy
2026-07-21 14:06                   ` Bryan O'Donoghue
2026-07-21 19:24                   ` Bryan O'Donoghue
2026-07-21 18:57   ` Frank Li
2026-07-21 21:49     ` Vladimir Zapolskiy
2026-07-22  1:17       ` Frank Li
2026-07-22  1:53         ` Bryan O'Donoghue [this message]
2026-07-20  1:11 ` [PATCH v13 2/2] phy: qcom-mipi-csi2: Add a CSI2 MIPI DPHY driver Bryan O'Donoghue
2026-07-20  1:26   ` sashiko-bot
2026-07-20  3:23   ` Wenmeng Liu
2026-07-20  8:21   ` Loic Poulain
2026-07-21 11:30   ` Vladimir Zapolskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc9b087c-b985-416c-999a-a08f2abbf202@kernel.org \
    --to=bod@kernel.org \
    --cc=Frank.li@oss.nxp.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=vladimir.zapolskiy@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox