[PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions

[PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

The 'wakeup-source' property already has its type defined in the core
schema. The Rockchip MFD bindings redundantly specify 'type: boolean'
and provide descriptions which only repeat the generic meaning of the
property. Drop these redundant definitions and descriptions to clean
up the binding files and rely on the core schema instead.
No functional change intended.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml | 5 +----
 Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml | 5 +----
 Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml | 5 +----
 Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml | 5 +----
 Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml | 5 +----
 5 files changed, 5 insertions(+), 20 deletions(-)

diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
index 7c71447200ba..8e394ab6879b 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk801.yaml
@@ -29,10 +29,7 @@ properties:
     description:
       Telling whether or not this PMIC is controlling the system power.
 
-  wakeup-source:
-    type: boolean
-    description:
-      Device can be used as a wakeup source.
+  wakeup-source: true
 
   vcc1-supply:
     description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
index da2391530c16..548ba1f30712 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk805.yaml
@@ -48,10 +48,7 @@ properties:
 
   system-power-controller: true
 
-  wakeup-source:
-    type: boolean
-    description:
-      Device can be used as a wakeup source.
+  wakeup-source: true
 
   vcc1-supply:
     description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
index 50dfffac8fbf..40f8f23afad3 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk808.yaml
@@ -43,10 +43,7 @@ properties:
 
   system-power-controller: true
 
-  wakeup-source:
-    type: boolean
-    description:
-      Device can be used as a wakeup source.
+  wakeup-source: true
 
   vcc1-supply:
     description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
index 2cb6d176a84c..b99aaff100fb 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk817.yaml
@@ -55,10 +55,7 @@ properties:
 
   system-power-controller: true
 
-  wakeup-source:
-    type: boolean
-    description:
-      Device can be used as a wakeup source.
+  wakeup-source: true
 
   vcc1-supply:
     description:
diff --git a/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml b/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
index 90d944c27ba1..b7af774b1395 100644
--- a/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
+++ b/Documentation/devicetree/bindings/mfd/rockchip,rk818.yaml
@@ -43,10 +43,7 @@ properties:
 
   system-power-controller: true
 
-  wakeup-source:
-    type: boolean
-    description:
-      Device can be used as a wakeup source.
+  wakeup-source: true
 
   vcc1-supply:
     description:
-- 
2.43.0

[PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions

[phucduc.bui]

From: bui duc phuc <phucduc.bui@gmail.com>

The 'wakeup-source' property already has its type defined in the core
schema. A number of sound binding files redundantly specify the
'type: boolean' and provide descriptions which only repeat the generic
meaning of the property.
Drop these redundant definitions and descriptions to clean up the binding
files and rely on the core schema instead.
No functional change intended.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 Documentation/devicetree/bindings/sound/dialog,da7219.yaml  | 5 +----
 Documentation/devicetree/bindings/sound/realtek,rt5514.yaml | 4 +---
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
index 19137abdba3e..fab37cd92e0d 100644
--- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
+++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
@@ -45,10 +45,7 @@ properties:
       - wakeup
       - irq
 
-  wakeup-source:
-    type: boolean
-    description:
-      Flag to indicate this device can wake system (suspend/resume).
+  wakeup-source: true
 
   "#clock-cells":
     const: 1
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
index 7fbf7739c371..57e5c09c05c0 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5514.yaml
@@ -48,9 +48,7 @@ properties:
 
   spi-max-frequency: true
 
-  wakeup-source:
-    type: boolean
-    description: Flag to indicate this device can wake system (suspend/resume).
+  wakeup-source: true
 
 required:
   - compatible
-- 
2.43.0

Re: [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions

[Krzysztof Kozlowski]

On Thu, Apr 23, 2026 at 11:28:31AM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> The 'wakeup-source' property already has its type defined in the core

TYPES. It is plural.

> schema. A number of sound binding files redundantly specify the
> 'type: boolean' and provide descriptions which only repeat the generic
> meaning of the property.
> Drop these redundant definitions and descriptions to clean up the binding
> files and rely on the core schema instead.
> No functional change intended.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/dialog,da7219.yaml  | 5 +----
>  Documentation/devicetree/bindings/sound/realtek,rt5514.yaml | 4 +---
>  2 files changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> index 19137abdba3e..fab37cd92e0d 100644
> --- a/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> +++ b/Documentation/devicetree/bindings/sound/dialog,da7219.yaml
> @@ -45,10 +45,7 @@ properties:
>        - wakeup
>        - irq
>  
> -  wakeup-source:
> -    type: boolean
> -    description:
> -      Flag to indicate this device can wake system (suspend/resume).
> +  wakeup-source: true

That's wrong. Commit msg is making here false statements that it is
redundant. I checked (and you should too!) and driver does clearly
device_property_read_bool() thus the property CANNOT be the second type.

Best regards,
Krzysztof

Re: [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions

[Bui Duc Phuc]

Hi,

> > The 'wakeup-source' property already has its type defined in the core


> TYPES. It is plural.


Thank you for pointing that out. That was a mistake in my wording.
Regarding the two data types, I’m already aware of this and have
discussed it in a previous patch.

https://lore.kernel.org/all/CAABR9nH3hr+Y5ksD0cn3Gd9XUvmb07X7zJw0b4k_yVbnAuz9=w@mail.gmail.com/

> > -  wakeup-source:

> > -    type: boolean

> > -    description:

> > -      Flag to indicate this device can wake system (suspend/resume).

> > +  wakeup-source: true

>

> That's wrong. Commit msg is making here false statements that it is

> redundant. I checked (and you should too!) and driver does clearly

> device_property_read_bool() thus the property CANNOT be the second type.

I think Device Tree bindings should describe the hardware capability.
If the hardware supports wakeup functionality,
referencing the core schema is sufficient. Hardware description should
not be constrained by the current driver implementation
( e.g. the use of device_property_read_bool() ).
Bindings should remain stable and generic, while drivers can evolve over time.

Re-defining the type locally duplicates the core definition. If the
core schema evolves,
this approach would require touching many bindings instead of updating
one central place.

This follows the recent cleanups suggested by Rob

https://lore.kernel.org/all/177628888260.592110.11727813820499601669.robh@kernel.org/
https://lore.kernel.org/all/177679687272.1458365.1328485324673928433.robh@kernel.org/

Best regards,
Phuc

Re: [PATCH 2/2] ASoC: dt-bindings: drop redundant wakeup-source definitions

[Krzysztof Kozlowski]

On 27/04/2026 01:40, Bui Duc Phuc wrote:
> Hi,
> 
>>> The 'wakeup-source' property already has its type defined in the core
> 
> 
>> TYPES. It is plural.
> 
> 
> Thank you for pointing that out. That was a mistake in my wording.
> Regarding the two data types, I’m already aware of this and have
> discussed it in a previous patch.
> 
> https://lore.kernel.org/all/CAABR9nH3hr+Y5ksD0cn3Gd9XUvmb07X7zJw0b4k_yVbnAuz9=w@mail.gmail.com/
> 
>>> -  wakeup-source:
> 
>>> -    type: boolean
> 
>>> -    description:
> 
>>> -      Flag to indicate this device can wake system (suspend/resume).
> 
>>> +  wakeup-source: true
> 
>>
> 
>> That's wrong. Commit msg is making here false statements that it is
> 
>> redundant. I checked (and you should too!) and driver does clearly
> 
>> device_property_read_bool() thus the property CANNOT be the second type.
> 
> I think Device Tree bindings should describe the hardware capability.

Yes. And the ABI. You cannot have ABI which has an incompatible
implementation. IOW, when implementation contradicts the ABI, something
is wrong.

The question of course if read_bool() is here incompatible. From the
actual code point of view, it is compatible, but how it is documented
and how it is intended to use: it is not compatible.

Also if future schema-kernel-ABI checker gets implemented, the tool
might report here a mistake for that reason. read_bool() means property
is bool.


> If the hardware supports wakeup functionality,
> referencing the core schema is sufficient. Hardware description should
> not be constrained by the current driver implementation
> ( e.g. the use of device_property_read_bool() ).
> Bindings should remain stable and generic, while drivers can evolve over time.

So you claim that bindings can define property as integer, but drivers
can evolve and for example read it as string?

> 
> Re-defining the type locally duplicates the core definition. If the
> core schema evolves,

There is no re-definition here. This is choice of subset of types.

> this approach would require touching many bindings instead of updating
> one central place.
> 
> This follows the recent cleanups suggested by Rob
> 
> https://lore.kernel.org/all/177628888260.592110.11727813820499601669.robh@kernel.org/
> https://lore.kernel.org/all/177679687272.1458365.1328485324673928433.robh@kernel.org/

Where is Rob's suggestion to do such cleanups for EXISTING code? I only
see that new code should come like that.

Anyway, your commit msg is for me incorrect because it misses all this
points I made. Whether the schema code is correct, I'll defer to Rob,
although I still claim the same I claimed before at v2 or v3 of your
previous work - this should have defined type.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: mfd: rockchip: drop redundant wakeup-source definitions

[Krzysztof Kozlowski]

On Thu, Apr 23, 2026 at 11:28:30AM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> The 'wakeup-source' property already has its type defined in the core
> schema. The Rockchip MFD bindings redundantly specify 'type: boolean'

No, core schema has TWO types.

Defining it as type boolean is not redundant, because
of_property_read_bool() on non-bool is deprecated.

This must be explained somehow - are these device drivers expecting bool
or not?

Best regards,
Krzysztof