[PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[Alexander Koskovich]

This resolves the following error seen on the ASUS ROG Phone 3:

cpu cpu7: Voltage update failed freq=3091200
cpu cpu7: failed to update OPP for freq=3091200

Fixes: 8e0e8016cb79 ("arm64: dts: qcom: sm8250: Add CPU opp tables")
Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index c7dffa440074..37c41cc1abdd 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -665,6 +665,11 @@ cpu7_opp20: opp-2841600000 {
 			opp-hz = /bits/ 64 <2841600000>;
 			opp-peak-kBps = <8368000 51609600>;
 		};
+
+		cpu7_opp21: opp-3091200000 {
+			opp-hz = /bits/ 64 <3091200000>;
+			opp-peak-kBps = <8368000 51609600>;
+		};
 	};
 
 	firmware {

---
base-commit: 11439c4635edd669ae435eec308f4ab8a0804808
change-id: 20260307-sm8250-cpu7-opp-d34e2ed9d0a4

Best regards,
-- 
Alexander Koskovich <akoskovich@pm.me>

Re: [PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[Krzysztof Kozlowski]

On 08/03/2026 05:26, Alexander Koskovich wrote:
> This resolves the following error seen on the ASUS ROG Phone 3:

git grep "ASUS ROG Phone" gives me zero results so this is insufficient
argument considering you are changing multiple other devices which might
not support that.


Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[Alexander Koskovich]

On Sunday, March 8th, 2026 at 4:48 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> git grep "ASUS ROG Phone" gives me zero results so this is insufficient
> argument considering you are changing multiple other devices which might
> not support that.

Also I'm not 100% sure that this applies to all SM8250 devices, should I just fold this into the ROG 3 DTS submission later and put it in the board specific DTS? As I can't validate it on any other SM8250.

Thanks,
Alex

Re: [PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[Konrad Dybcio]

On 3/8/26 7:03 PM, Alexander Koskovich wrote:
> On Sunday, March 8th, 2026 at 4:48 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> git grep "ASUS ROG Phone" gives me zero results so this is insufficient
>> argument considering you are changing multiple other devices which might
>> not support that.
> 
> Also I'm not 100% sure that this applies to all SM8250 devices, should I just fold this into the ROG 3 DTS submission later and put it in the board specific DTS? As I can't validate it on any other SM8250.

The qcom-cpufreq-hw driver reads out the LUT that has been programmed
into the device and only considers OPPs that match those entries, so no
worries here.

This is the case for all Qualcomm SoCs starting with SDM845.

For reference, SDM630/MSM8998 use the same hardware, but need
programming from the HLOS which is notoriously long and annoying, there
you can actually make mistakes that result in instability.

Konrad

Re: [PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[Konrad Dybcio]

On 3/8/26 5:26 AM, Alexander Koskovich wrote:
> This resolves the following error seen on the ASUS ROG Phone 3:
> 
> cpu cpu7: Voltage update failed freq=3091200
> cpu cpu7: failed to update OPP for freq=3091200
> 
> Fixes: 8e0e8016cb79 ("arm64: dts: qcom: sm8250: Add CPU opp tables")
> Signed-off-by: Alexander Koskovich <akoskovich@pm.me>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP

[Bjorn Andersson]

On Sun, 08 Mar 2026 04:26:37 +0000, Alexander Koskovich wrote:
> This resolves the following error seen on the ASUS ROG Phone 3:
> 
> cpu cpu7: Voltage update failed freq=3091200
> cpu cpu7: failed to update OPP for freq=3091200
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sm8250: Add missing CPU7 3.09GHz OPP
      commit: b683730e27ba4f91986c4c92f5cb7297f1e01a6d

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>