From: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/4] regulator: add the Will Semiconductor WL2868C camera PMIC
Date: Sat, 31 Oct 2026 14:55:30 +0800 [thread overview]
Message-ID: <cover.1793427040.git.xiaqinghuan@mail.ustc.edu.cn> (raw)
In-Reply-To: <20261031034300.272730-1-xiaqinghuan@mail.ustc.edu.cn>
The WL2868C is the camera PMIC on the Lenovo Legion Tab (TB322FC,
SM8750); its seven LDOs feed the rear camera, the front camera and the
VCM on i2c10.
v3 was reviewed by sashiko and Krzysztof; what changed, point by point:
- i2c10 was enabled while its parents were not, so the bus could never
populate and none of the regulators it hosts could have registered.
The board DTS now enables qupv3_2 and gpi_dma2 alongside i2c10
(sashiko, High).
- The binding schema, the SoC dtsi and the board DTS were mixed in the
board patch. The series is now one binding patch (including the
arm/qcom.yaml registration), one driver patch, one sm8750.dtsi patch
and one board DTS patch (sashiko, Low; checkpatch flagged the same
thing).
- The sm8750.dtsi patch now leaves both I2C buses of each CCI
controller available instead of disabling bus 1, as sm8550.dtsi and
sm8650.dtsi do, and carries the bus 1 pinctrl states on gpio115/116
and gpio119/120 (sashiko, Low).
- The CCI nodes moved after videocc@aaf0000 into unit-address order,
and the new pinctrl states sit alphabetically inside &tlmm (sashiko,
Low).
- The commit message now says that the SoC has three CCI controllers
of which two are described, instead of "the two CCI I2C
controllers" (sashiko, Low).
- The front galaxycore,gc08a8 node is dropped: it has no binding at
all, unlike samsung,s5kjns and giantec,gt9764, whose bindings were
posted separately and are still in review. LDO2 and LDO3 stay wired
in the board file for when that series lands. The sensor nodes also
lost their power-domains property: the TITAN_TOP GDSC belongs to the
camera controller that owns the CCI bus, not to an I2C sensor, which
is powered through its supplies and its reset GPIO (sashiko,
Medium). The rear sensor gained its CSI-2 endpoint; the
remote-endpoint side arrives with the camera subsystem series.
Everything above is host-side only. The i2c10 probe and the runtime
existence of the regulators are still unverified on hardware; the
on-board evidence reported earlier (i2c-10 present, camera_ldo1..5,7
registered, LDO6 without consumer) comes from our own downstream board
DTS, not from the files in this series.
Qianhui Xu (4):
regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC
regulator: willsemi,wl2868c: add the WL2868C camera PMIC driver
arm64: dts: qcom: sm8750: describe two of the three CCI I2C
controllers
arm64: dts: qcom: sm8750-lenovo-elden: describe the WL2868C regulators
.../devicetree/bindings/arm/qcom.yaml | 1 +
.../bindings/regulator/willsemi,wl2868c.yaml | 79 ++++++++
MAINTAINERS | 7 +
arch/arm64/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/sm8750-lenovo-elden.dts | 175 ++++++++++++++++++
arch/arm64/boot/dts/qcom/sm8750.dtsi | 158 ++++++++++++++++
drivers/regulator/Kconfig | 11 ++
drivers/regulator/Makefile | 1 +
drivers/regulator/wl2868c-regulator.c | 155 ++++++++++++++++
9 files changed, 588 insertions(+)
create mode 100644 Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
create mode 100644 arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
create mode 100644 drivers/regulator/wl2868c-regulator.c
--
2.53.0
next prev parent reply other threads:[~2026-10-31 6:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 12:04 [PATCH v2] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC Qianhui Xu
2026-10-29 8:55 ` Krzysztof Kozlowski
2026-10-31 3:39 ` Qianhui Xu
2026-10-31 5:29 ` Qianhui Xu
2026-10-31 3:42 ` [PATCH v3 0/3] regulator: add the WL2868C camera PMIC and its users Qianhui Xu
2026-10-31 3:42 ` [PATCH v3 1/3] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC Qianhui Xu
2026-10-31 3:42 ` [PATCH v3 2/3] regulator: willsemi,wl2868c: add the WL2868C camera PMIC driver Qianhui Xu
2026-10-31 3:43 ` [PATCH v3 3/3] arm64: dts: qcom: sm8750-lenovo-elden: describe the WL2868C regulators Qianhui Xu
2026-10-31 4:00 ` sashiko-bot
2026-10-31 5:27 ` Qianhui Xu
2026-10-31 6:55 ` Qianhui Xu [this message]
2026-10-31 6:55 ` [PATCH v4 1/4] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC Qianhui Xu
2026-10-31 7:01 ` sashiko-bot
2026-10-31 6:55 ` [PATCH v4 2/4] regulator: willsemi,wl2868c: add the WL2868C camera PMIC driver Qianhui Xu
2026-10-31 6:55 ` [PATCH v4 3/4] arm64: dts: qcom: sm8750: describe two of the three CCI I2C controllers Qianhui Xu
2026-10-31 6:55 ` [PATCH v4 4/4] arm64: dts: qcom: sm8750-lenovo-elden: describe the WL2868C regulators Qianhui Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1793427040.git.xiaqinghuan@mail.ustc.edu.cn \
--to=xiaqinghuan@mail.ustc.edu.cn \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox