From: sashiko-bot@kernel.org
To: "Qianhui Xu" <xiaqinghuan@mail.ustc.edu.cn>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 1/4] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC
Date: Sat, 31 Oct 2026 07:01:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-191791@kernel.org> (raw)
In-Reply-To: <7f2062a377f701fbaa649f31c954edcce15b4d12.1793427040.git.xiaqinghuan@mail.ustc.edu.cn>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: regulator: unrelated qcom.yaml change in wl2868c commit
--
commit d44859d04307b0410c0a5a81166a61fd6f065d00
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC
This commit adds the device tree binding schema for the Will Semiconductor
WL2868C I2C-controlled camera power management IC with seven programmable
LDOs.
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index ff8a35df7862d..41d5e65c4eea5 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1168,6 +1168,7 @@ properties:
>
> - items:
> - enum:
> + - lenovo,elden
> - qcom,sm8750-mtp
> - qcom,sm8750-qrd
> - const: qcom,sm8750
[Severity: Low]
Was this addition of lenovo,elden to properties.compatible in
Documentation/devicetree/bindings/arm/qcom.yaml included here by mistake?
This patch adds the regulator binding schema in
Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml, and
neither the commit title nor the changelog mentions adding a top-level
qcom,sm8750 board compatible string.
Should the lenovo,elden compatible addition in
Documentation/devicetree/bindings/arm/qcom.yaml be split into a separate
dt-bindings: arm: qcom: patch so it can be routed through the Qualcomm SoC
tree independently of the regulator binding?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1793427040.git.xiaqinghuan@mail.ustc.edu.cn?part=1
next prev parent reply other threads:[~2026-10-31 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 12:04 [PATCH v2] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC Qianhui Xu
2026-10-29 8:55 ` Krzysztof Kozlowski
2026-10-31 3:39 ` Qianhui Xu
2026-10-31 5:29 ` Qianhui Xu
2026-10-31 3:42 ` [PATCH v3 0/3] regulator: add the WL2868C camera PMIC and its users Qianhui Xu
2026-10-31 3:42 ` [PATCH v3 1/3] regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC Qianhui Xu
2026-10-31 3:42 ` [PATCH v3 2/3] regulator: willsemi,wl2868c: add the WL2868C camera PMIC driver Qianhui Xu
2026-10-31 3:43 ` [PATCH v3 3/3] arm64: dts: qcom: sm8750-lenovo-elden: describe the WL2868C regulators Qianhui Xu
2026-10-31 4:00 ` sashiko-bot
2026-10-31 5:27 ` Qianhui Xu
2026-10-31 6:55 ` [PATCH v4 0/4] regulator: add the Will Semiconductor WL2868C camera PMIC Qianhui Xu
2026-10-31 6:55 ` [PATCH v4 1/4] regulator: dt-bindings: willsemi,wl2868c: add the " Qianhui Xu
2026-10-31 7:01 ` sashiko-bot [this message]
2026-10-31 6:55 ` [PATCH v4 2/4] regulator: willsemi,wl2868c: add the WL2868C camera PMIC driver Qianhui Xu
2026-10-31 6:55 ` [PATCH v4 3/4] arm64: dts: qcom: sm8750: describe two of the three CCI I2C controllers Qianhui Xu
2026-10-31 7:10 ` sashiko-bot
2026-10-31 6:55 ` [PATCH v4 4/4] arm64: dts: qcom: sm8750-lenovo-elden: describe the WL2868C regulators Qianhui Xu
2026-10-31 7:06 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-191791@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xiaqinghuan@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox