From: Matti Vaittinen <matti.vaittinen@linux.dev>
To: sashiko-reviews@lists.linux.dev
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
Jonathan Cameron <jic23@kernel.org>,
open list <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111
Date: Fri, 20 Nov 2026 14:53:32 +0200 [thread overview]
Message-ID: <d2d8049d-7adc-4cfb-8e56-3af55c0abe8f@linux.dev> (raw)
In-Reply-To: <sashiko-outbox-225147@kernel.org>
On 20/11/2026 14:34, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issues to consider:
> - [Low] iio: adc: rohm-bd79112: double semicolon in bd79112_probe()
> - [Low] iio: adc: rohm-bd79112: unused BD79112_MAX_NUM_CHANNELS macro
> --
>
> commit d2b6757018d5ccee4c939ad0350d93a29d26239d
> Author: Matti Vaittinen <mazziesaccount@gmail.com>
>
> iio: adc: rohm-bd79112: Support ROHM BD79111
>
> This commit adds support for the 16-channel ROHM BD79111 SAR ADC and GPIO
> device to the rohm-bd79112 driver.
>
>> diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c
>> index 04084e88984a5..8bbb86098ff5a 100644
>> --- a/drivers/iio/adc/rohm-bd79112.c
>> +++ b/drivers/iio/adc/rohm-bd79112.c
>
> [ ... ]
>
>> @@ -431,8 +458,17 @@ static const char * const bd79112_chan_names[] = {
>> "AGIO12B", "AGIO13B", "AGIO14B", "AGIO15B", /* 28 - 31 */
>> };
>>
>> +static const struct bd7911x_chip_data bd79111_chip_data = {
>> + .name = "bd79111",
>> + .chan_names = bd79111_chan_names,
>> + .num_max_channels = 16,
>> + .init_disable_gpios = bd79111_disable_gpios,
>> +};
>> +
>> static const struct bd7911x_chip_data bd79112_chip_data = {
>> + .name = "bd79112",
>> .chan_names = bd79112_chan_names,
>> + .num_max_channels = 32,
>> .init_disable_gpios = bd79112_disable_gpios,
>> };
>
> [Severity: Low]
> This isn't a bug, but replacing the remaining uses of
> BD79112_MAX_NUM_CHANNELS in bd79112_probe() with
> data->cd->num_max_channels leaves the BD79112_MAX_NUM_CHANNELS macro
> unused.
>
> [ ... ]
>
>> @@ -509,7 +545,7 @@ static int bd79112_probe(struct spi_device *spi)
>> cs[i].datasheet_name = data->cd->chan_names[cs[i].channel];
>>
>> iio_dev->info = &bd79112_info;
>> - iio_dev->name = "bd79112";
>> + iio_dev->name = data->cd->name;;
>> iio_dev->modes = INDIO_DIRECT_MODE;
>
> [Severity: Low]
> This isn't a bug, but there is a double semicolon at the end of this
> assignment.
>
Both of the Sashiko's findings seem correct. However, I wonder why it
picked the device-tree folks and dropped IIO people? This particular
patch didn't have binding changes but driver changes. (Well I added
Jonathan + IIO-list here)
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
prev parent reply other threads:[~2026-11-20 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:26 [PATCH v2 0/3] Support ROHM BD79111 ADC/GPIO Matti Vaittinen
2026-11-20 12:27 ` [PATCH v2 1/3] dt-bindings: iio: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:28 ` [PATCH v2 2/3] iio: adc: rohm-bd79112: Add chip info structure Matti Vaittinen
2026-11-20 12:28 ` [PATCH v2 3/3] iio: adc: rohm-bd79112: Support ROHM BD79111 Matti Vaittinen
2026-11-20 12:34 ` sashiko-bot
2026-11-20 12:53 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2d8049d-7adc-4cfb-8e56-3af55c0abe8f@linux.dev \
--to=matti.vaittinen@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox