From: YLCHANG2 <neo.chang70@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Neo Chang <YLCHANG2@nuvoton.com>,
lgirdwood@gmail.com, perex@perex.cz, robh@kernel.org,
krzk+dt@kernel.org, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kchsu0@nuvoton.com, sjlin0@nuvoton.com
Subject: Re: [PATCH v2 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier
Date: Fri, 22 May 2026 10:18:49 +0800 [thread overview]
Message-ID: <d61bf634-75c2-f0dd-cbd0-8a4abea8591b@gmail.com> (raw)
In-Reply-To: <934509a9-1347-4b02-a341-0db0d1db42e7@sirena.org.uk>
On 5/21/26 23:35, Mark Brown wrote:
> On Wed, May 20, 2026 at 11:01:53AM +0800, YLCHANG2 wrote:
>> On 5/18/26 19:35, Mark Brown wrote:
>>>> +static bool nau8360_volatile_reg(struct device *dev, unsigned int reg)
>>>> +{
>>>> + switch (reg) {
>>>> + case NAU8360_R00_SOFTWARE_RST ... NAU8360_R02_I2C_ADDR:
>>>> + case NAU8360_R06_INT_CLR_STATUS:
>>>> + case NAU8360_R21_VBAT_READOUT ... NAU8360_R22_TEMP_READOUT:
>>>> + case NAU8360_R41_CLK_CTL2:
>>>> + case NAU8360_R46_I2C_DEVICE_ID:
>>> Are the I2C addresss and device ID volatile or do they just not have
>>> defaults?
>> For NAU8360_R02_I2C_ADDR, it requires a write operation to latch the I2C
>> device address.
>> For NAU8360_R46_I2C_DEVICE_ID, although it is read-only, its value is
>> determined by the hardware configuration
>> of the GPIO1 and GPIO2 pins at boot (e.g., 0x1a, 0x1b, 0x4a, or 0x4b).
> In that case they shouldn't be marked as volatile, just omitted from the
> defaults - they can be cached on first use.
Thanks for the suggestion. I will remove it from the volatile register list.
prev parent reply other threads:[~2026-05-22 2:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 2:47 [PATCH v2 0/2] ASoC: codecs: Add Nuvoton NAU83G60 audio codec driver Neo Chang
2026-05-18 2:47 ` [PATCH v2 1/2] ASoC: dt-bindings: nuvoton,nau8360: Add NAU83G60 Neo Chang
2026-05-18 2:53 ` sashiko-bot
2026-05-18 4:36 ` Rob Herring (Arm)
2026-05-18 12:02 ` Krzysztof Kozlowski
2026-05-20 3:22 ` YLCHANG2
2026-05-18 2:47 ` [PATCH v2 2/2] ASoC: codecs: nau8360: Add support for NAU83G60 amplifier Neo Chang
2026-05-18 3:23 ` sashiko-bot
2026-05-18 11:35 ` Mark Brown
2026-05-20 3:22 ` YLCHANG2
[not found] ` <ddacfe50-072d-66fd-c760-c898bdab52f4@gmail.com>
2026-05-21 15:35 ` Mark Brown
2026-05-22 2:18 ` YLCHANG2 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d61bf634-75c2-f0dd-cbd0-8a4abea8591b@gmail.com \
--to=neo.chang70@gmail.com \
--cc=YLCHANG2@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kchsu0@nuvoton.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=sjlin0@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox