* [PATCH v8 1/9] media: dt-bindings: venus: Add qcom,msm8939 schema
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
` (6 subsequent siblings)
7 siblings, 0 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas,
Bryan O'Donoghue, Krzysztof Kozlowski
From: André Apitzsch <git@apitzsch.eu>
Add a schema description for the Venus video decoder/encoder IP in
MSM8939.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
.../bindings/media/qcom,msm8939-venus.yaml | 79 ++++++++++++++++++++++
1 file changed, 79 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml b/Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml
new file mode 100644
index 000000000000..10a50a410748
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,msm8939-venus.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/qcom,msm8939-venus.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm MSM8939 Venus video encode and decode accelerators
+
+maintainers:
+ - André Apitzsch <git@apitzsch.eu>
+ - Erikas Bitovtas <xerikasxx@gmail.com>
+
+description:
+ The Venus IP is a video encode and decode accelerator present
+ on Qualcomm platforms
+
+allOf:
+ - $ref: qcom,venus-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,msm8939-venus
+
+ power-domains:
+ maxItems: 3
+
+ power-domain-names:
+ items:
+ - const: venus
+ - const: vcodec0
+ - const: vcodec1
+
+ clocks:
+ maxItems: 5
+
+ clock-names:
+ items:
+ - const: core
+ - const: iface
+ - const: bus
+ - const: vcodec0_core
+ - const: vcodec1_core
+
+ iommus:
+ maxItems: 1
+
+required:
+ - compatible
+ - iommus
+ - power-domain-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/qcom,gcc-msm8939.h>
+
+ video-codec@1d00000 {
+ compatible = "qcom,msm8939-venus";
+ reg = <0x01d00000 0xff000>;
+ interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>,
+ <&gcc GCC_VENUS0_AHB_CLK>,
+ <&gcc GCC_VENUS0_AXI_CLK>,
+ <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>,
+ <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>;
+ clock-names = "core",
+ "iface",
+ "bus",
+ "vcodec0_core",
+ "vcodec1_core";
+ power-domains = <&gcc VENUS_GDSC>,
+ <&gcc VENUS_CORE0_GDSC>,
+ <&gcc VENUS_CORE1_GDSC>;
+ power-domain-names = "venus", "vcodec0", "vcodec1";
+ iommus = <&apps_iommu 5>;
+ memory-region = <&venus_mem>;
+ };
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 1/9] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-20 8:32 ` Bryan O'Donoghue
2026-05-19 15:10 ` [PATCH v8 3/9] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
` (5 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas
Allow Venus core GDSCs to have their control passed to hardware, so they
can be powered on by Venus firmware.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
drivers/clk/qcom/gcc-msm8939.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
index 45193b3d714b..243d31a32e92 100644
--- a/drivers/clk/qcom/gcc-msm8939.c
+++ b/drivers/clk/qcom/gcc-msm8939.c
@@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
.halt_reg = 0x4c02c,
+ .halt_check = BRANCH_HALT_SKIP,
.clkr = {
.enable_reg = 0x4c02c,
.enable_mask = BIT(0),
@@ -3681,6 +3682,7 @@ static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
static struct clk_branch gcc_venus0_core1_vcodec0_clk = {
.halt_reg = 0x4c034,
+ .halt_check = BRANCH_HALT_SKIP,
.clkr = {
.enable_reg = 0x4c034,
.enable_mask = BIT(0),
@@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = {
.pd = {
.name = "venus_core0",
},
+ .flags = HW_CTRL_TRIGGER,
.pwrsts = PWRSTS_OFF_ON,
};
@@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = {
.pd = {
.name = "venus_core1",
},
+ .flags = HW_CTRL_TRIGGER,
.pwrsts = PWRSTS_OFF_ON,
};
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-19 15:10 ` [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
@ 2026-05-20 8:32 ` Bryan O'Donoghue
2026-05-20 8:41 ` Bryan O'Donoghue
2026-05-21 9:29 ` Taniya Das
0 siblings, 2 replies; 22+ messages in thread
From: Bryan O'Donoghue @ 2026-05-20 8:32 UTC (permalink / raw)
To: Erikas Bitovtas, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney, Taniya Das
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 19/05/2026 16:10, Erikas Bitovtas wrote:
> Allow Venus core GDSCs to have their control passed to hardware, so they
> can be powered on by Venus firmware.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> drivers/clk/qcom/gcc-msm8939.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-msm8939.c
> index 45193b3d714b..243d31a32e92 100644
> --- a/drivers/clk/qcom/gcc-msm8939.c
> +++ b/drivers/clk/qcom/gcc-msm8939.c
> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
>
> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
> .halt_reg = 0x4c02c,
> + .halt_check = BRANCH_HALT_SKIP,
> .clkr = {
> .enable_reg = 0x4c02c,
> .enable_mask = BIT(0),
> @@ -3681,6 +3682,7 @@ static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>
> static struct clk_branch gcc_venus0_core1_vcodec0_clk = {
> .halt_reg = 0x4c034,
> + .halt_check = BRANCH_HALT_SKIP,
> .clkr = {
> .enable_reg = 0x4c034,
> .enable_mask = BIT(0),
> @@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = {
> .pd = {
> .name = "venus_core0",
> },
> + .flags = HW_CTRL_TRIGGER,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
> @@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = {
> .pd = {
> .name = "venus_core1",
> },
> + .flags = HW_CTRL_TRIGGER,
> .pwrsts = PWRSTS_OFF_ON,
> };
>
>
> --
> 2.54.0
>
@Tanyia
Can you confirm this change please ?
---
bod
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-20 8:32 ` Bryan O'Donoghue
@ 2026-05-20 8:41 ` Bryan O'Donoghue
2026-05-21 9:29 ` Taniya Das
1 sibling, 0 replies; 22+ messages in thread
From: Bryan O'Donoghue @ 2026-05-20 8:41 UTC (permalink / raw)
To: Erikas Bitovtas, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney, Taniya Das
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 20/05/2026 09:32, Bryan O'Donoghue wrote:
> On 19/05/2026 16:10, Erikas Bitovtas wrote:
>> Allow Venus core GDSCs to have their control passed to hardware, so they
>> can be powered on by Venus firmware.
>>
>> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
>> ---
>> drivers/clk/qcom/gcc-msm8939.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-
>> msm8939.c
>> index 45193b3d714b..243d31a32e92 100644
>> --- a/drivers/clk/qcom/gcc-msm8939.c
>> +++ b/drivers/clk/qcom/gcc-msm8939.c
>> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
>>
>> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>> .halt_reg = 0x4c02c,
>> + .halt_check = BRANCH_HALT_SKIP,
>> .clkr = {
>> .enable_reg = 0x4c02c,
>> .enable_mask = BIT(0),
>> @@ -3681,6 +3682,7 @@ static struct clk_branch
>> gcc_venus0_core0_vcodec0_clk = {
>>
>> static struct clk_branch gcc_venus0_core1_vcodec0_clk = {
>> .halt_reg = 0x4c034,
>> + .halt_check = BRANCH_HALT_SKIP,
>> .clkr = {
>> .enable_reg = 0x4c034,
>> .enable_mask = BIT(0),
>> @@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = {
>> .pd = {
>> .name = "venus_core0",
>> },
>> + .flags = HW_CTRL_TRIGGER,
>> .pwrsts = PWRSTS_OFF_ON,
>> };
>>
>> @@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = {
>> .pd = {
>> .name = "venus_core1",
>> },
>> + .flags = HW_CTRL_TRIGGER,
>> .pwrsts = PWRSTS_OFF_ON,
>> };
>>
>>
>> --
>> 2.54.0
>>
>
> @Tanyia
>
> Can you confirm this change please ?
>
> ---
> bod
This series looks good to go but we need to get the clock change agreed
and merged first.
---
bod
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-20 8:32 ` Bryan O'Donoghue
2026-05-20 8:41 ` Bryan O'Donoghue
@ 2026-05-21 9:29 ` Taniya Das
2026-05-22 10:48 ` Erikas Bitovtas
1 sibling, 1 reply; 22+ messages in thread
From: Taniya Das @ 2026-05-21 9:29 UTC (permalink / raw)
To: Bryan O'Donoghue, Erikas Bitovtas, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 5/20/2026 2:02 PM, Bryan O'Donoghue wrote:
> On 19/05/2026 16:10, Erikas Bitovtas wrote:
>> Allow Venus core GDSCs to have their control passed to hardware, so they
>> can be powered on by Venus firmware.
>>
>> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
>> ---
>> drivers/clk/qcom/gcc-msm8939.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-
>> msm8939.c
>> index 45193b3d714b..243d31a32e92 100644
>> --- a/drivers/clk/qcom/gcc-msm8939.c
>> +++ b/drivers/clk/qcom/gcc-msm8939.c
>> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
>>
>> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>> .halt_reg = 0x4c02c,
>> + .halt_check = BRANCH_HALT_SKIP,
please use .halt_check = BRANCH_HALT
>> .clkr = {
>> .enable_reg = 0x4c02c,
>> .enable_mask = BIT(0),
>> @@ -3681,6 +3682,7 @@ static struct clk_branch
>> gcc_venus0_core0_vcodec0_clk = {
>>
>> static struct clk_branch gcc_venus0_core1_vcodec0_clk = {
>> .halt_reg = 0x4c034,
>> + .halt_check = BRANCH_HALT_SKIP,
please use .halt_check = BRANCH_HALT
>> .clkr = {
>> .enable_reg = 0x4c034,
>> .enable_mask = BIT(0),
>> @@ -3753,6 +3755,7 @@ static struct gdsc venus_core0_gdsc = {
>> .pd = {
>> .name = "venus_core0",
>> },
>> + .flags = HW_CTRL_TRIGGER,
>> .pwrsts = PWRSTS_OFF_ON,
>> };
>>
>> @@ -3761,6 +3764,7 @@ static struct gdsc venus_core1_gdsc = {
>> .pd = {
>> .name = "venus_core1",
>> },
>> + .flags = HW_CTRL_TRIGGER,
>> .pwrsts = PWRSTS_OFF_ON,
>> };
>>
>>
>> --
>> 2.54.0
>>
>
> @Tanyia
>
> Can you confirm this change please ?
>
> ---
> bod
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-21 9:29 ` Taniya Das
@ 2026-05-22 10:48 ` Erikas Bitovtas
2026-05-25 5:51 ` Taniya Das
0 siblings, 1 reply; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-22 10:48 UTC (permalink / raw)
To: Taniya Das, Bryan O'Donoghue, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 5/21/26 12:29 PM, Taniya Das wrote:
>
>
> On 5/20/2026 2:02 PM, Bryan O'Donoghue wrote:
>> On 19/05/2026 16:10, Erikas Bitovtas wrote:
>>> Allow Venus core GDSCs to have their control passed to hardware, so they
>>> can be powered on by Venus firmware.
>>>
>>> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
>>> ---
>>> drivers/clk/qcom/gcc-msm8939.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/clk/qcom/gcc-msm8939.c b/drivers/clk/qcom/gcc-
>>> msm8939.c
>>> index 45193b3d714b..243d31a32e92 100644
>>> --- a/drivers/clk/qcom/gcc-msm8939.c
>>> +++ b/drivers/clk/qcom/gcc-msm8939.c
>>> @@ -3664,6 +3664,7 @@ static struct clk_branch gcc_venus0_vcodec0_clk = {
>>>
>>> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>>> .halt_reg = 0x4c02c,
>>> + .halt_check = BRANCH_HALT_SKIP,
>
> please use .halt_check = BRANCH_HALT
>
If I do that, the clock fails to power on on boot.
[ 20.324488] ------------[ cut here ]------------
[ 20.324520] gcc_venus0_core0_vcodec0_clk status stuck at 'off'
[ 20.324663] WARNING: drivers/clk/qcom/clk-branch.c:88 at
clk_branch_toggle+0x124/0x170, CPU#7: (udev-worker)/1010
[ 20.324723] Modules linked in: snd_soc_apq8016_sbc(+)
snd_soc_qcom_common venus_core(+) qcom_q6v5_mss(+) v4l2_mem2mem
qcom_pil_info videobuf2_v4l2 qcom_common qcom_q6v5 videobuf2_common
videodev mc qcom_memshare tun binfmt_misc nft_reject_inet nft_reject
nf_reject_ipv6 nf_reject_ipv4 nft_ct nf_conntrack zram nf_defrag_ipv6
nf_defrag_ipv4 zsmalloc lz4_compress zstd_compress nf_tables uhid uinput
fuse nfnetlink ipv6 xfs usb_f_ncm u_ether panel_asus_z00t_tm5p5_nt35596
edt_ft5x06 pm8916_bms_vm msm ubwc_config mdt_loader gpu_sched drm_gpuvm
drm_exec drm_display_helper cec libcomposite
[ 20.325245] CPU: 7 UID: 0 PID: 1010 Comm: (udev-worker) Not tainted
7.0.0-msm8916 #41 PREEMPT
[ 20.325273] Hardware name: Asus ZenFone 2 Laser/Selfie (1080p) (DT)
[ 20.325290] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO -DIT -SSBS
BTYPE=--)
[ 20.325314] pc : clk_branch_toggle+0x124/0x170
[ 20.325348] lr : clk_branch_toggle+0x120/0x170
[ 20.325377] sp : ffff800082ab3430
[ 20.325390] x29: ffff800082ab3440 x28: 0000000000000001 x27:
ffff0000236724c0
[ 20.325435] x26: 0000000000000002 x25: ffff0000236724c0 x24:
0000000000000000
[ 20.325477] x23: 0000000000000000 x22: ffff800081017b3e x21:
ffff8000813e9f38
[ 20.325519] x20: ffff8000806f7f50 x19: 0000000000000001 x18:
0000000000000000
[ 20.325560] x17: 0000000000000001 x16: 0000000000000800 x15:
0000000000000003
[ 20.325601] x14: ffff800081315120 x13: 0000000000000003 x12:
0000000000000003
[ 20.325643] x11: 0000000000000000 x10: 0000000000000027 x9 :
ebcfd48ff0c24800
[ 20.325684] x8 : ebcfd48ff0c24800 x7 : 7461206b63757473 x6 :
0000000000000027
[ 20.325725] x5 : ffff80008151038a x4 : ffff800080fc8d13 x3 :
0000000000000000
[ 20.325766] x2 : 0000000000000000 x1 : ffff800082ab3200 x0 :
00000000fffffff0
[ 20.325808] Call trace:
[ 20.325821] clk_branch_toggle+0x124/0x170 (P)
[ 20.325859] clk_branch2_enable+0x20/0x30
[ 20.325894] clk_core_enable+0x6c/0x2c8
[ 20.325923] clk_core_enable_lock+0x8c/0x120
[ 20.325960] clk_enable+0x1c/0x30
[ 20.325994] vcodec_clks_enable+0x4c/0xc8 [venus_core]
[ 20.326190] core_power_v1+0x270/0x2c0 [venus_core]
[ 20.326370] venus_runtime_resume+0x58/0x80 [venus_core]
[ 20.326548] pm_generic_runtime_resume+0x2c/0x48
[ 20.326579] __rpm_callback+0x80/0x470
[ 20.326609] rpm_resume+0x3cc/0x5f8
[ 20.326637] __pm_runtime_resume+0x4c/0x98
[ 20.326665] venus_probe+0x1fc/0x3b8 [venus_core]
[ 20.326844] platform_probe+0x60/0xa8
[ 20.326881] really_probe+0x154/0x448
[ 20.326911] __driver_probe_device+0xa4/0x120
[ 20.326943] driver_probe_device+0x44/0x230
[ 20.326973] __driver_attach+0xf0/0x280
[ 20.327003] bus_for_each_dev+0xf0/0x150
[ 20.327031] driver_attach+0x28/0x38
[ 20.327061] bus_add_driver+0x14c/0x2a8
[ 20.327088] driver_register+0x6c/0x108
[ 20.327119] __platform_driver_register+0x24/0x38
[ 20.327154] init_module+0x24/0xfb8 [venus_core]
[ 20.327332] do_one_initcall+0xe4/0x3e0
[ 20.327363] do_init_module+0x5c/0x248
[ 20.327393] load_module+0x16ac/0x18c0
[ 20.327421] __arm64_sys_finit_module+0x238/0x360
[ 20.327449] invoke_syscall+0x44/0xd8
[ 20.327483] el0_svc_common+0x84/0xe0
[ 20.327515] do_el0_svc+0x20/0x30
[ 20.327547] el0_svc+0x24/0x70
[ 20.327582] el0t_64_sync_handler+0x7c/0x120
[ 20.327616] el0t_64_sync+0x154/0x158
[ 20.327643] ---[ end trace 0000000000000000 ]---
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-22 10:48 ` Erikas Bitovtas
@ 2026-05-25 5:51 ` Taniya Das
2026-05-25 9:56 ` Erikas Bitovtas
0 siblings, 1 reply; 22+ messages in thread
From: Taniya Das @ 2026-05-25 5:51 UTC (permalink / raw)
To: Erikas Bitovtas, Bryan O'Donoghue, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 5/22/2026 4:18 PM, Erikas Bitovtas wrote:
>>>> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>>>> .halt_reg = 0x4c02c,
>>>> + .halt_check = BRANCH_HALT_SKIP,
>> please use .halt_check = BRANCH_HALT
>>
> If I do that, the clock fails to power on on boot.
> [ 20.324488] ------------[ cut here ]------------
> [ 20.324520] gcc_venus0_core0_vcodec0_clk status stuck at 'off'
> [ 20.324663] WARNING: drivers/clk/qcom/clk-branch.c:88 at
I am hoping the Venus driver has enabled the GDSC before requesting the
clock enable.
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-25 5:51 ` Taniya Das
@ 2026-05-25 9:56 ` Erikas Bitovtas
2026-05-25 10:38 ` Taniya Das
2026-05-25 22:50 ` Bryan O'Donoghue
0 siblings, 2 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-25 9:56 UTC (permalink / raw)
To: Taniya Das, Bryan O'Donoghue, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 5/25/26 8:51 AM, Taniya Das wrote:
>
>
> On 5/22/2026 4:18 PM, Erikas Bitovtas wrote:
>>>>> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>>>>> .halt_reg = 0x4c02c,
>>>>> + .halt_check = BRANCH_HALT_SKIP,
>>> please use .halt_check = BRANCH_HALT
>>>
>> If I do that, the clock fails to power on on boot.
>> [ 20.324488] ------------[ cut here ]------------
>> [ 20.324520] gcc_venus0_core0_vcodec0_clk status stuck at 'off'
>> [ 20.324663] WARNING: drivers/clk/qcom/clk-branch.c:88 at
>
>
> I am hoping the Venus driver has enabled the GDSC before requesting the
> clock enable.
>
It does. From 3/9:
+static int vcodec_domains_enable(struct venus_core *core)
+{
+ const struct venus_resources *res = core->res;
+ struct device *pd_dev;
+ int i = 0, ret;
+
+ if (!res->vcodec_pmdomains)
+ return 0;
+
+ for (; i < res->vcodec_pmdomains_num; i++) {
+ pd_dev = core->pmdomains->pd_devs[i];
+ ret = pm_runtime_resume_and_get(pd_dev);
+ if (ret)
+ goto err;
+
+ ret = dev_pm_genpd_set_hwmode(pd_dev, true);
+ if (ret && ret != -EOPNOTSUPP) {
+ pm_runtime_put_sync(pd_dev);
+ goto err;
+ }
+ }
static void core_put_v1(struct venus_core *core)
@@ -320,11 +410,35 @@ static int core_power_v1(struct venus_core *core,
int on)
{
int ret = 0;
- if (on == POWER_ON)
+ if (on == POWER_ON) {
+ ret = vcodec_domains_enable(core);
+ if (ret)
+ return ret;
+
ret = core_clks_enable(core);
- else
+ if (ret)
+ goto fail_pmdomains;
+
+ if (!core->res->vcodec_pmdomains)
+ return 0;
+
+ ret = vcodec_clks_enable(core, core->vcodec_clks);
+ if (ret)
+ goto fail_core_clks;
+
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-25 9:56 ` Erikas Bitovtas
@ 2026-05-25 10:38 ` Taniya Das
2026-05-25 22:50 ` Bryan O'Donoghue
1 sibling, 0 replies; 22+ messages in thread
From: Taniya Das @ 2026-05-25 10:38 UTC (permalink / raw)
To: Erikas Bitovtas, Bryan O'Donoghue, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 5/25/2026 3:26 PM, Erikas Bitovtas wrote:
>
>
> On 5/25/26 8:51 AM, Taniya Das wrote:
>>
>>
>> On 5/22/2026 4:18 PM, Erikas Bitovtas wrote:
>>>>>> static struct clk_branch gcc_venus0_core0_vcodec0_clk = {
>>>>>> .halt_reg = 0x4c02c,
>>>>>> + .halt_check = BRANCH_HALT_SKIP,
>>>> please use .halt_check = BRANCH_HALT
>>>>
>>> If I do that, the clock fails to power on on boot.
>>> [ 20.324488] ------------[ cut here ]------------
>>> [ 20.324520] gcc_venus0_core0_vcodec0_clk status stuck at 'off'
>>> [ 20.324663] WARNING: drivers/clk/qcom/clk-branch.c:88 at
>>
>>
>> I am hoping the Venus driver has enabled the GDSC before requesting the
>> clock enable.
>>
> It does. From 3/9:
> +static int vcodec_domains_enable(struct venus_core *core)
> +{
> + const struct venus_resources *res = core->res;
> + struct device *pd_dev;
> + int i = 0, ret;
> +
> + if (!res->vcodec_pmdomains)
> + return 0;
> +
> + for (; i < res->vcodec_pmdomains_num; i++) {
> + pd_dev = core->pmdomains->pd_devs[i];
> + ret = pm_runtime_resume_and_get(pd_dev);
> + if (ret)
> + goto err;
> +
> + ret = dev_pm_genpd_set_hwmode(pd_dev, true);
> + if (ret && ret != -EOPNOTSUPP) {
> + pm_runtime_put_sync(pd_dev);
> + goto err;
> + }
> + }
>
> static void core_put_v1(struct venus_core *core)
> @@ -320,11 +410,35 @@ static int core_power_v1(struct venus_core *core,
> int on)
> {
> int ret = 0;
>
> - if (on == POWER_ON)
> + if (on == POWER_ON) {
> + ret = vcodec_domains_enable(core);
> + if (ret)
> + return ret;
> +
> ret = core_clks_enable(core);
> - else
> + if (ret)
> + goto fail_pmdomains;
> +
> + if (!core->res->vcodec_pmdomains)
> + return 0;
> +
> + ret = vcodec_clks_enable(core, core->vcodec_clks);
> + if (ret)
> + goto fail_core_clks;
> +
Please check this sequence is taken care or not
Power-up/Boot-up
1. Enable GDSC
2. Enable clocks
3. Request GDSC to HW control via 'dev_pm_genpd_set_hwmode', true
Power-Down
4. Request GDSC to SW control via 'dev_pm_genpd_set_hwmode', false
5. Disable clocks
6. Disable GDSC
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-25 9:56 ` Erikas Bitovtas
2026-05-25 10:38 ` Taniya Das
@ 2026-05-25 22:50 ` Bryan O'Donoghue
2026-06-01 8:29 ` Taniya Das
1 sibling, 1 reply; 22+ messages in thread
From: Bryan O'Donoghue @ 2026-05-25 22:50 UTC (permalink / raw)
To: Erikas Bitovtas, Taniya Das, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 25/05/2026 10:56, Erikas Bitovtas wrote:
> + for (; i < res->vcodec_pmdomains_num; i++) {
> + pd_dev = core->pmdomains->pd_devs[i];
> + ret = pm_runtime_resume_and_get(pd_dev);
> + if (ret)
> + goto err;
> +
> + ret = dev_pm_genpd_set_hwmode(pd_dev, true);
> + if (ret && ret != -EOPNOTSUPP) {
> + pm_runtime_put_sync(pd_dev);
> + goto err;
> + }
> + }
In Iris we do
- enable_power_domains
- enable_clocks
- set hwmode
Instead of
- enable_power_domains
- set hwmode
- enable clocks
Worth trying that flow instead.
---
bod
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-05-25 22:50 ` Bryan O'Donoghue
@ 2026-06-01 8:29 ` Taniya Das
2026-06-01 8:48 ` Erikas Bitovtas
0 siblings, 1 reply; 22+ messages in thread
From: Taniya Das @ 2026-06-01 8:29 UTC (permalink / raw)
To: Bryan O'Donoghue, Erikas Bitovtas, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 5/26/2026 4:20 AM, Bryan O'Donoghue wrote:
> On 25/05/2026 10:56, Erikas Bitovtas wrote:
>> + for (; i < res->vcodec_pmdomains_num; i++) {
>> + pd_dev = core->pmdomains->pd_devs[i];
>> + ret = pm_runtime_resume_and_get(pd_dev);
>> + if (ret)
>> + goto err;
>> +
>> + ret = dev_pm_genpd_set_hwmode(pd_dev, true);
>> + if (ret && ret != -EOPNOTSUPP) {
>> + pm_runtime_put_sync(pd_dev);
>> + goto err;
>> + }
>> + }
>
> In Iris we do
>
> - enable_power_domains
> - enable_clocks
> - set hwmode
>
This sequence will always ensure clock can be polled as the GDSC is
still in SW mode.
> Instead of
>
> - enable_power_domains
> - set hwmode
> - enable clocks
>
This sequence will require the clock to have SKIP or DELAY as the GDSC
is moved to HW mode and it is not guaranteed to match the SW expectation.
--
Thanks,
Taniya Das
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled
2026-06-01 8:29 ` Taniya Das
@ 2026-06-01 8:48 ` Erikas Bitovtas
0 siblings, 0 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-06-01 8:48 UTC (permalink / raw)
To: Taniya Das, Bryan O'Donoghue, Vikash Garodia,
Dikshita Agarwal, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, André Apitzsch,
Bjorn Andersson, Konrad Dybcio, Michael Turquette, Stephen Boyd,
Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 6/1/26 11:29 AM, Taniya Das wrote:
>
>
> On 5/26/2026 4:20 AM, Bryan O'Donoghue wrote:
>> On 25/05/2026 10:56, Erikas Bitovtas wrote:
>>> + for (; i < res->vcodec_pmdomains_num; i++) {
>>> + pd_dev = core->pmdomains->pd_devs[i];
>>> + ret = pm_runtime_resume_and_get(pd_dev);
>>> + if (ret)
>>> + goto err;
>>> +
>>> + ret = dev_pm_genpd_set_hwmode(pd_dev, true);
>>> + if (ret && ret != -EOPNOTSUPP) {
>>> + pm_runtime_put_sync(pd_dev);
>>> + goto err;
>>> + }
>>> + }
>>
>> In Iris we do
>>
>> - enable_power_domains
>> - enable_clocks
>> - set hwmode
>>
>
> This sequence will always ensure clock can be polled as the GDSC is
> still in SW mode.
>
>
>> Instead of
>>
>> - enable_power_domains
>> - set hwmode
>> - enable clocks
>>
>
> This sequence will require the clock to have SKIP or DELAY as the GDSC
> is moved to HW mode and it is not guaranteed to match the SW expectation.
>
>
Thank you for the explanation. I fixed the sequence in v9 - clocks are
now enabled before switching to HW mode, not after.
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v8 3/9] media: qcom: venus: add power domain enable logic for Venus cores
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 1/9] media: dt-bindings: venus: Add qcom,msm8939 schema Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism Erikas Bitovtas
` (4 subsequent siblings)
7 siblings, 0 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas,
Bryan O'Donoghue
Attach power domains for vdec and venc cores and power them up if a vdec
or venc session is started.
Vcodec clocks are added and enabled to the core Venus device both for
vcodec0 and vcodec1. To ensure they are added only once, introduce a new
property "vcodec_clks", which is an array of clocks which are enabled
both during decode and encode and is retrieved from the device tree only
once.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
drivers/media/platform/qcom/venus/core.h | 3 +
drivers/media/platform/qcom/venus/pm_helpers.c | 124 ++++++++++++++++++++++++-
2 files changed, 122 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
index 03804c30808e..c1603eebd757 100644
--- a/drivers/media/platform/qcom/venus/core.h
+++ b/drivers/media/platform/qcom/venus/core.h
@@ -79,6 +79,7 @@ struct venus_resources {
const struct hfi_ubwc_config *ubwc_conf;
const char * const clks[VIDC_CLKS_NUM_MAX];
unsigned int clks_num;
+ const char * const vcodec_clks[VIDC_VCODEC_CLKS_NUM_MAX];
const char * const vcodec0_clks[VIDC_VCODEC_CLKS_NUM_MAX];
const char * const vcodec1_clks[VIDC_VCODEC_CLKS_NUM_MAX];
unsigned int vcodec_clks_num;
@@ -143,6 +144,7 @@ struct venus_format {
* @aon_base: AON base address
* @irq: Venus irq
* @clks: an array of struct clk pointers
+ * @vcodec_clks: an array of vcodec struct clk pointers
* @vcodec0_clks: an array of vcodec0 struct clk pointers
* @vcodec1_clks: an array of vcodec1 struct clk pointers
* @video_path: an interconnect handle to video to/from memory path
@@ -197,6 +199,7 @@ struct venus_core {
void __iomem *aon_base;
int irq;
struct clk *clks[VIDC_CLKS_NUM_MAX];
+ struct clk *vcodec_clks[VIDC_VCODEC_CLKS_NUM_MAX];
struct clk *vcodec0_clks[VIDC_VCODEC_CLKS_NUM_MAX];
struct clk *vcodec1_clks[VIDC_VCODEC_CLKS_NUM_MAX];
struct icc_path *video_path;
diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
index 14a4e8311a64..123b4661873a 100644
--- a/drivers/media/platform/qcom/venus/pm_helpers.c
+++ b/drivers/media/platform/qcom/venus/pm_helpers.c
@@ -89,12 +89,23 @@ static void core_clks_disable(struct venus_core *core)
static int core_clks_set_rate(struct venus_core *core, unsigned long freq)
{
- int ret;
+ const struct venus_resources *res = core->res;
+ int ret, i;
ret = dev_pm_opp_set_rate(core->dev, freq);
if (ret)
return ret;
+ if (!res->vcodec_clks_num)
+ goto set_rates;
+
+ for (i = 0; i < res->vcodec_clks_num; i++) {
+ ret = clk_set_rate(core->vcodec_clks[i], freq);
+ if (ret)
+ return ret;
+ }
+
+set_rates:
ret = clk_set_rate(core->vcodec0_clks[0], freq);
if (ret)
return ret;
@@ -297,10 +308,33 @@ static int load_scale_v1(struct venus_inst *inst)
return ret;
}
+static int vcodec_domains_get_v1(struct venus_core *core)
+{
+ struct device *dev = core->dev;
+ const struct venus_resources *res = core->res;
+ const struct dev_pm_domain_attach_data vcodec_data = {
+ .pd_names = res->vcodec_pmdomains,
+ .num_pd_names = res->vcodec_pmdomains_num,
+ .pd_flags = PD_FLAG_NO_DEV_LINK,
+ };
+
+ if (!res->vcodec_pmdomains)
+ return 0;
+
+ return devm_pm_domain_attach_list(dev, &vcodec_data,
+ &core->pmdomains);
+}
+
static int core_get_v1(struct venus_core *core)
{
+ const struct venus_resources *res = core->res;
+ struct device *dev = core->dev;
int ret;
+ ret = vcodec_domains_get_v1(core);
+ if (ret < 0)
+ return ret;
+
ret = core_clks_get(core);
if (ret)
return ret;
@@ -309,7 +343,63 @@ static int core_get_v1(struct venus_core *core)
if (ret)
return ret;
+ if (!res->vcodec_pmdomains)
+ return 0;
+
+ ret = vcodec_clks_get(core, dev, core->vcodec_clks,
+ res->vcodec_clks);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static int vcodec_domains_enable(struct venus_core *core)
+{
+ const struct venus_resources *res = core->res;
+ struct device *pd_dev;
+ int i = 0, ret;
+
+ if (!res->vcodec_pmdomains)
+ return 0;
+
+ for (; i < res->vcodec_pmdomains_num; i++) {
+ pd_dev = core->pmdomains->pd_devs[i];
+ ret = pm_runtime_resume_and_get(pd_dev);
+ if (ret)
+ goto err;
+
+ ret = dev_pm_genpd_set_hwmode(pd_dev, true);
+ if (ret && ret != -EOPNOTSUPP) {
+ pm_runtime_put_sync(pd_dev);
+ goto err;
+ }
+ }
+
return 0;
+err:
+ while (i--) {
+ pd_dev = core->pmdomains->pd_devs[i];
+ dev_pm_genpd_set_hwmode(pd_dev, false);
+ pm_runtime_put_sync(pd_dev);
+ }
+ return ret;
+}
+
+static void vcodec_domains_disable(struct venus_core *core)
+{
+ const struct venus_resources *res = core->res;
+ struct device *pd_dev;
+ int i = res->vcodec_pmdomains_num;
+
+ if (!res->vcodec_pmdomains)
+ return;
+
+ while (i--) {
+ pd_dev = core->pmdomains->pd_devs[i];
+ dev_pm_genpd_set_hwmode(pd_dev, false);
+ pm_runtime_put_sync(pd_dev);
+ }
}
static void core_put_v1(struct venus_core *core)
@@ -320,11 +410,35 @@ static int core_power_v1(struct venus_core *core, int on)
{
int ret = 0;
- if (on == POWER_ON)
+ if (on == POWER_ON) {
+ ret = vcodec_domains_enable(core);
+ if (ret)
+ return ret;
+
ret = core_clks_enable(core);
- else
+ if (ret)
+ goto fail_pmdomains;
+
+ if (!core->res->vcodec_pmdomains)
+ return 0;
+
+ ret = vcodec_clks_enable(core, core->vcodec_clks);
+ if (ret)
+ goto fail_core_clks;
+
+ } else {
+ if (core->res->vcodec_pmdomains)
+ vcodec_clks_disable(core, core->vcodec_clks);
core_clks_disable(core);
+ vcodec_domains_disable(core);
+ }
+
+ return 0;
+fail_core_clks:
+ core_clks_disable(core);
+fail_pmdomains:
+ vcodec_domains_disable(core);
return ret;
}
@@ -875,7 +989,7 @@ static int venc_power_v4(struct device *dev, int on)
return ret;
}
-static int vcodec_domains_get(struct venus_core *core)
+static int vcodec_domains_get_v4(struct venus_core *core)
{
int ret;
struct device *dev = core->dev;
@@ -999,7 +1113,7 @@ static int core_get_v4(struct venus_core *core)
if (ret)
return ret;
- ret = vcodec_domains_get(core);
+ ret = vcodec_domains_get_v4(core);
if (ret)
return ret;
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
` (2 preceding siblings ...)
2026-05-19 15:10 ` [PATCH v8 3/9] media: qcom: venus: add power domain enable logic for Venus cores Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-20 8:38 ` Bryan O'Donoghue
2026-05-19 15:10 ` [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new " Erikas Bitovtas
` (3 subsequent siblings)
7 siblings, 1 reply; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas
Add decode and encode blacklist properties to allow disabling different
codecs per Venus device, instead of doing it per HFI version.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
drivers/media/platform/qcom/venus/core.h | 2 ++
drivers/media/platform/qcom/venus/hfi_parser.c | 10 +++++-----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
index c1603eebd757..46705a666776 100644
--- a/drivers/media/platform/qcom/venus/core.h
+++ b/drivers/media/platform/qcom/venus/core.h
@@ -88,6 +88,8 @@ struct venus_resources {
const char **opp_pmdomain;
unsigned int opp_pmdomain_num;
unsigned int vcodec_num;
+ const u32 dec_codec_blacklist;
+ const u32 enc_codec_blacklist;
const char * const resets[VIDC_RESETS_NUM_MAX];
unsigned int resets_num;
enum hfi_version hfi_version;
diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c
index 92765f9c8873..8e762cf77968 100644
--- a/drivers/media/platform/qcom/venus/hfi_parser.c
+++ b/drivers/media/platform/qcom/venus/hfi_parser.c
@@ -206,11 +206,11 @@ static int parse_codecs(struct venus_core *core, void *data)
core->dec_codecs = codecs->dec_codecs;
core->enc_codecs = codecs->enc_codecs;
- if (IS_V1(core)) {
- core->dec_codecs &= ~HFI_VIDEO_CODEC_HEVC;
- core->dec_codecs &= ~HFI_VIDEO_CODEC_SPARK;
- core->enc_codecs &= ~HFI_VIDEO_CODEC_HEVC;
- }
+ if (core->res->dec_codec_blacklist)
+ core->dec_codecs &= ~core->res->dec_codec_blacklist;
+
+ if (core->res->enc_codec_blacklist)
+ core->enc_codecs &= ~core->res->enc_codec_blacklist;
return sizeof(*codecs);
}
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism
2026-05-19 15:10 ` [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism Erikas Bitovtas
@ 2026-05-20 8:38 ` Bryan O'Donoghue
0 siblings, 0 replies; 22+ messages in thread
From: Bryan O'Donoghue @ 2026-05-20 8:38 UTC (permalink / raw)
To: Erikas Bitovtas, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 19/05/2026 16:10, Erikas Bitovtas wrote:
> Add decode and encode blacklist properties to allow disabling different
> codecs per Venus device, instead of doing it per HFI version.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> drivers/media/platform/qcom/venus/core.h | 2 ++
> drivers/media/platform/qcom/venus/hfi_parser.c | 10 +++++-----
> 2 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platform/qcom/venus/core.h
> index c1603eebd757..46705a666776 100644
> --- a/drivers/media/platform/qcom/venus/core.h
> +++ b/drivers/media/platform/qcom/venus/core.h
> @@ -88,6 +88,8 @@ struct venus_resources {
> const char **opp_pmdomain;
> unsigned int opp_pmdomain_num;
> unsigned int vcodec_num;
> + const u32 dec_codec_blacklist;
> + const u32 enc_codec_blacklist;
> const char * const resets[VIDC_RESETS_NUM_MAX];
> unsigned int resets_num;
> enum hfi_version hfi_version;
> diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c
> index 92765f9c8873..8e762cf77968 100644
> --- a/drivers/media/platform/qcom/venus/hfi_parser.c
> +++ b/drivers/media/platform/qcom/venus/hfi_parser.c
> @@ -206,11 +206,11 @@ static int parse_codecs(struct venus_core *core, void *data)
> core->dec_codecs = codecs->dec_codecs;
> core->enc_codecs = codecs->enc_codecs;
>
> - if (IS_V1(core)) {
> - core->dec_codecs &= ~HFI_VIDEO_CODEC_HEVC;
> - core->dec_codecs &= ~HFI_VIDEO_CODEC_SPARK;
> - core->enc_codecs &= ~HFI_VIDEO_CODEC_HEVC;
> - }
> + if (core->res->dec_codec_blacklist)
> + core->dec_codecs &= ~core->res->dec_codec_blacklist;
> +
> + if (core->res->enc_codec_blacklist)
> + core->enc_codecs &= ~core->res->enc_codec_blacklist;
>
> return sizeof(*codecs);
> }
>
> --
> 2.54.0
>
The ordering of the patches is wrong here 5/9 should come before 4/9
actually, that wouldn't bisect.
If it was just ordering, I'd fix this for you on application but, 4/9
and 5/9 should be individually bisectable so rather than change the
ordering just add blacklist and whitelist data for 8916 here.
Then 5/9 can be about switching off the old way. For 8916 the series
should be opaque.
Assuming you do that please add:
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new blacklist mechanism
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
` (3 preceding siblings ...)
2026-05-19 15:10 ` [PATCH v8 4/9] media: qcom: venus: add codec blacklist mechanism Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-20 8:39 ` Bryan O'Donoghue
2026-05-20 12:45 ` Dmitry Baryshkov
2026-05-19 15:10 ` [PATCH v8 6/9] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
` (2 subsequent siblings)
7 siblings, 2 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas
Blacklist unsupported codecs for MSM8916 reported by firmware to prevent
them from loading.
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
drivers/media/platform/qcom/venus/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index a87e8afb23df..3baa6bb4968f 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -684,6 +684,8 @@ static const struct venus_resources msm8916_res = {
.vmem_addr = 0,
.dma_mask = 0xddc00000 - 1,
.fwname = "qcom/venus-1.8/venus.mbn",
+ .dec_codec_blacklist = HFI_VIDEO_CODEC_HEVC | HFI_VIDEO_CODEC_SPARK,
+ .enc_codec_blacklist = HFI_VIDEO_CODEC_HEVC,
.dec_nodename = "video-decoder",
.enc_nodename = "video-encoder",
};
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* Re: [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new blacklist mechanism
2026-05-19 15:10 ` [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new " Erikas Bitovtas
@ 2026-05-20 8:39 ` Bryan O'Donoghue
2026-05-20 12:45 ` Dmitry Baryshkov
1 sibling, 0 replies; 22+ messages in thread
From: Bryan O'Donoghue @ 2026-05-20 8:39 UTC (permalink / raw)
To: Erikas Bitovtas, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On 19/05/2026 16:10, Erikas Bitovtas wrote:
> Blacklist unsupported codecs for MSM8916 reported by firmware to prevent
> them from loading.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> drivers/media/platform/qcom/venus/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index a87e8afb23df..3baa6bb4968f 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -684,6 +684,8 @@ static const struct venus_resources msm8916_res = {
> .vmem_addr = 0,
> .dma_mask = 0xddc00000 - 1,
> .fwname = "qcom/venus-1.8/venus.mbn",
> + .dec_codec_blacklist = HFI_VIDEO_CODEC_HEVC | HFI_VIDEO_CODEC_SPARK,
> + .enc_codec_blacklist = HFI_VIDEO_CODEC_HEVC,
> .dec_nodename = "video-decoder",
> .enc_nodename = "video-encoder",
> };
>
> --
> 2.54.0
>
Actually just squash into 4/9.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
bod
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new blacklist mechanism
2026-05-19 15:10 ` [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new " Erikas Bitovtas
2026-05-20 8:39 ` Bryan O'Donoghue
@ 2026-05-20 12:45 ` Dmitry Baryshkov
1 sibling, 0 replies; 22+ messages in thread
From: Dmitry Baryshkov @ 2026-05-20 12:45 UTC (permalink / raw)
To: Erikas Bitovtas
Cc: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney, linux-media,
linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel
On Tue, May 19, 2026 at 06:10:50PM +0300, Erikas Bitovtas wrote:
> Blacklist unsupported codecs for MSM8916 reported by firmware to prevent
> them from loading.
This should be squashed in the previous commit. Otherwise the codec list
will be broken between these two commits.
>
> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
> ---
> drivers/media/platform/qcom/venus/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index a87e8afb23df..3baa6bb4968f 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -684,6 +684,8 @@ static const struct venus_resources msm8916_res = {
> .vmem_addr = 0,
> .dma_mask = 0xddc00000 - 1,
> .fwname = "qcom/venus-1.8/venus.mbn",
> + .dec_codec_blacklist = HFI_VIDEO_CODEC_HEVC | HFI_VIDEO_CODEC_SPARK,
> + .enc_codec_blacklist = HFI_VIDEO_CODEC_HEVC,
> .dec_nodename = "video-decoder",
> .enc_nodename = "video-encoder",
> };
>
> --
> 2.54.0
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v8 6/9] media: qcom: venus: Add msm8939 resource struct
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
` (4 preceding siblings ...)
2026-05-19 15:10 ` [PATCH v8 5/9] media: qcom: venus: migrate MSM8916 to new " Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 7/9] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 8/9] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas
7 siblings, 0 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas,
Dmitry Baryshkov
From: André Apitzsch <git@apitzsch.eu>
Add msm8939 configuration data and related compatible.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
drivers/media/platform/qcom/venus/core.c | 40 ++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
index 3baa6bb4968f..ef9081d5335d 100644
--- a/drivers/media/platform/qcom/venus/core.c
+++ b/drivers/media/platform/qcom/venus/core.c
@@ -690,6 +690,45 @@ static const struct venus_resources msm8916_res = {
.enc_nodename = "video-encoder",
};
+static const struct freq_tbl msm8939_freq_table[] = {
+ { 489600, 266670000 }, /* 1080p @ 60 */
+ { 244800, 133330000 }, /* 1080p @ 30 */
+ { 220800, 133330000 }, /* 720p @ 60 */
+ { 108000, 133330000 }, /* 720p @ 30 */
+ { 72000, 133330000 }, /* VGA @ 60 */
+ { 36000, 133330000 }, /* VGA @ 30 */
+};
+
+static const struct reg_val msm8939_reg_preset[] = {
+ { 0xe0020, 0x0aaaaaaa },
+ { 0xe0024, 0x0aaaaaaa },
+ { 0x80124, 0x00000003 },
+};
+
+static const struct venus_resources msm8939_res = {
+ .freq_tbl = msm8939_freq_table,
+ .freq_tbl_size = ARRAY_SIZE(msm8939_freq_table),
+ .reg_tbl = msm8939_reg_preset,
+ .reg_tbl_size = ARRAY_SIZE(msm8939_reg_preset),
+ .clks = { "core", "iface", "bus", },
+ .clks_num = 3,
+ .vcodec_clks = { "vcodec0_core", "vcodec1_core" },
+ .vcodec_clks_num = 2,
+ .vcodec_pmdomains = (const char *[]) { "venus", "vcodec0", "vcodec1" },
+ .vcodec_pmdomains_num = 3,
+ .max_load = 489600, /* 1080p@30 + 1080p@30 */
+ .hfi_version = HFI_VERSION_1XX,
+ .vmem_id = VIDC_RESOURCE_NONE,
+ .vmem_size = 0,
+ .vmem_addr = 0,
+ .dma_mask = 0xddc00000 - 1,
+ .fwname = "qcom/venus-1.8/venus.mbn",
+ .dec_codec_blacklist = HFI_VIDEO_CODEC_SPARK,
+ .enc_codec_blacklist = HFI_VIDEO_CODEC_HEVC,
+ .dec_nodename = "video-decoder",
+ .enc_nodename = "video-encoder",
+};
+
static const struct freq_tbl msm8996_freq_table[] = {
{ 1944000, 520000000 }, /* 4k UHD @ 60 (decode only) */
{ 972000, 520000000 }, /* 4k UHD @ 30 */
@@ -1130,6 +1169,7 @@ static const struct venus_resources qcm2290_res = {
static const struct of_device_id venus_dt_match[] = {
{ .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
+ { .compatible = "qcom,msm8939-venus", .data = &msm8939_res, },
{ .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
{ .compatible = "qcom,msm8998-venus", .data = &msm8998_res, },
{ .compatible = "qcom,qcm2290-venus", .data = &qcm2290_res, },
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v8 7/9] arm64: dts: qcom: msm8939: Add venus node
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
` (5 preceding siblings ...)
2026-05-19 15:10 ` [PATCH v8 6/9] media: qcom: venus: Add msm8939 resource struct Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
2026-05-19 15:10 ` [PATCH v8 8/9] arm64: dts: qcom: msm8939-longcheer-l9100: Enable " Erikas Bitovtas
7 siblings, 0 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas
From: André Apitzsch <git@apitzsch.eu>
Add DT entries for the msm8939 venus encoder/decoder.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
---
arch/arm64/boot/dts/qcom/msm8939.dtsi | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi
index d4d7b0c9206c..71e22584a46b 100644
--- a/arch/arm64/boot/dts/qcom/msm8939.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi
@@ -1627,6 +1627,29 @@ opp-19200000 {
};
};
+ venus: video-codec@1d00000 {
+ compatible = "qcom,msm8939-venus";
+ reg = <0x01d00000 0xff000>;
+ interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>,
+ <&gcc GCC_VENUS0_AHB_CLK>,
+ <&gcc GCC_VENUS0_AXI_CLK>,
+ <&gcc GCC_VENUS0_CORE0_VCODEC0_CLK>,
+ <&gcc GCC_VENUS0_CORE1_VCODEC0_CLK>;
+ clock-names = "core",
+ "iface",
+ "bus",
+ "vcodec0_core",
+ "vcodec1_core";
+ power-domains = <&gcc VENUS_GDSC>,
+ <&gcc VENUS_CORE0_GDSC>,
+ <&gcc VENUS_CORE1_GDSC>;
+ power-domain-names = "venus", "vcodec0", "vcodec1";
+ iommus = <&apps_iommu 5>;
+ memory-region = <&venus_mem>;
+ status = "disabled";
+ };
+
apps_iommu: iommu@1ef0000 {
compatible = "qcom,msm8916-iommu", "qcom,msm-iommu-v1";
reg = <0x01ef0000 0x3000>;
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread* [PATCH v8 8/9] arm64: dts: qcom: msm8939-longcheer-l9100: Enable venus node
2026-05-19 15:10 [PATCH v8 0/9] media: qcom: venus: add MSM8939 support Erikas Bitovtas
` (6 preceding siblings ...)
2026-05-19 15:10 ` [PATCH v8 7/9] arm64: dts: qcom: msm8939: Add venus node Erikas Bitovtas
@ 2026-05-19 15:10 ` Erikas Bitovtas
7 siblings, 0 replies; 22+ messages in thread
From: Erikas Bitovtas @ 2026-05-19 15:10 UTC (permalink / raw)
To: Bryan O'Donoghue, Vikash Garodia, Dikshita Agarwal,
Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, André Apitzsch, Bjorn Andersson, Konrad Dybcio,
Michael Turquette, Stephen Boyd, Brian Masney
Cc: linux-media, linux-arm-msm, devicetree, linux-kernel, linux-clk,
~postmarketos/upstreaming, phone-devel, Erikas Bitovtas
From: André Apitzsch <git@apitzsch.eu>
Enable the venus node so that the video encoder/decoder will start
working.
Default paths for firmware work on BQ Aquaris M5, which means
firmware-name property can be left out.
Signed-off-by: André Apitzsch <git@apitzsch.eu>
Reviewed-by: Bryan O'Donoghue <bod@kernel.org>
---
arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
index 13422a19c26a..48514c3df718 100644
--- a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
+++ b/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
@@ -314,6 +314,14 @@ &usb_hs_phy {
extcon = <&usb_id>;
};
+&venus {
+ status = "okay";
+};
+
+&venus_mem {
+ status = "okay";
+};
+
&wcnss {
status = "okay";
};
--
2.54.0
^ permalink raw reply related [flat|nested] 22+ messages in thread