Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Biju <biju.das.au@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
Date: Mon, 8 Jun 2026 12:21:33 +0200	[thread overview]
Message-ID: <d8cf5925-9c4e-4417-8fee-1d24c4cd303d@kernel.org> (raw)
In-Reply-To: <20260608-alluring-remarkable-echidna-d107ea@quoll>

On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>
>> Add a conditional schema rule to the syscon bindings that requires the
>> ranges property when the compatible string contains
>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control block
>> on the RZ/G3L SoC correctly declares its address translation, as the
>> device has child nodes that need a valid ranges mapping to be described
>> in the device tree.
>>
>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 9c81010d5a74..cbf83a06ae25 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -269,6 +269,8 @@ properties:
>>    resets:
>>      maxItems: 1
>>  
>> +  ranges: true
> 
> There are no children allowed, so ranges property is wrong.
> 
> You are changing binding which DOES NOT allow simple-mfd or any other
> children. Ranges is not a problem here.


And if you tested it on your DTS, you would see this does not work...

Best regards,
Krzysztof

  reply	other threads:[~2026-06-08 10:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 13:13 [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn Biju
2026-06-02 13:22 ` sashiko-bot
2026-06-08 10:20 ` Krzysztof Kozlowski
2026-06-08 10:21   ` Krzysztof Kozlowski [this message]
2026-06-08 10:26     ` Biju Das
2026-06-08 11:11       ` Krzysztof Kozlowski
2026-06-08 11:22         ` Biju Das
2026-06-08 11:46           ` Krzysztof Kozlowski
2026-06-08 11:50             ` Krzysztof Kozlowski
2026-06-08 11:51             ` Biju Das
2026-06-08 11:55               ` Krzysztof Kozlowski
2026-06-08 11:57                 ` Biju Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8cf5925-9c4e-4417-8fee-1d24c4cd303d@kernel.org \
    --to=krzk@kernel.org \
    --cc=biju.das.au@gmail.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox