From: Thomas Huth <thuth@redhat.com>
To: Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@kernel.org>,
linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file
Date: Tue, 22 Sep 2026 08:23:03 +0200 [thread overview]
Message-ID: <dd31022e-6211-47f8-b123-edb589dd0471@redhat.com> (raw)
In-Reply-To: <a37baafd-56dc-4733-bd7c-c92a8b8c1474@redhat.com>
On 13/08/2026 09.40, Thomas Huth wrote:
> On 19/06/2026 18.02, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> While the GCC and Clang compilers already define __ASSEMBLER__
>> automatically when compiling assembly code, __ASSEMBLY__ is a
>> macro that only gets defined by the Makefiles in the kernel.
>> This can be very confusing when switching between userspace
>> and kernelspace coding, or when dealing with uapi headers that
>> rather should use __ASSEMBLER__ instead. So let's standardize now
>> on the __ASSEMBLER__ macro that is provided by the compilers.
>>
>> This is a completely mechanical patch (done with a simple "sed -i"
>> statement).
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>> Note: This patch has been split from an earlier bigger patch of
>> mine to ease reviewing.
>>
>> include/linux/of_fdt.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
>> index 51dadbaa3d63a..72b452e388eeb 100644
>> --- a/include/linux/of_fdt.h
>> +++ b/include/linux/of_fdt.h
>> @@ -16,7 +16,7 @@
>> /* Definitions used by the flattened device tree */
>> #define OF_DT_HEADER 0xd00dfeed /* marker */
>> -#ifndef __ASSEMBLY__
>> +#ifndef __ASSEMBLER__
>>
>> #if defined(CONFIG_OF_FLATTREE)
>>
>> @@ -103,5 +103,5 @@ static inline void unflatten_device_tree(void) {}
>> static inline void unflatten_and_copy_device_tree(void) {}
>> #endif /* CONFIG_OF_EARLY_FLATTREE */
>>
>> -#endif /* __ASSEMBLY__ */
>> +#endif /* __ASSEMBLER__ */
>> #endif /* _LINUX_OF_FDT_H */
>
> Friendly ping!
Ping again!
Rob, Saravana, it's not a big patch, could you please pick it up? (or tell
me if you don't like it, then I'll stop annoying you ;-))
Thanks,
Thomas
prev parent reply other threads:[~2026-09-22 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260619160234.69568-1-thuth@redhat.com>
2026-08-13 7:40 ` [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file Thomas Huth
2026-09-22 6:23 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd31022e-6211-47f8-b123-edb589dd0471@redhat.com \
--to=thuth@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox