Re: [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file

Re: [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file

[Thomas Huth]

On 19/06/2026 18.02, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> While the GCC and Clang compilers already define __ASSEMBLER__
> automatically when compiling assembly code, __ASSEMBLY__ is a
> macro that only gets defined by the Makefiles in the kernel.
> This can be very confusing when switching between userspace
> and kernelspace coding, or when dealing with uapi headers that
> rather should use __ASSEMBLER__ instead. So let's standardize now
> on the __ASSEMBLER__ macro that is provided by the compilers.
> 
> This is a completely mechanical patch (done with a simple "sed -i"
> statement).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   Note: This patch has been split from an earlier bigger patch of
>   mine to ease reviewing.
> 
>   include/linux/of_fdt.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
> index 51dadbaa3d63a..72b452e388eeb 100644
> --- a/include/linux/of_fdt.h
> +++ b/include/linux/of_fdt.h
> @@ -16,7 +16,7 @@
>  /* Definitions used by the flattened device tree */
>  #define OF_DT_HEADER		0xd00dfeed	/* marker */
>   
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>  
>  #if defined(CONFIG_OF_FLATTREE)
>  
> @@ -103,5 +103,5 @@ static inline void unflatten_device_tree(void) {}
>  static inline void unflatten_and_copy_device_tree(void) {}
>  #endif /* CONFIG_OF_EARLY_FLATTREE */
>  
> -#endif /* __ASSEMBLY__ */
> +#endif /* __ASSEMBLER__ */
>  #endif /* _LINUX_OF_FDT_H */

Friendly ping!

Could anybody please pick this up? Thanks!

  Thomas

Re: [PATCH] of: fdt: Replace __ASSEMBLY__ with __ASSEMBLER__ in of_fdt.h header file

[Thomas Huth]

On 13/08/2026 09.40, Thomas Huth wrote:
> On 19/06/2026 18.02, Thomas Huth wrote:
>> From: Thomas Huth <thuth@redhat.com>
>>
>> While the GCC and Clang compilers already define __ASSEMBLER__
>> automatically when compiling assembly code, __ASSEMBLY__ is a
>> macro that only gets defined by the Makefiles in the kernel.
>> This can be very confusing when switching between userspace
>> and kernelspace coding, or when dealing with uapi headers that
>> rather should use __ASSEMBLER__ instead. So let's standardize now
>> on the __ASSEMBLER__ macro that is provided by the compilers.
>>
>> This is a completely mechanical patch (done with a simple "sed -i"
>> statement).
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>   Note: This patch has been split from an earlier bigger patch of
>>   mine to ease reviewing.
>>
>>   include/linux/of_fdt.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/of_fdt.h b/include/linux/of_fdt.h
>> index 51dadbaa3d63a..72b452e388eeb 100644
>> --- a/include/linux/of_fdt.h
>> +++ b/include/linux/of_fdt.h
>> @@ -16,7 +16,7 @@
>>  /* Definitions used by the flattened device tree */
>>  #define OF_DT_HEADER        0xd00dfeed    /* marker */
>> -#ifndef __ASSEMBLY__
>> +#ifndef __ASSEMBLER__
>>
>>  #if defined(CONFIG_OF_FLATTREE)
>>
>> @@ -103,5 +103,5 @@ static inline void unflatten_device_tree(void) {}
>>  static inline void unflatten_and_copy_device_tree(void) {}
>>  #endif /* CONFIG_OF_EARLY_FLATTREE */
>>
>> -#endif /* __ASSEMBLY__ */
>> +#endif /* __ASSEMBLER__ */
>>  #endif /* _LINUX_OF_FDT_H */
> 
> Friendly ping!
Ping again!

Rob, Saravana, it's not a big patch, could you please pick it up? (or tell 
me if you don't like it, then I'll stop annoying you ;-))

  Thanks,
   Thomas