Devicetree
 help / color / mirror / Atom feed
From: Andrew Davis <afd@ti.com>
To: Markus Schneider-Pargmann <msp@baylibre.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, "Rob Herring" <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	Nathan Chancellor <nathan@kernel.org>,
	"Nick Desaulniers" <nick.desaulniers+lkml@gmail.com>,
	Bill Wendling <morbo@google.com>,
	Justin Stitt <justinstitt@google.com>, Judith Mendez <jm@ti.com>,
	Daniel Schultz <d.schultz@phytec.de>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Paresh Bhagat <p-bhagat@ti.com>, Bryan Brattlof <bb@ti.com>,
	Jai Luthra <jai.luthra@ideasonboard.com>,
	Devarsh Thakkar <devarsht@ti.com>,
	Beleswar Padhi <b-padhi@ti.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Stefano Radaelli <stefano.radaelli21@gmail.com>
Cc: Vishal Mahaveer <vishalm@ti.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Sebin Francis <sebin.francis@ti.com>,
	Kendall Willis <k-willis@ti.com>, Akashdeep Kaur <a-kaur@ti.com>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<llvm@lists.linux.dev>, Hari Nagalla <hnagalla@ti.com>
Subject: Re: [PATCH v7 07/11] arm64: dts: ti: k3-am62a-ti-ipc-firmware: Move wkup reserved memory
Date: Wed, 26 Aug 2026 16:59:33 -0500	[thread overview]
Message-ID: <de6f8a26-cec7-4618-9a71-b55dcddb0dc4@ti.com> (raw)
In-Reply-To: <DKY17OVPN49B.3U7OKB7NIMLF2@baylibre.com>

On 8/25/26 7:43 AM, Markus Schneider-Pargmann wrote:
> Hi Andrew,
> 
> On Thu Jul 9, 2026 at 9:33 PM CEST, Andrew Davis wrote:
>> On 7/1/26 7:39 AM, Markus Schneider-Pargmann (TI) wrote:
>>> Move the reserved memory regions used for wkup_r5fss0_core0 to the
>>> k3-am62a-ti-ipc-firmware.dtsi. These are all the same for the other
>>> boards as well, so we can combine them here similar to what is already
>>> done for the mcu_r5fss0_core0 memory regions.
>>
>> The reason we left this region here in the base DTSI is this region
>> is for the DM firmware and is required for the SoC to function.
>> The other firmware regions are all optional.
> 
> I left this in the base dts before and Nishanth pointed out that it
> should be in the ipc-firmware.dtsi so it only needs to be changed in one
> place:
> 
>    That was the entire purpose of splitting ipc-firmware.dtsi out -
>    if the default firmware carveouts have changed, do the change in
>    ipc-firmware.dtsi. That way some other firmware people will have could
>    potentially have their own dtsi files and handle things appropriately
>    there, even if they are using the same evm OR if they use the exact
>    ipc-firmware on different boards, that will appropriately introduce
>    the change there as well. BUT, do check first.
> 
> https://lore.kernel.org/r/20260507155710.5zch4ghhzrj7hnlh@immovably
> 
> Maybe I am misunderstanding what you are suggesting. Also note that the
> memory-region list in wkup_r5fss0_core0 which references the memory
> regions defined in the base dts were always in the ipc-firmware.dtsi.
> 
> Could you please help me understand how this is modeled so I can update
> the patches appropriately?
> 

I think the issue with your v3 was that you updated the wkup_r5fss0_core0
node outside of the ipc-firmware.dtsi file where it was defined.

The core idea behind ipc-firmware.dtsi is it should be optional. If for
instance if I have a different set of remote firmware then I only need
to modify that .dtsi file. If I don't want any remote firmware and my
bootloader starts none of the remote cores, then I should be able to
simply not apply that .dtsi file and not lose any memory to unneeded
carveouts.

Now the wkup_r5fss0_core0 is a little different, that core runs the
DM firmware, that firmware is mandatory to even boot the system, it is
not optional. If I try to boot Linux without marking its memory region
as reserved then Linux will write over it can things will break. So,
its carveout (and only its carveouts) remains in the base dts.

Do as you did in v4, but update the wkup_r5fss0_core0 node in
ipc-firmware.dtsi, not only for k3-am62a7-sk.dts. Yes this means
you will need to make this change for all AM62A based boards, but
that will be the correct thing to do as all boards will be using
the same DM firmware anyway.

Andrew

> Thanks!
> 
> Best
> Markus


  reply	other threads:[~2026-08-26 22:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01 12:39 [PATCH v7 00/11] arm64: dts: ti: k3-am62a7-sk: Split r5f memory region Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 01/11] arm64: dts: ti: k3-am62a-phycore-som: Fix wkup R5F memory region size Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 02/11] arm64: dts: ti: k3-am62d2-evm: " Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 03/11] arm64: dts: ti: k3-am62a7-sk: " Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 04/11] arm64: dts: ti: k3-am62p-verdin: " Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 05/11] arm64: dts: ti: k3-am62p5-sk: " Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 06/11] arm64: dts: ti: var-som-am62p: " Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 07/11] arm64: dts: ti: k3-am62a-ti-ipc-firmware: Move wkup reserved memory Markus Schneider-Pargmann (TI)
2026-07-09 19:33   ` Andrew Davis
2026-08-25 12:43     ` Markus Schneider-Pargmann
2026-08-26 21:59       ` Andrew Davis [this message]
2026-07-01 12:39 ` [PATCH v7 08/11] arm64: dts: ti: k3-am62p-ti-ipc-firmware: " Markus Schneider-Pargmann (TI)
2026-07-01 12:39 ` [PATCH v7 09/11] arm64: dts: ti: k3-am62a-ti-ipc-firmware: Split r5f memory region Markus Schneider-Pargmann (TI)
2026-07-01 13:18   ` sashiko-bot
2026-07-01 12:39 ` [PATCH v7 10/11] arm64: dts: ti: k3-am62p-ti-ipc-firmware: " Markus Schneider-Pargmann (TI)
2026-07-01 13:30   ` sashiko-bot
2026-07-01 12:39 ` [PATCH v7 11/11] arm64: dts: ti: k3-am62p-ti-ipc-firmware: Add r5f nodes to pre-ram bootphase Markus Schneider-Pargmann (TI)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=de6f8a26-cec7-4618-9a71-b55dcddb0dc4@ti.com \
    --to=afd@ti.com \
    --cc=a-kaur@ti.com \
    --cc=b-padhi@ti.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=d.schultz@phytec.de \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco.dolcini@toradex.com \
    --cc=hnagalla@ti.com \
    --cc=jai.luthra@ideasonboard.com \
    --cc=jm@ti.com \
    --cc=justinstitt@google.com \
    --cc=k-willis@ti.com \
    --cc=khilman@baylibre.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=morbo@google.com \
    --cc=msp@baylibre.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=nm@ti.com \
    --cc=p-bhagat@ti.com \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=sebin.francis@ti.com \
    --cc=stefano.radaelli21@gmail.com \
    --cc=vigneshr@ti.com \
    --cc=vishalm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox