From: Julian Braha <julianbraha@gmail.com>
To: Shiv Prakash Gupta <shivprakash.gupta@nxp.com>,
linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-hwmon@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org
Cc: alexandre.belloni@bootlin.com, krzk+dt@kernel.org,
robh@kernel.org, conor+dt@kernel.org, linux@roeck-us.net,
wim@linux-watchdog.org, vikash.bansal@nxp.com,
priyanka.jain@nxp.com, lakshay.piplani@nxp.com
Subject: Re: [PATCH 3/4] rtc: pcf8525: Add watchdog support
Date: Fri, 14 Aug 2026 17:08:25 +0100 [thread overview]
Message-ID: <e0775be9-9773-424e-9109-5b4b6b620e61@gmail.com> (raw)
In-Reply-To: <20260807082855.3762394-4-shivprakash.gupta@nxp.com>
Hi Shiv,
On 8/7/26 09:28, Shiv Prakash Gupta wrote:
> Add watchdog support for NXP PCF8525 real time clock(RTC) device
>
> Signed-off-by: Lakshay Piplani <lakshay.piplani@nxp.com>
> Signed-off-by: Shiv Prakash Gupta <shivprakash.gupta@nxp.com>
> ---
> drivers/rtc/Kconfig | 1 +
> drivers/rtc/rtc-pcf8525.c | 245 +++++++++++++++++++++++++++++++++++++-
> 2 files changed, 244 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 3c22c7253aae..6c1c7b3d27b6 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -516,6 +516,7 @@ config RTC_DRV_PCF8523
> config RTC_DRV_PCF8525
> tristate "NXP PCF8525"
> select REGMAP_I2C
> + select WATCHDOG_CORE if WATCHDOG
> help
Nitpick, sorry: this Kconfig file uses spaces for indentation, but your
addition uses a tab.
- Julian Braha
next prev parent reply other threads:[~2026-08-14 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 8:28 [PATCH 0/4] rtc: pcf8525: Add NXP PCF8525 RTC driver Shiv Prakash Gupta
2026-08-07 8:28 ` [PATCH 1/4] dt-bindings: rtc: Add NXP PCF8525 RTC Shiv Prakash Gupta
2026-08-07 8:47 ` sashiko-bot
2026-08-12 20:53 ` Rob Herring (Arm)
2026-08-07 8:28 ` [PATCH 2/4] rtc: pcf8525: Add NXP PCF8525 RTC driver Shiv Prakash Gupta
2026-08-07 8:49 ` sashiko-bot
2026-08-07 8:28 ` [PATCH 3/4] rtc: pcf8525: Add watchdog support Shiv Prakash Gupta
2026-08-07 8:52 ` sashiko-bot
2026-08-14 16:08 ` Julian Braha [this message]
2026-08-07 8:28 ` [PATCH 4/4] rtc: pcf8525: Add temperature sensor support via hwmon Shiv Prakash Gupta
2026-08-07 8:48 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0775be9-9773-424e-9109-5b4b6b620e61@gmail.com \
--to=julianbraha@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lakshay.piplani@nxp.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=priyanka.jain@nxp.com \
--cc=robh@kernel.org \
--cc=shivprakash.gupta@nxp.com \
--cc=vikash.bansal@nxp.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox