* [PATCH] arm64: dts: qcom: ipq5018: add label to PCIe1 port node
@ 2026-09-27 4:42 George Moussalem via B4 Relay
2026-09-27 13:54 ` Kathiravan Thirumoorthy
0 siblings, 1 reply; 2+ messages in thread
From: George Moussalem via B4 Relay @ 2026-09-27 4:42 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, George Moussalem
From: George Moussalem <george.moussalem@outlook.com>
Commit a95758e9718a ("arm64: dts: qcom: ipq5018: move PCIe phys and
PERST# to port node") added a label to the PCIe0 port node but not to
that of PCIe1. Boards that have a device connected over PCIe1 need to
reference the port node in the board dts files, so add a label for it.
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
arch/arm64/boot/dts/qcom/ipq5018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index fe1ed240de59..2f3bcfa888a9 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -838,7 +838,7 @@ pcie1: pcie@80000000 {
status = "disabled";
- pcie@0 {
+ pcie1_port0: pcie@0 {
device_type = "pci";
reg = <0x0 0x0 0x0 0x0 0x0>;
bus-range = <0x01 0xff>;
---
base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
change-id: 20260927-ipq5018-pcie1-label-d7d405caf28f
Best regards,
--
George Moussalem <george.moussalem@outlook.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: ipq5018: add label to PCIe1 port node
2026-09-27 4:42 [PATCH] arm64: dts: qcom: ipq5018: add label to PCIe1 port node George Moussalem via B4 Relay
@ 2026-09-27 13:54 ` Kathiravan Thirumoorthy
0 siblings, 0 replies; 2+ messages in thread
From: Kathiravan Thirumoorthy @ 2026-09-27 13:54 UTC (permalink / raw)
To: george.moussalem, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel
On 9/27/2026 10:12 AM, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> Commit a95758e9718a ("arm64: dts: qcom: ipq5018: move PCIe phys and
> PERST# to port node") added a label to the PCIe0 port node but not to
> that of PCIe1. Boards that have a device connected over PCIe1 need to
> reference the port node in the board dts files, so add a label for it.
>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5018.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index fe1ed240de59..2f3bcfa888a9 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> @@ -838,7 +838,7 @@ pcie1: pcie@80000000 {
>
> status = "disabled";
>
> - pcie@0 {
> + pcie1_port0: pcie@0 {
Although the PCIe1 node currently has a label, unused labels are
generally discouraged. I couldn't find any upstream references to the
PCIe1 label. Could you please add the label together with its
corresponding users?
> device_type = "pci";
> reg = <0x0 0x0 0x0 0x0 0x0>;
> bus-range = <0x01 0xff>;
>
> ---
> base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
> change-id: 20260927-ipq5018-pcie1-label-d7d405caf28f
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-27 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-27 4:42 [PATCH] arm64: dts: qcom: ipq5018: add label to PCIe1 port node George Moussalem via B4 Relay
2026-09-27 13:54 ` Kathiravan Thirumoorthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox