Re: [PATCH v4 6/6] arm64: dts: qcom: shikra: Add ICE, TRNG and QCE nodes

[Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>]

>> +		sdhc_ice: crypto@4748000 {
>> +			compatible = "qcom,shikra-inline-crypto-engine",
>> +				     "qcom,inline-crypto-engine";
>> +			reg = <0x0 0x04748000 0x0 0x18000>;
>> +			clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>,
>> +				 <&gcc GCC_SDCC1_AHB_CLK>;
>> +			clock-names = "core",
>> +				      "iface";
>> +			power-domains = <&rpmpd RPMHPD_CX>;
> 
> [Severity: Low]
> Does this code use an RPMh power domain macro (RPMHPD_CX) for an RPM SMD
> power controller instead of RPMPD_VDDCX?
> 
> The sdhc_ice node references the rpmpd (RPM SMD) provider but incorrectly
> assigns it the RPMHPD_CX macro. Because dt-bindings/power/qcom-rpmpd.h
> explicitly includes dt-bindings/power/qcom,rpmhpd.h, the macro is defined
> and evaluates to 0, which happens to match RPMPD_VDDCX. 
> 
> While this avoids build errors and runtime impact, should this use the
> correct RPMPD_VDDCX macro to prevent a semantic mismatch?

This is valid, though both macros resolve to 0 value but best to match
with RPMPD_VDDCX which also matches sdhc power-domains property too.

-- 
Regards
Kuldeep