* [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property @ 2024-07-14 11:28 Inochi Amaoto 2024-07-15 9:21 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Inochi Amaoto @ 2024-07-14 11:28 UTC (permalink / raw) To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: Inochi Amaoto, linux-gpio, devicetree, linux-kernel On Sophgo CV18XX platform, threshold strength of schmitt trigger can be configured. As this standard property is already supported by the common pinconf code. Add "input-schmitt" property in pincfg-node.yaml so that other platforms requiring such feature can make use of this property. Signed-off-by: Inochi Amaoto <inochiama@outlook.com> --- Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml index d0af21a564b4..e838fcac7f2a 100644 --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml @@ -88,6 +88,10 @@ properties: description: disable input on pin (no effect on output, such as disabling an input buffer) + input-schmitt: + $ref: /schemas/types.yaml#/definitions/uint32 + description: threshold strength for schmitt-trigger + input-schmitt-enable: type: boolean description: enable schmitt-trigger mode -- 2.45.2 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property 2024-07-14 11:28 [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property Inochi Amaoto @ 2024-07-15 9:21 ` Krzysztof Kozlowski 2024-07-15 9:55 ` Inochi Amaoto 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2024-07-15 9:21 UTC (permalink / raw) To: Inochi Amaoto, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-gpio, devicetree, linux-kernel On 14/07/2024 13:28, Inochi Amaoto wrote: > On Sophgo CV18XX platform, threshold strength of schmitt trigger can > be configured. As this standard property is already supported by the > common pinconf code. Add "input-schmitt" property in pincfg-node.yaml > so that other platforms requiring such feature can make use of this > property. > > Signed-off-by: Inochi Amaoto <inochiama@outlook.com> > --- > Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > index d0af21a564b4..e838fcac7f2a 100644 > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > @@ -88,6 +88,10 @@ properties: > description: disable input on pin (no effect on output, such as > disabling an input buffer) > > + input-schmitt: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: threshold strength for schmitt-trigger Strength in which units? This should have proper property name suffix. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property 2024-07-15 9:21 ` Krzysztof Kozlowski @ 2024-07-15 9:55 ` Inochi Amaoto 2024-07-15 16:19 ` Conor Dooley 0 siblings, 1 reply; 7+ messages in thread From: Inochi Amaoto @ 2024-07-15 9:55 UTC (permalink / raw) To: Krzysztof Kozlowski, Inochi Amaoto, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley Cc: linux-gpio, devicetree, linux-kernel On Mon, Jul 15, 2024 at 11:21:25AM GMT, Krzysztof Kozlowski wrote: > On 14/07/2024 13:28, Inochi Amaoto wrote: > > On Sophgo CV18XX platform, threshold strength of schmitt trigger can > > be configured. As this standard property is already supported by the > > common pinconf code. Add "input-schmitt" property in pincfg-node.yaml > > so that other platforms requiring such feature can make use of this > > property. > > > > Signed-off-by: Inochi Amaoto <inochiama@outlook.com> > > --- > > Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > index d0af21a564b4..e838fcac7f2a 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > @@ -88,6 +88,10 @@ properties: > > description: disable input on pin (no effect on output, such as > > disabling an input buffer) > > > > + input-schmitt: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: threshold strength for schmitt-trigger > > Strength in which units? This should have proper property name suffix. > > Best regards, > Krzysztof > I think it should be mV. Using voltage may leads to decimal. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property 2024-07-15 9:55 ` Inochi Amaoto @ 2024-07-15 16:19 ` Conor Dooley 2024-07-16 2:16 ` Inochi Amaoto 0 siblings, 1 reply; 7+ messages in thread From: Conor Dooley @ 2024-07-15 16:19 UTC (permalink / raw) To: Inochi Amaoto Cc: Krzysztof Kozlowski, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1639 bytes --] On Mon, Jul 15, 2024 at 05:55:28PM +0800, Inochi Amaoto wrote: > On Mon, Jul 15, 2024 at 11:21:25AM GMT, Krzysztof Kozlowski wrote: > > On 14/07/2024 13:28, Inochi Amaoto wrote: > > > On Sophgo CV18XX platform, threshold strength of schmitt trigger can > > > be configured. As this standard property is already supported by the > > > common pinconf code. Add "input-schmitt" property in pincfg-node.yaml > > > so that other platforms requiring such feature can make use of this > > > property. > > > > > > Signed-off-by: Inochi Amaoto <inochiama@outlook.com> > > > --- > > > Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > > index d0af21a564b4..e838fcac7f2a 100644 > > > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > > @@ -88,6 +88,10 @@ properties: > > > description: disable input on pin (no effect on output, such as > > > disabling an input buffer) > > > > > > + input-schmitt: > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > + description: threshold strength for schmitt-trigger > > > > Strength in which units? This should have proper property name suffix. > > > > I think it should be mV. Using voltage may leads to decimal. The standard suffix for voltage is "-microvolts", so no issues with decimals :) And with a standard suffix, the $ref can be dropped. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property 2024-07-15 16:19 ` Conor Dooley @ 2024-07-16 2:16 ` Inochi Amaoto 2024-07-16 6:16 ` Krzysztof Kozlowski 0 siblings, 1 reply; 7+ messages in thread From: Inochi Amaoto @ 2024-07-16 2:16 UTC (permalink / raw) To: Conor Dooley, Inochi Amaoto Cc: Krzysztof Kozlowski, Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio, devicetree, linux-kernel On Mon, Jul 15, 2024 at 05:19:41PM GMT, Conor Dooley wrote: > On Mon, Jul 15, 2024 at 05:55:28PM +0800, Inochi Amaoto wrote: > > On Mon, Jul 15, 2024 at 11:21:25AM GMT, Krzysztof Kozlowski wrote: > > > On 14/07/2024 13:28, Inochi Amaoto wrote: > > > > On Sophgo CV18XX platform, threshold strength of schmitt trigger can > > > > be configured. As this standard property is already supported by the > > > > common pinconf code. Add "input-schmitt" property in pincfg-node.yaml > > > > so that other platforms requiring such feature can make use of this > > > > property. > > > > > > > > Signed-off-by: Inochi Amaoto <inochiama@outlook.com> > > > > --- > > > > Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > > > index d0af21a564b4..e838fcac7f2a 100644 > > > > --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > > > +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > > > > @@ -88,6 +88,10 @@ properties: > > > > description: disable input on pin (no effect on output, such as > > > > disabling an input buffer) > > > > > > > > + input-schmitt: > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + description: threshold strength for schmitt-trigger > > > > > > Strength in which units? This should have proper property name suffix. > > > > > > > I think it should be mV. Using voltage may leads to decimal. > > The standard suffix for voltage is "-microvolts", so no issues with > decimals :) And with a standard suffix, the $ref can be dropped. Yeah, I have seen the "-microvolts", but I does not think add standard suffix is a good idea, as "input-schmitt" is a standard pinconf attribute. The only thing confused me is that the description of PIN_CONFIG_INPUT_SCHMITT in include/linux/pinctrl/pinconf-generic.h says it just uses an custom format as argument. So I think it may keep something generic? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property 2024-07-16 2:16 ` Inochi Amaoto @ 2024-07-16 6:16 ` Krzysztof Kozlowski 2024-07-16 6:50 ` Inochi Amaoto 0 siblings, 1 reply; 7+ messages in thread From: Krzysztof Kozlowski @ 2024-07-16 6:16 UTC (permalink / raw) To: Inochi Amaoto, Conor Dooley Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio, devicetree, linux-kernel On 16/07/2024 04:16, Inochi Amaoto wrote: > On Mon, Jul 15, 2024 at 05:19:41PM GMT, Conor Dooley wrote: >> On Mon, Jul 15, 2024 at 05:55:28PM +0800, Inochi Amaoto wrote: >>> On Mon, Jul 15, 2024 at 11:21:25AM GMT, Krzysztof Kozlowski wrote: >>>> On 14/07/2024 13:28, Inochi Amaoto wrote: >>>>> On Sophgo CV18XX platform, threshold strength of schmitt trigger can >>>>> be configured. As this standard property is already supported by the >>>>> common pinconf code. Add "input-schmitt" property in pincfg-node.yaml >>>>> so that other platforms requiring such feature can make use of this >>>>> property. >>>>> >>>>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com> >>>>> --- >>>>> Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ >>>>> 1 file changed, 4 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml >>>>> index d0af21a564b4..e838fcac7f2a 100644 >>>>> --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml >>>>> +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml >>>>> @@ -88,6 +88,10 @@ properties: >>>>> description: disable input on pin (no effect on output, such as >>>>> disabling an input buffer) >>>>> >>>>> + input-schmitt: >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>>> + description: threshold strength for schmitt-trigger >>>> >>>> Strength in which units? This should have proper property name suffix. >>>> >>> >>> I think it should be mV. Using voltage may leads to decimal. >> >> The standard suffix for voltage is "-microvolts", so no issues with >> decimals :) And with a standard suffix, the $ref can be dropped. > > Yeah, I have seen the "-microvolts", but I does not think add standard > suffix is a good idea, as "input-schmitt" is a standard pinconf attribute. > > The only thing confused me is that the description of PIN_CONFIG_INPUT_SCHMITT > in include/linux/pinctrl/pinconf-generic.h says it just uses an custom You cannot add binding based on argument "I don't want to change kernel code", so sorry, but it does not really matter whatever pinctrl has undocumented. > format as argument. So I think it may keep something generic? > Best regards, Krzysztof ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property 2024-07-16 6:16 ` Krzysztof Kozlowski @ 2024-07-16 6:50 ` Inochi Amaoto 0 siblings, 0 replies; 7+ messages in thread From: Inochi Amaoto @ 2024-07-16 6:50 UTC (permalink / raw) To: Krzysztof Kozlowski, Inochi Amaoto, Conor Dooley Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-gpio, devicetree, linux-kernel On Tue, Jul 16, 2024 at 08:16:59AM GMT, Krzysztof Kozlowski wrote: > On 16/07/2024 04:16, Inochi Amaoto wrote: > > On Mon, Jul 15, 2024 at 05:19:41PM GMT, Conor Dooley wrote: > >> On Mon, Jul 15, 2024 at 05:55:28PM +0800, Inochi Amaoto wrote: > >>> On Mon, Jul 15, 2024 at 11:21:25AM GMT, Krzysztof Kozlowski wrote: > >>>> On 14/07/2024 13:28, Inochi Amaoto wrote: > >>>>> On Sophgo CV18XX platform, threshold strength of schmitt trigger can > >>>>> be configured. As this standard property is already supported by the > >>>>> common pinconf code. Add "input-schmitt" property in pincfg-node.yaml > >>>>> so that other platforms requiring such feature can make use of this > >>>>> property. > >>>>> > >>>>> Signed-off-by: Inochi Amaoto <inochiama@outlook.com> > >>>>> --- > >>>>> Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml | 4 ++++ > >>>>> 1 file changed, 4 insertions(+) > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > >>>>> index d0af21a564b4..e838fcac7f2a 100644 > >>>>> --- a/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > >>>>> +++ b/Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml > >>>>> @@ -88,6 +88,10 @@ properties: > >>>>> description: disable input on pin (no effect on output, such as > >>>>> disabling an input buffer) > >>>>> > >>>>> + input-schmitt: > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>>> + description: threshold strength for schmitt-trigger > >>>> > >>>> Strength in which units? This should have proper property name suffix. > >>>> > >>> > >>> I think it should be mV. Using voltage may leads to decimal. > >> > >> The standard suffix for voltage is "-microvolts", so no issues with > >> decimals :) And with a standard suffix, the $ref can be dropped. > > > > Yeah, I have seen the "-microvolts", but I does not think add standard > > suffix is a good idea, as "input-schmitt" is a standard pinconf attribute. > > > > The only thing confused me is that the description of PIN_CONFIG_INPUT_SCHMITT > > in include/linux/pinctrl/pinconf-generic.h says it just uses an custom > > You cannot add binding based on argument "I don't want to change kernel > code", so sorry, but it does not really matter whatever pinctrl has > undocumented. > Yes, that is true. Even if not considering the kernel code, I think adding something generic like "input-schmit-xxx" is useful as input schmitt trigger has threshold strength. And if we want to configure it, it should have a value. As the original "input-schmitt" seems to be meaningless, I will take Conor's advice and add "input-schmitt-micorvolts" attribute to handle this. Regards, Inochi ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-16 6:51 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-14 11:28 [PATCH] dt-bindings: pincfg-node: Add "input-schmitt" property Inochi Amaoto 2024-07-15 9:21 ` Krzysztof Kozlowski 2024-07-15 9:55 ` Inochi Amaoto 2024-07-15 16:19 ` Conor Dooley 2024-07-16 2:16 ` Inochi Amaoto 2024-07-16 6:16 ` Krzysztof Kozlowski 2024-07-16 6:50 ` Inochi Amaoto
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox