[PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Taniya Das]

Add device node for video clock controller on Qualcomm SM8750 SoC.

Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8750.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 3f0b57f428bbb388521c27d9ae96bbef3d62b2e2..18e43c509f1f24785d55113addc5cd9f96e986f1 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -2740,6 +2740,20 @@ usb_dwc3_ss: endpoint {
 			};
 		};
 
+		videocc: clock-controller@aaf0000 {
+			compatible = "qcom,sm8750-videocc";
+			reg = <0 0x0aaf0000 0 0x10000>;
+			clocks = <&bi_tcxo_div2>,
+				 <&gcc GCC_VIDEO_AHB_CLK>;
+			power-domains = <&rpmhpd RPMHPD_MMCX>,
+					<&rpmhpd RPMHPD_MXC>;
+			required-opps = <&rpmhpd_opp_low_svs>,
+					<&rpmhpd_opp_low_svs>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		pdc: interrupt-controller@b220000 {
 			compatible = "qcom,sm8750-pdc", "qcom,pdc";
 			reg = <0x0 0x0b220000 0x0 0x10000>, <0x0 0x164400f0 0x0 0x64>;

---
base-commit: 92fd6e84175befa1775e5c0ab682938eca27c0b2
change-id: 20251125-sm8750-videocc-dt-4328c4c98cd4

Best regards,
-- 
Taniya Das <taniya.das@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Abel Vesa]

On 25-11-26 23:39:29, Taniya Das wrote:
> Add device node for video clock controller on Qualcomm SM8750 SoC.
> 
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@linaro.org>

Re: [PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Krzysztof Kozlowski]

On 26/11/2025 19:09, Taniya Das wrote:
> Add device node for video clock controller on Qualcomm SM8750 SoC.
> 
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)


This was already sent.

https://lore.kernel.org/all/20251120-b4-sm8750-iris-dts-v3-1-8715442c30d9@kernel.org/

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Krzysztof Kozlowski]

On 26/11/2025 19:09, Taniya Das wrote:
> Add device node for video clock controller on Qualcomm SM8750 SoC.
> 
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index 3f0b57f428bbb388521c27d9ae96bbef3d62b2e2..18e43c509f1f24785d55113addc5cd9f96e986f1 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -2740,6 +2740,20 @@ usb_dwc3_ss: endpoint {
>  			};
>  		};
>  
> +		videocc: clock-controller@aaf0000 {
> +			compatible = "qcom,sm8750-videocc";
> +			reg = <0 0x0aaf0000 0 0x10000>;

... and the code is not here matching style.

Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Taniya Das]

On 11/27/2025 6:00 PM, Krzysztof Kozlowski wrote:
> On 26/11/2025 19:09, Taniya Das wrote:
>> Add device node for video clock controller on Qualcomm SM8750 SoC.
>>
>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> index 3f0b57f428bbb388521c27d9ae96bbef3d62b2e2..18e43c509f1f24785d55113addc5cd9f96e986f1 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>> @@ -2740,6 +2740,20 @@ usb_dwc3_ss: endpoint {
>>  			};
>>  		};
>>  
>> +		videocc: clock-controller@aaf0000 {
>> +			compatible = "qcom,sm8750-videocc";
>> +			reg = <0 0x0aaf0000 0 0x10000>;
> 
> ... and the code is not here matching style.
> 

I can fix that in the next version. Will you drop it from your patch set?

-- 
Thanks,
Taniya Das

Re: [PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Krzysztof Kozlowski]

On 28/11/2025 09:41, Taniya Das wrote:
> 
> 
> On 11/27/2025 6:00 PM, Krzysztof Kozlowski wrote:
>> On 26/11/2025 19:09, Taniya Das wrote:
>>> Add device node for video clock controller on Qualcomm SM8750 SoC.
>>>
>>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> index 3f0b57f428bbb388521c27d9ae96bbef3d62b2e2..18e43c509f1f24785d55113addc5cd9f96e986f1 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>> @@ -2740,6 +2740,20 @@ usb_dwc3_ss: endpoint {
>>>  			};
>>>  		};
>>>  
>>> +		videocc: clock-controller@aaf0000 {
>>> +			compatible = "qcom,sm8750-videocc";
>>> +			reg = <0 0x0aaf0000 0 0x10000>;
>>
>> ... and the code is not here matching style.
>>
> 
> I can fix that in the next version. Will you drop it from your patch set?

No, of course not! Because as I said - this was sent already. Please do
not send in parallel code which is upstreamed already since long time.
> 


Best regards,
Krzysztof

Re: [PATCH] arm64: dts: qcom: sm8750: Add videocc node for SM8750 SoC

[Taniya Das]

On 11/28/2025 2:36 PM, Krzysztof Kozlowski wrote:
> On 28/11/2025 09:41, Taniya Das wrote:
>>
>>
>> On 11/27/2025 6:00 PM, Krzysztof Kozlowski wrote:
>>> On 26/11/2025 19:09, Taniya Das wrote:
>>>> Add device node for video clock controller on Qualcomm SM8750 SoC.
>>>>
>>>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>>>> ---
>>>>  arch/arm64/boot/dts/qcom/sm8750.dtsi | 14 ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>>> index 3f0b57f428bbb388521c27d9ae96bbef3d62b2e2..18e43c509f1f24785d55113addc5cd9f96e986f1 100644
>>>> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>>> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
>>>> @@ -2740,6 +2740,20 @@ usb_dwc3_ss: endpoint {
>>>>  			};
>>>>  		};
>>>>  
>>>> +		videocc: clock-controller@aaf0000 {
>>>> +			compatible = "qcom,sm8750-videocc";
>>>> +			reg = <0 0x0aaf0000 0 0x10000>;
>>>
>>> ... and the code is not here matching style.
>>>
>>
>> I can fix that in the next version. Will you drop it from your patch set?
> 
> No, of course not! Because as I said - this was sent already. Please do
> not send in parallel code which is upstreamed already since long time.

Thanks Krzysztof.

-- 
Thanks,
Taniya Das