[PATCH 0/2] arm64: dts: agilex5: add support for debug daughter card

[PATCH 0/2] arm64: dts: agilex5: add support for debug daughter card

[Adrian Ng Ho Yin]

The Agilex5 SoCDK supports an optional debug daughter card that requires
a dedicated device tree variant due to differences in peripheral
connectivity compared to the standard SoCDK configuration.

When the debug daughter card is fitted:
  - gpio0 and gmac2 are disabled
  - gmac0 is enabled with RGMII PHY connectivity
  - spi0 is enabled with a <device> peripheral at chip select 0
  - The HPS LED is rewired from gpio0/porta to gpio1/portb

The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only
the nodes that differ, keeping the delta minimal.

Adrian Ng Ho Yin (2):
  dt-bindings: altera: add compatible for agilex5 socdk debug daughter
    card
  arm64: dts: agilex5: add support for debug daughter card

 .../devicetree/bindings/arm/altera.yaml       |  1 +
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_debug.dts | 50 +++++++++++++++++++
 3 files changed, 52 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts

-- 
2.49.GIT

[PATCH 1/2] dt-bindings: altera: add compatible for agilex5 socdk debug daughter card

[Adrian Ng Ho Yin]

Agilex5 devkit supports a debug daughter card that inherits the
configurations from socdk but disables gpio0 and gmac2 and enables gmac0
and spi0.

Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
---
 Documentation/devicetree/bindings/arm/altera.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/altera.yaml b/Documentation/devicetree/bindings/arm/altera.yaml
index 06513895a159..c17e3bf2b077 100644
--- a/Documentation/devicetree/bindings/arm/altera.yaml
+++ b/Documentation/devicetree/bindings/arm/altera.yaml
@@ -111,6 +111,7 @@ properties:
           - enum:
               - intel,socfpga-agilex5-socdk
               - intel,socfpga-agilex5-socdk-013b
+              - intel,socfpga-agilex5-socdk-debug
               - intel,socfpga-agilex5-socdk-modular
               - intel,socfpga-agilex5-socdk-nand
           - const: intel,socfpga-agilex5
-- 
2.49.GIT

Re: [PATCH 1/2] dt-bindings: altera: add compatible for agilex5 socdk debug daughter card

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH 2/2] arm64: dts: agilex5: add support for debug daughter card

[Adrian Ng Ho Yin]

Add a new dts for the Agilex 5 SoCDK when fitted with the debug daughter
card where several peripherals such as gpio0 and gmac2 are disabled while
gmac0 and spi0 are enabled hence requiring a separate device tree.

Signed-off-by: Niravkumar L Rabara <nirav.rabara@altera.com>
Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
---
 arch/arm64/boot/dts/intel/Makefile            |  1 +
 .../dts/intel/socfpga_agilex5_socdk_debug.dts | 50 +++++++++++++++++++
 2 files changed, 51 insertions(+)
 create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts

diff --git a/arch/arm64/boot/dts/intel/Makefile b/arch/arm64/boot/dts/intel/Makefile
index 088a03b89c99..84982bf13ee5 100644
--- a/arch/arm64/boot/dts/intel/Makefile
+++ b/arch/arm64/boot/dts/intel/Makefile
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \
 				socfpga_agilex3_socdk.dtb \
 				socfpga_agilex5_socdk.dtb \
 				socfpga_agilex5_socdk_013b.dtb \
+				socfpga_agilex5_socdk_debug.dtb \
 				socfpga_agilex5_socdk_modular.dtb \
 				socfpga_agilex5_socdk_nand.dtb \
 				socfpga_agilex7m_socdk.dtb \
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
new file mode 100644
index 000000000000..3981a9e876b0
--- /dev/null
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
@@ -0,0 +1,50 @@
+// SPDX-License-Identifier:     GPL-2.0
+/*
+ * Copyright (C) 2026, Altera Corporation
+ */
+#include "socfpga_agilex5_socdk.dts"
+
+/ {
+	model = "SoCFPGA Agilex5 SoCDK - debug daughter card";
+	compatible = "intel,socfpga-agilex5-socdk-debug", "intel,socfpga-agilex5";
+
+	leds {
+		led-0 {
+			gpios = <&portb 12 GPIO_ACTIVE_HIGH>;
+		};
+	};
+};
+
+&gmac0 {
+	status = "okay";
+	phy-mode = "rgmii"; /* TX/RX clock delays provided by Agilex5 I/O hardware */
+	phy-handle = <&emac0_phy0>;
+
+	max-frame-size = <9000>;
+
+	mdio0 {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		compatible = "snps,dwmac-mdio";
+		emac0_phy0: ethernet-phy@0 {
+			reg = <0>;
+		};
+	};
+};
+
+&gmac2 {
+	status = "disabled";
+};
+
+&gpio0 {
+	status = "disabled";
+};
+
+&spi0 {
+	status = "okay";
+	spidev@0 {
+		compatible = "rohm,dh2228fv";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+	};
+};
-- 
2.49.GIT

Re: [PATCH 2/2] arm64: dts: agilex5: add support for debug daughter card

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Abuse of the 'rohm,dh2228fv' compatible string to force the 'spidev' driver to bind.
- [Low] Including a '.dts' file directly instead of using a '.dtsi' include file.
--

commit 3916af69e58bdb9bf4d736172238dd0b03e9465b
Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>

arm64: dts: agilex5: add support for debug daughter card

This commit adds a new device tree for the Agilex 5 SoCDK when fitted with
the debug daughter card. It disables several peripherals such as gpio0 and
gmac2 while enabling gmac0 and spi0 for debugging purposes.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
> new file mode 100644
> index 0000000000000..3981a9e876b0a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_debug.dts
> @@ -0,0 +1,50 @@
> +// SPDX-License-Identifier:     GPL-2.0
> +/*
> + * Copyright (C) 2026, Altera Corporation
> + */
> +#include "socfpga_agilex5_socdk.dts"

This isn't a bug, but does this include a final board .dts file instead of a
shared .dtsi include?

Standard Device Tree conventions typically involve refactoring shared
configurations into a common .dtsi file, as .dts files are meant to be the
final top-level compilation unit for a board.

[ ... ]

> +&spi0 {
> +	status = "okay";
> +	spidev@0 {
> +		compatible = "rohm,dh2228fv";

Is there actually a Rohm DH2228FV hardware device present on this debug
daughter card?

The commit message indicates this exposes the SPI interface for debugging.
Does this code use the 'rohm,dh2228fv' compatible string solely to force the
Linux spidev driver to bind?

The Device Tree is meant for describing hardware, and using fake hardware
compatible strings to instantiate userspace interfaces bypasses the kernel
warnings against using a bare 'spidev' compatible string.

> +		reg = <0>;
> +		spi-max-frequency = <10000000>;
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1778237639.git.adrian.ho.yin.ng@altera.com?part=2

Re: [PATCH 0/2] arm64: dts: agilex5: add support for debug daughter card

[Dinh Nguyen]

On 5/8/26 05:57, Adrian Ng Ho Yin wrote:
> The Agilex5 SoCDK supports an optional debug daughter card that requires
> a dedicated device tree variant due to differences in peripheral
> connectivity compared to the standard SoCDK configuration.
> 
> When the debug daughter card is fitted:
>    - gpio0 and gmac2 are disabled
>    - gmac0 is enabled with RGMII PHY connectivity
>    - spi0 is enabled with a <device> peripheral at chip select 0
>    - The HPS LED is rewired from gpio0/porta to gpio1/portb
> 
> The new DTS inherits from socfpga_agilex5_socdk.dts and overrides only
> the nodes that differ, keeping the delta minimal.
> 
> Adrian Ng Ho Yin (2):
>    dt-bindings: altera: add compatible for agilex5 socdk debug daughter
>      card
>    arm64: dts: agilex5: add support for debug daughter card
> 

Applied!

Thanks,
Dinh