* [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
@ 2026-04-30 14:01 Swati Agarwal
2026-04-30 15:12 ` Konrad Dybcio
2026-05-03 12:36 ` Krzysztof Kozlowski
0 siblings, 2 replies; 4+ messages in thread
From: Swati Agarwal @ 2026-04-30 14:01 UTC (permalink / raw)
To: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel,
Swati Agarwal
Qualcomm TLMM-based pin controllers share the same gpio-hog binding
semantics across multiple SoCs. The gpio-hog pattern currently defined in
qcom,sdm845-pinctrl.yaml is not specific to SDM845 and applies to all TLMM
controllers.
Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
duplication.
Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
---
Changes in v2:
Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml
Link to v1:
https://lore.kernel.org/all/20260417152014.3000797-1-swati.agarwal@oss.qualcomm.com/
---
.../devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 5 -----
.../devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 6 ++++++
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
index 4fcac2e55b55..3b33daedc018 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml
@@ -42,11 +42,6 @@ patternProperties:
$ref: "#/$defs/qcom-sdm845-tlmm-state"
additionalProperties: false
- "-hog(-[0-9]+)?$":
- type: object
- required:
- - gpio-hog
-
$defs:
qcom-sdm845-tlmm-state:
type: object
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
index aae3dcf6cac8..aec72e8c0621 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,tlmm-common.yaml
@@ -51,6 +51,12 @@ properties:
should not be accessed by the OS. Please see the ../gpio/gpio.txt for more
information.
+patternProperties:
+ "-hog(-[0-9]+)?$":
+ type: object
+ required:
+ - gpio-hog
+
allOf:
- $ref: pinctrl.yaml#
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
2026-04-30 14:01 [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common Swati Agarwal
@ 2026-04-30 15:12 ` Konrad Dybcio
2026-05-03 12:36 ` Krzysztof Kozlowski
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-04-30 15:12 UTC (permalink / raw)
To: Swati Agarwal, Bjorn Andersson, Linus Walleij, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, linux-gpio, devicetree, linux-kernel
On 4/30/26 4:01 PM, Swati Agarwal wrote:
> Qualcomm TLMM-based pin controllers share the same gpio-hog binding
> semantics across multiple SoCs. The gpio-hog pattern currently defined in
> qcom,sdm845-pinctrl.yaml is not specific to SDM845 and applies to all TLMM
> controllers.
>
> Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
> that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
> duplication.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---
> Changes in v2:
> Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml
>
> Link to v1:
> https://lore.kernel.org/all/20260417152014.3000797-1-swati.agarwal@oss.qualcomm.com/
> ---
> .../devicetree/bindings/pinctrl/qcom,sdm845-pinctrl.yaml | 5 -----
> .../devicetree/bindings/pinctrl/qcom,tlmm-common.yaml | 6 ++++++
Please also remove it from qcom,ipq4019-pinctrl, which also includes
tlmm-common
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
2026-04-30 14:01 [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common Swati Agarwal
2026-04-30 15:12 ` Konrad Dybcio
@ 2026-05-03 12:36 ` Krzysztof Kozlowski
2026-05-04 6:25 ` Swati Agarwal
1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-03 12:36 UTC (permalink / raw)
To: Swati Agarwal
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Thu, Apr 30, 2026 at 07:31:18PM +0530, Swati Agarwal wrote:
> Qualcomm TLMM-based pin controllers share the same gpio-hog binding
> semantics across multiple SoCs. The gpio-hog pattern currently defined in
> qcom,sdm845-pinctrl.yaml is not specific to SDM845 and applies to all TLMM
> controllers.
>
> Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
> that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
> duplication.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---
> Changes in v2:
> Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml
>
> Link to v1:
> https://lore.kernel.org/all/20260417152014.3000797-1-swati.agarwal@oss.qualcomm.com/
Does not look like v1. That's a DTS patch.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common
2026-05-03 12:36 ` Krzysztof Kozlowski
@ 2026-05-04 6:25 ` Swati Agarwal
0 siblings, 0 replies; 4+ messages in thread
From: Swati Agarwal @ 2026-05-04 6:25 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bjorn Andersson, Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, linux-gpio, devicetree, linux-kernel
On Sun, May 3, 2026 at 6:06 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Thu, Apr 30, 2026 at 07:31:18PM +0530, Swati Agarwal wrote:
> > Qualcomm TLMM-based pin controllers share the same gpio-hog binding
> > semantics across multiple SoCs. The gpio-hog pattern currently defined in
> > qcom,sdm845-pinctrl.yaml is not specific to SDM845 and applies to all TLMM
> > controllers.
> >
> > Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml so
> > that it can be reused by other Qualcomm TLMM pinctrl bindings and avoid
> > duplication.
> >
> > Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> > ---
> > Changes in v2:
> > Move the gpio-hog patternProperties definition to qcom,tlmm-common.yaml
> >
> > Link to v1:
> > https://lore.kernel.org/all/20260417152014.3000797-1-swati.agarwal@oss.qualcomm.com/
>
> Does not look like v1. That's a DTS patch.
Hi Krzysztof,
Yes that's correct, v1 is a patch to DTS.
But in v1 , I received comment from Dmitry to move gpio hog bindings
to qcom,tlmm-common.yaml [1] so just gave reference to that v1 version
and splitted DT bindings and DTS patch patch[2].
[1] https://lore.kernel.org/all/6ijpvrd7mm5c6zsvogzm6uwsxpwqugur7oles5i55cqyage2hd@rig24poqt27g/
[2] https://lore.kernel.org/all/20260430142000.3707614-1-swati.agarwal@oss.qualcomm.com/
Regards,
Swati
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-04 6:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-30 14:01 [PATCH v2] dt-bindings: pinctrl: qcom: move gpio-hog schema to tlmm-common Swati Agarwal
2026-04-30 15:12 ` Konrad Dybcio
2026-05-03 12:36 ` Krzysztof Kozlowski
2026-05-04 6:25 ` Swati Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox