From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, stephan@gerhold.net,
caleb.connolly@linaro.org, neil.armstrong@linaro.org,
laetitia.mariottini@se.com, pascal.eberhard@se.com,
abdou.saker@se.com, jimmy.lalande@se.com,
benjamin.missey@non.se.com, daniel.thompson@linaro.org,
linux-kernel@vger.kernel.org,
Jagdish Gediya <jagdish.gediya@linaro.org>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS
Date: Thu, 14 Mar 2024 11:06:46 +0100 [thread overview]
Message-ID: <f03c7979-79f3-4894-98b0-1e5a2dc18ba6@linaro.org> (raw)
In-Reply-To: <CAFA6WYNo73S5ROHCMK0ZQSiU0DDbuDadptmaPL+GPCocE0h-mA@mail.gmail.com>
On 14/03/2024 10:36, Sumit Garg wrote:
>>
>> But it then broke dtbs_check.
>
> See following breakage afterwards:
>
> $ make qcom/apq8016-schneider-hmibsc.dtb dtbs_check
> <snip>
> /home/sumit/build/upstream/linux/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb:
> leds: led@5: Unevaluated properties are not allowed ('reg' was
> unexpected)
> from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#
> /home/sumit/build/upstream/linux/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb:
> leds: led@6: Unevaluated properties are not allowed ('reg' was
> unexpected)
> from schema $id: http://devicetree.org/schemas/leds/leds-gpio.yaml#
> /home/sumit/build/upstream/linux/arch/arm64/boot/dts/qcom/apq8016-schneider-hmibsc.dtb:
> leds: '#address-cells', '#size-cells' do not match any of the regexes:
> '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
That's obvious, I don't get what is the question. Adding not correct
properties is not a solution and dtbs_check correctly tells you that.
If you only opened absolutely any existing upstream source, you would
see how the gpio leds are represented in DTS.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-14 10:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 12:30 [PATCH v2 0/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS Sumit Garg
2024-03-13 12:30 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add Schneider Electric Sumit Garg
2024-03-13 13:00 ` Krzysztof Kozlowski
2024-03-13 12:30 ` [PATCH v2 2/3] dt-bindings: arm: qcom: Add Schneider Electric HMIBSC board Sumit Garg
2024-03-13 13:00 ` Krzysztof Kozlowski
2024-03-13 12:30 ` [PATCH v2 3/3] arm64: dts: qcom: apq8016: Add Schneider HMIBSC board DTS Sumit Garg
2024-03-13 12:55 ` Caleb Connolly
2024-03-13 13:00 ` Krzysztof Kozlowski
2024-03-14 8:19 ` Sumit Garg
2024-03-14 8:30 ` Krzysztof Kozlowski
2024-03-14 9:17 ` Sumit Garg
2024-03-14 9:36 ` Sumit Garg
2024-03-14 10:06 ` Krzysztof Kozlowski [this message]
2024-03-14 10:26 ` Sumit Garg
2024-03-14 11:20 ` Krzysztof Kozlowski
2024-03-14 13:14 ` Dmitry Baryshkov
2024-03-14 10:05 ` Krzysztof Kozlowski
2024-03-13 13:04 ` Konrad Dybcio
2024-03-13 13:07 ` Krzysztof Kozlowski
2024-03-14 9:04 ` Sumit Garg
2024-03-14 9:18 ` Konrad Dybcio
2024-03-14 9:32 ` Sumit Garg
2024-03-14 10:07 ` Krzysztof Kozlowski
2024-03-14 10:43 ` Stephan Gerhold
2024-03-14 11:56 ` Sumit Garg
2024-03-14 13:24 ` Stephan Gerhold
2024-03-14 13:50 ` Sumit Garg
2024-03-14 15:20 ` Konrad Dybcio
2024-03-14 15:37 ` Caleb Connolly
2024-03-15 9:31 ` Sumit Garg
2024-03-15 12:53 ` Caleb Connolly
2024-03-15 14:31 ` Stephan Gerhold
2024-03-18 8:02 ` Sumit Garg
2024-03-13 12:57 ` [PATCH v2 0/3] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f03c7979-79f3-4894-98b0-1e5a2dc18ba6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abdou.saker@se.com \
--cc=andersson@kernel.org \
--cc=benjamin.missey@non.se.com \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jagdish.gediya@linaro.org \
--cc=jimmy.lalande@se.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laetitia.mariottini@se.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pascal.eberhard@se.com \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
--cc=sumit.garg@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox