From: Jan Kiszka <jan.kiszka@siemens.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>
Subject: Re: [PATCH 3/4] arm64: dts: ti: iot2050: Factor out arduino connector bits
Date: Tue, 19 Dec 2023 09:06:32 +0100 [thread overview]
Message-ID: <f4b16dc6-1063-40d4-b68e-1eef9db32829@siemens.com> (raw)
In-Reply-To: <10f300d6-8a1a-4363-a16e-8337da8525d1@linaro.org>
On 19.12.23 08:51, Krzysztof Kozlowski wrote:
> On 18/12/2023 17:35, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> A new variant is to be added which will not have a arduino connector
>> like the existing ones. Factor out all bits that are specific to this
>> connector.
>>
>> The split is not perfect because wkup_gpio0 is defined based on what is
>> common to all variants having the connector, thus containing also
>> connector-unrelated information. But this is still cleaner than
>> replicating this node into all 4 variants.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> .../ti/k3-am65-iot2050-arduino-connector.dtsi | 768 ++++++++++++++++++
>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 753 -----------------
>
> Please use proper -B/-M/-C arguments so code movements will be detected.
>
Those are in place but have no impact, likely because the source file is
still ~700 lines after the shuffling.
Jan
--
Siemens AG, Technology
Linux Expert Center
next prev parent reply other threads:[~2023-12-19 8:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 16:35 [PATCH 0/4] arm64: dts: iot2050: Add support for new SM variant Jan Kiszka
2023-12-18 16:35 ` [PATCH 1/4] dt-bindings: arm: ti: Add binding for Siemens IOT2050 " Jan Kiszka
2023-12-19 7:50 ` Krzysztof Kozlowski
2023-12-18 16:35 ` [PATCH 2/4] arm64: dts: ti: iot2050: Disable R5 lockstep for all PG2 boards Jan Kiszka
2023-12-18 16:35 ` [PATCH 3/4] arm64: dts: ti: iot2050: Factor out arduino connector bits Jan Kiszka
2023-12-19 7:51 ` Krzysztof Kozlowski
2023-12-19 8:06 ` Jan Kiszka [this message]
2023-12-19 8:12 ` Krzysztof Kozlowski
2023-12-19 8:18 ` Jan Kiszka
2023-12-18 16:36 ` [PATCH 4/4] dts: iot2050: Support IOT2050-SM variant Jan Kiszka
2023-12-19 7:54 ` Krzysztof Kozlowski
2023-12-19 8:22 ` Jan Kiszka
2023-12-19 8:48 ` Krzysztof Kozlowski
2023-12-19 9:03 ` Jan Kiszka
2023-12-19 9:45 ` Krzysztof Kozlowski
2023-12-19 9:50 ` Krzysztof Kozlowski
2023-12-19 9:54 ` Jan Kiszka
2023-12-19 9:56 ` Jan Kiszka
2023-12-19 9:58 ` Krzysztof Kozlowski
2023-12-19 15:37 ` Jan Kiszka
2023-12-19 15:39 ` Krzysztof Kozlowski
2023-12-19 15:40 ` Jan Kiszka
2023-12-19 15:42 ` Krzysztof Kozlowski
2023-12-19 15:48 ` Jan Kiszka
2023-12-19 15:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b16dc6-1063-40d4-b68e-1eef9db32829@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox