Re: [PATCH RFC 00/12] Qualcomm Type-C support for 1st generation

[David Heidelberg <david@ixit.cz>]

On 27/09/2026 15:05, Dmitry Baryshkov wrote:
> On Sat, Sep 26, 2026 at 02:40:19PM +0200, David Heidelberg via B4 Relay wrote:
>> This series adds basic USB Type-C support for 1st gen devices, covering
>> configurations that do not require VBUS power (e.g. devices using
>> externally powered docks).
>>
>> VBUS support will be added in a follow-up series after this one is merged.
>> Supporting VBUS will likely require refactoring parts of the SMBX charger
>> support, which is why it is not included here.
>>
>> Tested with an externally powered dock station:
>>
>>   - Pixel 3 / 3 XL
>>   - SHIFT 6mq
>>   - OnePlus 6
>>
>> Tested with an additional, not-yet-included VBUS patch for non-powered
>> devices:
>>
>>   - Xiaomi Redmi Note 7
>>   - Xiaomi Mi Pad 4
> 
> THis is very interesting, as it will also unblock DisplayPort support on
> devices from those generations.

Yes, DP works with some minor adjustment there and there (going to be follow-up)

> 
> 
> One major comment. As we see, on SMB2 PMICs parts of the Type-C
> functionality are provided by the charger / FG device. I guess that on
> SMB5 PMICs we will get the same problem once somebody tries to implement
> additional charger features. Would it make sense to rework the PMIC TCPM
> driver to be a composite driver, taking several components via the
> existing Linux interface?

As this gets decided from the QCOM side, I'm fine with whatever suits the 
hardware best.

David

> 
>>
>> Credits to everyone who has contributed to Type-C enablement before:
>>
>>   Casey Connolly
>>   Zachary Dry — LLM generation and testing
>>   Max Furman — LLM generation and testing
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>