Re: [PATCH v4 2/3] dt-bindings: i3c: dw: Add apb reset

[Krzysztof Kozlowski <krzk@kernel.org>]

On 25/05/2026 16:00, Jisheng Zhang wrote:
> Add dt-binding for support of apb reset which is to reset the APB
> interface.

And this is ABI break, so you must explain WHY breaking ABI is worth
doing that or what is the impact. Additionally you should explain which
devices have it. Does Altera have it? You really lack explanation WHY
you are doing it and which hardware you exactly describe.

> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> index 613dce7757bc..2575442b28ff 100644
> --- a/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> +++ b/Documentation/devicetree/bindings/i3c/snps,dw-i3c-master.yaml
> @@ -38,10 +38,12 @@ properties:
>    resets:
>      items:
>        - description: Reset signal
> +      - description: APB interface reset signal
>  
>    reset-names:
>      items:
>        - const: core_rst
> +      - const: apb_rst

apb

>  
>    interrupts:
>      maxItems: 1


Best regards,
Krzysztof