Re: Xilinx SYSACE driver and 8-bit attachment

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

[Added devicetree-discuss to cc: list]

On Wed, Oct 7, 2009 at 1:13 AM, John Williams
<john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org> wrote:
> Hi Grant (it's your driver :) and David D ( and your DTS generator :)
[...]
> if (of_find_property(op->node, "8-bit", NULL))
[...]
> doesn't match the properties generated by Xilinx's device tree generator:
[...]
>                         xlnx,mem-width = <0x8>;
>
> So, the question is, which should change?

Well, obviously its a device tree generator bug, the driver code is
perfect.  :-P

In all seriousness though, the '8-bit' property has been present for a
while now and needs to be retained to not break existing users.  It
would be okay for the driver to be modified to *also* check for the
xlnx,mem-width property, but the better solution is to modify the
device tree generator.  Plus, the '8-bit' property is the documented
binding in Documentation/powerpc/dts-bindings/xilinx.txt

Cheers,
g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.