Re: Xilinx SYSACE driver and 8-bit attachment

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

On Wed, Oct 7, 2009 at 8:42 AM, John Linn <John.Linn-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> wrote:
>> -----Original Message-----
>> From: John Linn
>> Sent: Wednesday, October 07, 2009 8:24 AM
>> To: 'Grant Likely'; John Williams
>> Cc: Linux Kernel list; Michal Simek; David DeBonis; Stephen Neuendorffer; devicetree-discuss
>> Subject: RE: Xilinx SYSACE driver and 8-bit attachment
>>
>> I'll look to see if something has changed.  It's not clear to me if it has ever been right.
>>
>> It look like we normally use 16 bit mode as that's how BSB generates the system by default.
>>
>> Thanks,
>> John
>>
>> > -----Original Message-----
>> > From: glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org [mailto:glikely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org] On Behalf Of Grant Likely
>> > Sent: Wednesday, October 07, 2009 7:35 AM
>> > To: John Williams
>> > Cc: Linux Kernel list; Michal Simek; John Linn; David DeBonis; Stephen Neuendorffer; devicetree-
>> > discuss
>> > Subject: Re: Xilinx SYSACE driver and 8-bit attachment
>> >
>> > [Added devicetree-discuss to cc: list]
>> >
>> > On Wed, Oct 7, 2009 at 1:13 AM, John Williams
>> > <john.williams-g5w7nrANp4BDPfheJLI6IQ@public.gmane.org> wrote:
>> > > Hi Grant (it's your driver :) and David D ( and your DTS generator :)
>> > [...]
>> > > if (of_find_property(op->node, "8-bit", NULL))
>> > [...]
>> > > doesn't match the properties generated by Xilinx's device tree generator:
>> > [...]
>> > >                         xlnx,mem-width = <0x8>;
>
> Do you know if the 8 bit mode was ever tested with the "8-bit" property in the tree?
>
> I don't see anything in the device tree generator history to say we ever did that "8-bit", but maybe I'm missing something.
>
> We are just generating the parameters from the h/w and the memory width is it.  We can always put something in there special, but it seems silly if it was never used anyway.

Don't forget that Virtex and Microblaze are not the only users of this
driver.   There is a AMCC 440 board which uses the sysace as a CF
adapter.  8-bit was definitely tested and is in use.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.