From: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
To: Yoder Stuart-B08248 <B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Wood Scott-B07421
<B07421-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
parch-QRwYI7m9GJLYtjvyW6yDsg@public.gmane.org,
Gala Kumar-B11780
<B11780-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
David Gibson <dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [Power.org:parch] Re: RFC: proposal to extend the open-pic interrupt specifierdefinition
Date: Wed, 13 Jan 2010 07:27:31 -0700 [thread overview]
Message-ID: <fa686aa41001130627g7ed3bd46p6ac50631576d89ef@mail.gmail.com> (raw)
In-Reply-To: <9696D7A991D0824DBA8DFAC74A9C5FA305988946-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org>
On Wed, Jan 13, 2010 at 7:19 AM, Yoder Stuart-B08248
<B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:
>> It does not sound sane or
>> particularly parseable to stuff it into bitfields within the second
>> cell.
>
> I think it is somewhat sane compared to the alternatives. The
> second cell encodes information about the interrupt source. Allowing
> some of those bits to encode information besides level/sense
> doesn't seem that difficult.
Not difficult. Ugly, unnecessary, and sounds like a premature optimization.
>> Users have enough trouble parsing irq specifiers as is. It makes me
>> nervous to see even more complicated irq specifiers being devised.
>
> Yes, they become slightly more complicated, but the complexity needs to
> go somewhere.
Then at the very least do it as separate cells. Carving cells into
multiple fields is pretty ugly when cells are cheap.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
next prev parent reply other threads:[~2010-01-13 14:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 23:28 RFC: proposal to extend the open-pic interrupt specifier definition Yoder Stuart-B08248
[not found] ` <9696D7A991D0824DBA8DFAC74A9C5FA30590506E-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org>
2010-01-07 0:50 ` David Gibson
2010-01-07 3:33 ` RFC: proposal to extend the open-pic interrupt specifierdefinition Yoder Stuart-B08248
[not found] ` <9696D7A991D0824DBA8DFAC74A9C5FA305987E61-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org>
2010-01-07 4:55 ` David Gibson
2010-01-07 11:17 ` [Power.org:parch] " Sethi Varun-B16395
2010-01-07 17:18 ` Scott Wood
[not found] ` <4B46176F.2040600-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-01-13 6:04 ` Grant Likely
[not found] ` <fa686aa41001122204w3ce1a31m7debe52a4b5d4fc7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-13 14:19 ` Yoder Stuart-B08248
[not found] ` <9696D7A991D0824DBA8DFAC74A9C5FA305988946-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org>
2010-01-13 14:27 ` Grant Likely [this message]
[not found] ` <fa686aa41001130627g7ed3bd46p6ac50631576d89ef-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-13 17:23 ` Scott Wood
[not found] ` <4B4E01A8.5070509-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-01-17 7:13 ` Grant Likely
[not found] ` <fa686aa41001162313u28ef0fb4s328ebc25bf5e551f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-18 17:44 ` Scott Wood
2010-01-07 17:39 ` Yoder Stuart-B08248
[not found] ` <9696D7A991D0824DBA8DFAC74A9C5FA305987F94-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org>
2010-01-13 6:16 ` Grant Likely
2010-01-08 1:02 ` [Power.org:parch] Re: RFC: proposal to extend the open-pic interrupt specifier definition Benjamin Herrenschmidt
2010-01-12 18:17 ` Segher Boessenkool
[not found] ` <50433.84.105.60.153.1263320254.squirrel-JorI+TVEvZrY24RiXHRV3ti2O/JbrIOy@public.gmane.org>
2010-01-12 18:36 ` Yoder Stuart-B08248
[not found] ` <9696D7A991D0824DBA8DFAC74A9C5FA305988778-ofAVchDyotYzzZk0BCvKg5jmvxFtTJ+o0e7PPNI6Mm0@public.gmane.org>
2010-01-13 6:06 ` Grant Likely
[not found] ` <fa686aa41001122206l232b270er58323a6409e575e9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-13 6:24 ` Grant Likely
[not found] ` <fa686aa41001122224t2eeec9acy15b40420ebe18541-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-13 18:06 ` Scott Wood
[not found] ` <4B4E0B96.1030204-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-01-17 6:42 ` Grant Likely
2010-01-13 18:02 ` Scott Wood
[not found] ` <4B4E0AC7.7090502-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2010-01-17 7:06 ` Grant Likely
[not found] ` <fa686aa41001162306x7c4e3dedy196409a4c8420e35-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-18 17:11 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41001130627g7ed3bd46p6ac50631576d89ef@mail.gmail.com \
--to=grant.likely-s3s/wqlpoipyb63q8fvjnq@public.gmane.org \
--cc=B07421-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=B11780-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=dwg-8fk3Idey6ehBDgjK7y7TUQ@public.gmane.org \
--cc=parch-QRwYI7m9GJLYtjvyW6yDsg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox