Re: [PATCH 00/27] Clean up of_platform drivers

Re: [PATCH 00/27] Clean up of_platform drivers

[David Miller]

Grant you've just posted two enormous patch sets at the SAME EXACT
TIME to the SAME AREAS of the kernel.

One has 37 patches and this one has 27.

Not only are these sets enormous, you haven't specified what in the
world they are against.

The 37 patch set didn't apply cleanly to Linus tree and once I worked
through the rejects as best I could it didn't even compile.

How are people supposed to test this stuff? :-/

Re: [PATCH 05/27] drivers/usb/of: don't use deprecated field in of_platform_driver

[Greg KH]

On Thu, Mar 11, 2010 at 11:22:15AM -0700, Grant Likely wrote:
> .name, .match_table and .owner are duplicated in both of_platform_driver
> and device_driver, so the of_platform_driver copies will be removed soon.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

Re: [PATCH 12/27] drivers/mtd/of: don't use deprecated field in of_platform_driver

[Sean MacLennan]

On Thu, 11 Mar 2010 11:22:54 -0700
Grant Likely <grant.likely@secretlab.ca> wrote:

> .name, .match_table and .owner are duplicated in both
> of_platform_driver and device_driver, so the of_platform_driver
> copies will be removed soon.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

NDFC
Acked-by: Sean MacLennan <smaclennan@pikatech.com>

Re: [PATCH 22/27] drivers/i2c/of: don't use deprecated field in of_platform_driver

[Sean MacLennan]

On Thu, 11 Mar 2010 11:23:49 -0700
Grant Likely <grant.likely@secretlab.ca> wrote:

> .name, .match_table and .owner are duplicated in both
> of_platform_driver and device_driver, so the of_platform_driver
> copies will be removed soon.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

i2c-ibm_iic
Acked-by: Sean MacLennan <smaclennan@pikatech.com>

Re: [alsa-devel] [PATCH 13/27] drivers/net/of: don't use deprecated field in of_platform_driver

[Timur Tabi]

I'm seeing this error with this patch applied, when building for an mpc8641_hpcn

  CC      drivers/net/gianfar.o
drivers/net/gianfar.c: In function 'gfar_of_init':
drivers/net/gianfar.c:606: error: 'struct platform_device' has no
member named 'node'
drivers/net/gianfar.c:644: error: 'struct platform_device' has no
member named 'node'
drivers/net/gianfar.c: In function 'gfar_probe':
drivers/net/gianfar.c:891: error: 'struct platform_device' has no
member named 'node'
make[2]: *** [drivers/net/gianfar.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2


On Thu, Mar 11, 2010 at 1:23 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
> .name, .match_table and .owner are duplicated in both of_platform_driver
> and device_driver, so the of_platform_driver copies will be removed soon.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
>  drivers/net/can/mscan/mpc5xxx_can.c           |    8 +++++---
>  drivers/net/can/sja1000/sja1000_of_platform.c |    8 +++++---
>  drivers/net/ehea/ehea_main.c                  |    7 +++++--
>  drivers/net/fs_enet/fs_enet-main.c            |    7 +++++--
>  drivers/net/fs_enet/mii-bitbang.c             |    7 +++++--
>  drivers/net/fs_enet/mii-fec.c                 |    7 +++++--
>  drivers/net/fsl_pq_mdio.c                     |    7 +++++--
>  drivers/net/gianfar.c                         |   10 ++++++----
>  drivers/net/ibm_newemac/core.c                |    8 +++++---
>  drivers/net/ibm_newemac/mal.c                 |    8 +++++---
>  drivers/net/ibm_newemac/rgmii.c               |    8 +++++---
>  drivers/net/ibm_newemac/tah.c                 |    8 +++++---
>  drivers/net/ibm_newemac/zmii.c                |    8 +++++---
>  drivers/net/ll_temac_main.c                   |    2 +-
>  drivers/net/myri_sbus.c                       |    7 +++++--
>  drivers/net/niu.c                             |    7 +++++--
>  drivers/net/phy/mdio-gpio.c                   |    7 +++++--
>  drivers/net/sunbmac.c                         |    7 +++++--
>  drivers/net/sunhme.c                          |    7 +++++--
>  drivers/net/sunlance.c                        |    7 +++++--
>  drivers/net/sunqe.c                           |    7 +++++--
>  drivers/net/ucc_geth.c                        |    7 +++++--
>  drivers/net/xilinx_emaclite.c                 |    7 +++++--
>  23 files changed, 112 insertions(+), 54 deletions(-)

-- 
Timur Tabi
Linux kernel developer at Freescale

Re: [alsa-devel] [PATCH 13/27] drivers/net/of: don't use deprecated field in of_platform_driver

[Grant Likely]

On Fri, Mar 26, 2010 at 9:23 AM, Timur Tabi <timur.tabi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> I'm seeing this error with this patch applied, when building for an mpc8641_hpcn
>
>  CC      drivers/net/gianfar.o
> drivers/net/gianfar.c: In function 'gfar_of_init':
> drivers/net/gianfar.c:606: error: 'struct platform_device' has no
> member named 'node'
> drivers/net/gianfar.c:644: error: 'struct platform_device' has no
> member named 'node'
> drivers/net/gianfar.c: In function 'gfar_probe':
> drivers/net/gianfar.c:891: error: 'struct platform_device' has no
> member named 'node'
> make[2]: *** [drivers/net/gianfar.o] Error 1
> make[1]: *** [drivers/net] Error 2
> make: *** [drivers] Error 2

Thanks for the testing Timur.  I missed converting that driver.  I
believe I've got that fixed now and I'll be pushing out a new tree
real-soon-now.

g.