From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jie Luo <quic_luoj@quicinc.com>,
andersson@kernel.org, agross@kernel.org,
konrad.dybcio@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_srichara@quicinc.com
Subject: Re: [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084
Date: Wed, 11 Oct 2023 12:33:25 +0100 [thread overview]
Message-ID: <fc35b4e4-a1ef-4200-a7d4-1f8ea3afa5c9@linaro.org> (raw)
In-Reply-To: <49c8a8ff-bdb9-a523-9587-d2a46d401e41@quicinc.com>
On 11/10/2023 12:26, Jie Luo wrote:
>>
>> 0004-clk-qcom-add-clock-controller-driver-for-qca8386-qca.patch has
>> style problems, please review.
>
> Thanks Bryan for the review. The code line mentioned by CHECK is more
> than 100 columns, so i separate the lines.
Yep. Remember to align the indentation as much as possible/reasonable.
Use your discretion.
---
bod
next prev parent reply other threads:[~2023-10-11 11:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-23 11:21 [PATCH v9 0/4] add clock controller of qca8386/qca8084 Luo Jie
2023-09-23 11:21 ` [PATCH v9 1/4] clk: qcom: branch: Add clk_branch2_prepare_ops Luo Jie
2023-09-23 11:21 ` [PATCH v9 2/4] dt-bindings: clock: add qca8386/qca8084 clock and reset definitions Luo Jie
2023-09-23 11:21 ` [PATCH v9 3/4] clk: qcom: common: commonize qcom_cc_really_probe Luo Jie
2023-10-11 10:06 ` Bryan O'Donoghue
2023-09-23 11:21 ` [PATCH v9 4/4] clk: qcom: add clock controller driver for qca8386/qca8084 Luo Jie
2023-10-11 10:25 ` Bryan O'Donoghue
2023-10-11 11:26 ` Jie Luo
2023-10-11 11:32 ` Konrad Dybcio
2023-10-11 12:40 ` Jie Luo
2023-10-11 11:33 ` Bryan O'Donoghue [this message]
2023-10-11 12:42 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc35b4e4-a1ef-4200-a7d4-1f8ea3afa5c9@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_luoj@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox