From: Depeng Shao <quic_depengs@quicinc.com>
To: Hans Verkuil <hverkuil@xs4all.nl>, Krzysztof Kozlowski <krzk@kernel.org>
Cc: <rfoss@kernel.org>, <todor.too@gmail.com>,
<bryan.odonoghue@linaro.org>, <mchehab@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<vladimir.zapolskiy@linaro.org>, <quic_eberman@quicinc.com>,
<linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@quicinc.com>, Yongsheng Li <quic_yon@quicinc.com>
Subject: Re: [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding
Date: Tue, 7 Jan 2025 20:47:31 +0800 [thread overview]
Message-ID: <fd61c298-f271-4e21-b1e1-dee1029e978d@quicinc.com> (raw)
In-Reply-To: <a0eafc67-2ebf-4d2a-8213-c30c3c317a1a@xs4all.nl>
Hi Hans,
On 1/6/2025 10:00 PM, Hans Verkuil wrote:
> On 04/01/2025 14:40, Depeng Shao wrote:
>> Hi Krzysztof,
>>
>> On 12/27/2024 5:10 PM, Krzysztof Kozlowski wrote:
>>> On Wed, Dec 25, 2024 at 07:05:19PM +0530, Depeng Shao wrote:
>>>> Add bindings for qcom,sm8550-camss in order to support the camera
>>>> subsystem for sm8550.
>>>>
>>>> Co-developed-by: Yongsheng Li <quic_yon@quicinc.com>
>>>> Signed-off-by: Yongsheng Li <quic_yon@quicinc.com>
>>>> Signed-off-by: Depeng Shao <quic_depengs@quicinc.com>
>>>> ---
>>>
>>> Is this v7 or v1? Same issue was all the time in the past, so why can't
>>> you finally fix it?
>>>
>>> Look:
>>>
>>> $ b4 diff 20241225133523.4034820-13-quic_depengs@quicinc.com
>>> Breaking thread to remove parents of 20241225133523.4034820-1-quic_depengs@quicinc.com
>>> Checking for older revisions
>>> Grabbing search results from lore.kernel.org
>>> Added from v6: 1 patches
>>> ---
>>> Analyzing 217 messages in the thread
>>> Could not find lower series to compare against.
>>>
>>> I am not going to perform review, maybe other maintaners have spare
>>> time to deal with this submission process.
>>
>> Really sorry, I made a foolish mistake. I didn't realize that the patch
>> subject was missing the version number, which might be why the b4 diff
>> couldn't detect the old series. Thank you for pointing out this error.
>> Could you please advise whether I should resend v7 or fix it in next
>> version series?
>
> I marked this series as 'Changes Requested' in our media patchwork because
> of this issue.
>
> So resend it as v8 with the proper [PATCH v8 ...] subject.
>
Thanks for the comments, I will follow your guidance to resend it.
> It's a nightmare for maintainers/reviewers if it isn't clear if a patch series
> supersedes a previous series, so it is important that you do this right.
>
> Regards,
>
> Hans
>
>>
>> I have also found a workaround to replace "b4 diff". Last time, you
>> helped by giving a RB tag on the version 4 dt-binding. You can check the
>> differences[1] between version 4 and version 7 on the Patchew website.
>> If possible, could you please help review the diff provided by Patchew
>> once again? Sorry for wasting your time.
>>
>> Visit below website[1], then search "dt-bindings: media: camss: Add
>> qcom,sm8550-camss binding", then we can get the difference between
>> version4 and version7.
>>
>>
>> [1]
>> https://patchew.org/linux/20240812144131.369378-1-quic._5Fdepengs@quicinc.com/diff/20241225133523.4034820-1-quic._5Fdepengs@quicinc.com/
>>
>>
Thanks,
Depeng
next prev parent reply other threads:[~2025-01-07 12:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 13:35 [PATCH v7 00/16] media: qcom: camss: Add sm8550 support Depeng Shao
2024-12-25 13:35 ` [PATCH 01/16] media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in defines Depeng Shao
2024-12-25 13:35 ` [PATCH 02/16] media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence control loop Depeng Shao
2024-12-25 13:35 ` [PATCH 03/16] media: qcom: camss: csiphy-3ph: Rename struct Depeng Shao
2024-12-25 13:35 ` [PATCH 04/16] media: qcom: camss: csiphy: Add an init callback to CSI PHY devices Depeng Shao
2024-12-25 13:35 ` [PATCH 05/16] media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field inside csiphy struct Depeng Shao
2024-12-25 13:35 ` [PATCH 06/16] media: qcom: camss: csiphy-3ph: Use an offset variable to find common control regs Depeng Shao
2024-12-25 13:35 ` [PATCH 07/16] media: qcom: camss: csid: Move common code into csid core Depeng Shao
2024-12-25 13:35 ` [PATCH 08/16] media: qcom: camss: vfe: Move common code into vfe core Depeng Shao
2024-12-25 13:35 ` [PATCH 09/16] media: qcom: camss: Add callback API for RUP update and buf done Depeng Shao
2024-12-25 13:35 ` [PATCH 10/16] media: qcom: camss: Add default case in vfe_src_pad_code Depeng Shao
2024-12-25 13:35 ` [PATCH 11/16] media: qcom: camss: csid: Only add TPG v4l2 ctrl if TPG hardware is available Depeng Shao
2024-12-25 13:35 ` [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-12-27 9:10 ` Krzysztof Kozlowski
2025-01-04 13:40 ` Depeng Shao
2025-01-06 14:00 ` Hans Verkuil
2025-01-07 12:47 ` Depeng Shao [this message]
2024-12-25 13:35 ` [PATCH 13/16] media: qcom: camss: Add sm8550 compatible Depeng Shao
2024-12-25 13:35 ` [PATCH 14/16] media: qcom: camss: csiphy-3ph: Add Gen2 v2.1.2 two-phase MIPI CSI-2 DPHY support Depeng Shao
2024-12-25 13:35 ` [PATCH 15/16] media: qcom: camss: Add CSID 780 support Depeng Shao
2024-12-25 13:35 ` [PATCH 16/16] media: qcom: camss: Add support for VFE 780 Depeng Shao
-- strict thread matches above, loose matches on Subject: below --
2024-12-11 14:07 [PATCH v6 00/16] media: qcom: camss: Add sm8550 support Depeng Shao
2024-12-11 14:07 ` [PATCH 12/16] dt-bindings: media: camss: Add qcom,sm8550-camss binding Depeng Shao
2024-12-11 15:17 ` Bryan O'Donoghue
2024-12-12 13:39 ` Depeng Shao
2024-12-12 14:04 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd61c298-f271-4e21-b1e1-dee1029e978d@quicinc.com \
--to=quic_depengs@quicinc.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_eberman@quicinc.com \
--cc=quic_yon@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).