* [PATCH 0/5] arm64: dts: qcom: Few dtc W=1 warning fixes
From: Krzysztof Kozlowski @ 2026-04-04 9:50 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Dmitry Baryshkov, Abel Vesa, Wesley Cheng,
Maulik Shah, Qiang Yu, Taniya Das, Pankaj Patil,
Jyothi Kumar Seerapu, Dmitry Baryshkov, Varadarajan Narayanan,
Bryan O'Donoghue
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Raviteja Laggyshetty, Kamal Wadhwa, Jishnu Prakash,
Krzysztof Kozlowski
Not marking stable as these do not have actual impact on user, but still
warnings are not desired.
Best regards,
Krzysztof
---
Krzysztof Kozlowski (5):
arm64: dts: qcom: glymur: Fix USB simple_bus_reg warning
arm64: dts: qcom: glymur: Fix cache and SRAM simple_bus_reg warnings
arm64: dts: qcom: glymur: Fix USB simple_bus_reg warnings
arm64: dts: qcom: sc8180x: Fix phy simple_bus_reg warning
arm64: dts: qcom: sdm845-mezzanine: Fix camss ports unit_address_vs_reg warning
arch/arm64/boot/dts/qcom/glymur.dtsi | 6 +++---
arch/arm64/boot/dts/qcom/ipq5424.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sdm845-db845c-navigation-mezzanine.dtso | 5 +++++
4 files changed, 11 insertions(+), 6 deletions(-)
---
base-commit: 36ece9697e89016181e5ae87510e40fb31d86f2b
change-id: 20260404-dts-qcom-w-1-fixes-1a25bbd0519a
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
^ permalink raw reply
* [PATCH 4/5] dt-bindings: arm: qcom: document QCS8550 RB5Gen2 board
From: Joe Sandom via B4 Relay @ 2026-04-04 9:50 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joe Sandom
In-Reply-To: <20260404-rb5gen2-dts-v1-0-895f8fc494fc@axon.com>
From: Joe Sandom <jsandom@axon.com>
Document the Qualcomm RB5gen2 from Thundercomm based on the
QCS8550 chipset from Qualcomm.
[1] https://www.thundercomm.com/product/qualcomm-rb5-gen-2-development-kit/
Signed-off-by: Joe Sandom <jsandom@axon.com>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 1335a7bee397c46e8dc62806091531e32b7327d4..f9f8001e3e6b66e3a926255bdb15363f4c7c2b66 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1093,6 +1093,12 @@ properties:
- const: qcom,qcs8550
- const: qcom,sm8550
+ - items:
+ - enum:
+ - qcom,qcs8550-rb5gen2
+ - const: qcom,qcs8550
+ - const: qcom,sm8550
+
- items:
- enum:
- ayaneo,pocket-s2
--
2.34.1
^ permalink raw reply related
* [PATCH 3/5] arm64: dts: qcom: sm8550-qrd: update PCIe port label reference
From: Joe Sandom via B4 Relay @ 2026-04-04 9:50 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joe Sandom
In-Reply-To: <20260404-rb5gen2-dts-v1-0-895f8fc494fc@axon.com>
From: Joe Sandom <jsandom@axon.com>
Update the pcieport0 reference to pcie0_port0 to match the label
rename in sm8550.dtsi.
Signed-off-by: Joe Sandom <jsandom@axon.com>
---
arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index 2fb2e0be5e4c6b597f20f332cdf063daa2664205..cf63109ff7bf7b6fc827f108e22e82b8b04273c1 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -912,7 +912,7 @@ &pcie0 {
status = "okay";
};
-&pcieport0 {
+&pcie0_port0 {
wifi@0 {
compatible = "pci17cb,1107";
reg = <0x10000 0x0 0x0 0x0 0x0>;
--
2.34.1
^ permalink raw reply related
* [PATCH 0/5] arm64: dts: qcom: add QCS8550 RB5Gen2 support
From: Joe Sandom via B4 Relay @ 2026-04-04 9:50 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joe Sandom
This series adds device tree support for the Thundercomm RB5Gen2
development kit, based on the Qualcomm QCS8550 chipset.
Patches 1-3 prepare the SM8550 device tree by adding MHI register regions
and port labels to the PCIe controller nodes, then update the existing
HDK and QRD board files to match the renamed labels.
Patches 4-5 add the dt-bindings documentation and the board device tree
for the RB5Gen2. This initial submission covers the main board; the vision
mezzanine will be supported in a follow-up series.
Product page:
https://www.thundercomm.com/product/qualcomm-rb5-gen-2-development-kit
Signed-off-by: Joe Sandom <jsandom@axon.com>
---
Joe Sandom (5):
arm64: dts: qcom: sm8550: add PCIe MHI register regions and port labels
arm64: dts: qcom: sm8550-hdk: update PCIe port label reference
arm64: dts: qcom: sm8550-qrd: update PCIe port label reference
dt-bindings: arm: qcom: document QCS8550 RB5Gen2 board
arm64: dts: qcom: qcs8550: add QCS8550 RB5Gen2 board support
Documentation/devicetree/bindings/arm/qcom.yaml | 6 +
arch/arm64/boot/dts/qcom/Makefile | 1 +
arch/arm64/boot/dts/qcom/qcs8550-rb5gen2.dts | 1610 +++++++++++++++++++++++
arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 +-
arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 +-
arch/arm64/boot/dts/qcom/sm8550.dtsi | 14 +-
6 files changed, 1627 insertions(+), 8 deletions(-)
---
base-commit: af241225893ac4933bb8f0615f2dfda8ea2326ce
change-id: 20260404-rb5gen2-dts-180cde0b716c
Best regards,
--
Joe Sandom <jsandom@axon.com>
^ permalink raw reply
* [PATCH 1/5] arm64: dts: qcom: sm8550: add PCIe MHI register regions and port labels
From: Joe Sandom via B4 Relay @ 2026-04-04 9:50 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joe Sandom
In-Reply-To: <20260404-rb5gen2-dts-v1-0-895f8fc494fc@axon.com>
From: Joe Sandom <jsandom@axon.com>
Add the MHI register regions to the pcie0 and pcie1 controller nodes
so that the MHI bus layer can access controller registers directly.
Also add labels to the root port nodes (pcie0_port0, pcie1_port0) to
allow board DTS files to reference them for adding endpoint devices
to each pcie root port.
Signed-off-by: Joe Sandom <jsandom@axon.com>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 912525e9bca6f5e1cbb8887ee0bf9e39650dc4ff..d4caf4d00832d7f1e8f65bf2bc873cddadc42168 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1964,8 +1964,9 @@ pcie0: pcie@1c00000 {
<0 0x60000000 0 0xf1d>,
<0 0x60000f20 0 0xa8>,
<0 0x60001000 0 0x1000>,
- <0 0x60100000 0 0x100000>;
- reg-names = "parf", "dbi", "elbi", "atu", "config";
+ <0 0x60100000 0 0x100000>,
+ <0 0x01C03000 0 0x1000>;
+ reg-names = "parf", "dbi", "elbi", "atu", "config", "mhi";
#address-cells = <3>;
#size-cells = <2>;
ranges = <0x01000000 0x0 0x00000000 0x0 0x60200000 0x0 0x100000>,
@@ -2092,7 +2093,7 @@ opp-16000000-3 {
};
};
- pcieport0: pcie@0 {
+ pcie0_port0: pcie@0 {
device_type = "pci";
reg = <0x0 0x0 0x0 0x0 0x0>;
bus-range = <0x01 0xff>;
@@ -2138,8 +2139,9 @@ pcie1: pcie@1c08000 {
<0x0 0x40000000 0x0 0xf1d>,
<0x0 0x40000f20 0x0 0xa8>,
<0x0 0x40001000 0x0 0x1000>,
- <0x0 0x40100000 0x0 0x100000>;
- reg-names = "parf", "dbi", "elbi", "atu", "config";
+ <0x0 0x40100000 0x0 0x100000>,
+ <0x0 0x01C0B000 0x0 0x1000>;
+ reg-names = "parf", "dbi", "elbi", "atu", "config", "mhi";
#address-cells = <3>;
#size-cells = <2>;
ranges = <0x01000000 0x0 0x00000000 0x0 0x40200000 0x0 0x100000>,
@@ -2288,7 +2290,7 @@ opp-32000000-4 {
};
};
- pcie@0 {
+ pcie1_port0: pcie@0 {
device_type = "pci";
reg = <0x0 0x0 0x0 0x0 0x0>;
bus-range = <0x01 0xff>;
--
2.34.1
^ permalink raw reply related
* [PATCH 2/5] arm64: dts: qcom: sm8550-hdk: update PCIe port label reference
From: Joe Sandom via B4 Relay @ 2026-04-04 9:50 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Joe Sandom
In-Reply-To: <20260404-rb5gen2-dts-v1-0-895f8fc494fc@axon.com>
From: Joe Sandom <jsandom@axon.com>
Update the pcieport0 reference to pcie0_port0 to match the label
rename in sm8550.dtsi.
Signed-off-by: Joe Sandom <jsandom@axon.com>
---
arch/arm64/boot/dts/qcom/sm8550-hdk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
index ee13e6136a8259d28540e718851e094f74ead278..e821b731bdc496c872703723df02ae9b9b0233b5 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
@@ -1012,7 +1012,7 @@ &pcie0 {
status = "okay";
};
-&pcieport0 {
+&pcie0_port0 {
wifi@0 {
compatible = "pci17cb,1107";
reg = <0x10000 0x0 0x0 0x0 0x0>;
--
2.34.1
^ permalink raw reply related
* Re: [PATCH v2] dt-bindings: gpio: cavium,thunder-8890: Convert to DT schema
From: ShiHao @ 2026-04-04 8:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: brgl, robh, krzk+dt, conor+dt, rric, linux-gpio, devicetree,
linux-kernel, i.shihao.999
In-Reply-To: <20260331-invisible-certain-albatross-844cff@quoll>
On Tue, Mar 31, 2026 at 09:30:56AM +0200, Krzysztof Kozlowski wrote:
>
> This binding is odd and not used, so you should follow guidelines I gave
> more than a year ago and updated recently and NOT convert it.
>
> Or rather answer - why this cannot be removed instead? What is the
> benefit of this binding? Is any other project using it?
>
>
> Best regards,
> Krzysztof
>
Indeed this binding has no active user and i think it is good to be removed
entirely because no driver no dts sources are using it , it seems abandoned.
Please let me know if I need to resend it if it needs to be removed.Thanks
for your time.
Best regards,
Seihae no driver no dts sources are using it , it seens abandoned.
Please let me know if i need to resend it if it neeeds to be removed.Thanks
for your time.
^ permalink raw reply
* Re: [PATCH v5 3/5] dt-bindings: soc: sophgo: add sg2000 plic and clint documentation
From: Krzysztof Kozlowski @ 2026-04-04 8:10 UTC (permalink / raw)
To: Joshua Milas
Cc: tglx, robh, krzk+dt, conor+dt, pjw, samuel.holland, unicorn_wang,
inochiama, daniel.lezcano, palmer, aou, alex, liujingqi,
alexander.sverdlin, rabenda.cn, dlan, chao.wei, anup,
linux-kernel, devicetree, linux-riscv, sophgo, hanguidong02,
michael.opdenacker
In-Reply-To: <20260403111516.379795-4-josh.milas@gmail.com>
On Fri, Apr 03, 2026 at 07:15:14AM -0400, Joshua Milas wrote:
> Document the compatible strings for the sg2000 interrupt
> controller and timer.
>
> Signed-off-by: Joshua Milas <josh.milas@gmail.com>
> ---
> .../bindings/interrupt-controller/sifive,plic-1.0.0.yaml | 1 +
> Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 +
> 2 files changed, 2 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v5 1/5] dt-bindings: soc: sophgo: add Milk-V Duo S board compatibles
From: Krzysztof Kozlowski @ 2026-04-04 8:05 UTC (permalink / raw)
To: Joshua Milas
Cc: tglx, robh, krzk+dt, conor+dt, pjw, samuel.holland, unicorn_wang,
inochiama, daniel.lezcano, palmer, aou, alex, liujingqi,
alexander.sverdlin, rabenda.cn, dlan, chao.wei, anup,
linux-kernel, devicetree, linux-riscv, sophgo, hanguidong02,
michael.opdenacker
In-Reply-To: <20260403111516.379795-2-josh.milas@gmail.com>
On Fri, Apr 03, 2026 at 07:15:12AM -0400, Joshua Milas wrote:
> Document the compatible strings for the Milk-V Duo S board [1]
> which uses the SOPHGO SG2000 SoC.
>
> Link: https://milkv.io/duo-s [1]
>
> Signed-off-by: Joshua Milas <josh.milas@gmail.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v7 1/2] dt-bindings: usb: Add Genesys Logic GL3590 hub
From: Krzysztof Kozlowski @ 2026-04-04 7:06 UTC (permalink / raw)
To: Swati Agarwal
Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Icenowy Zheng, Matthias Kaehlcke, Alexey Charkov,
Dmitry Baryshkov, Mike Looijmans, Pin-yen Lin,
J . Neuschäfer, Chaoyi Chen, Krzysztof Kozlowski, linux-usb,
devicetree, linux-kernel
In-Reply-To: <20260403100435.3477729-2-swati.agarwal@oss.qualcomm.com>
On Fri, Apr 03, 2026 at 03:34:34PM +0530, Swati Agarwal wrote:
> Add the binding for the USB3.2 Genesys Logic GL3590 hub.
> GL3590 hub requires 1.2V and 3.3V supplies for operation.
>
> Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
> ---
> .../bindings/usb/genesys,gl850g.yaml | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v12 1/2] dt-bindings: hwmon: add support for MCP998X
From: Krzysztof Kozlowski @ 2026-04-04 7:04 UTC (permalink / raw)
To: Victor Duicu
Cc: Guenter Roeck, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Jonathan Corbet, linux-hwmon, devicetree, linux-kernel, linux-doc,
marius.cristea
In-Reply-To: <20260403-add-mcp9982-hwmon-v12-1-b3bfb26ff136@microchip.com>
On Fri, Apr 03, 2026 at 04:32:16PM +0300, Victor Duicu wrote:
> Add devicetree schema for Microchip MCP998X/33 and MCP998XD/33D
> Multichannel Automotive Temperature Monitor Family.
>
> Signed-off-by: Victor Duicu <victor.duicu@microchip.com>
> ---
> .../bindings/hwmon/microchip,mcp9982.yaml | 237 +++++++++++++++++++++
> MAINTAINERS | 6 +
> 2 files changed, 243 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH ath-next v4 0/6] wifi: ath12k: Enable IPQ5424 AHB WiFi device
From: Krzysztof Kozlowski @ 2026-04-04 5:23 UTC (permalink / raw)
To: Baochen Qiang, Raj Kumar Bhagat, Johannes Berg, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Jeff Johnson
Cc: linux-wireless, devicetree, linux-kernel, ath12k,
Saravanakumar Duraisamy, Sowmiya Sree Elavalagan
In-Reply-To: <5a606f7d-6665-4b0c-bbbe-32538b2315b6@oss.qualcomm.com>
On 03/04/2026 11:13, Baochen Qiang wrote:
>>
>> .../bindings/net/wireless/qcom,ipq5332-wifi.yaml | 1 +
>> drivers/net/wireless/ath/ath12k/ahb.c | 36 +++++----
>> drivers/net/wireless/ath/ath12k/ahb.h | 1 +
>> drivers/net/wireless/ath/ath12k/ce.h | 13 ++-
>> drivers/net/wireless/ath/ath12k/core.h | 1 +
>> drivers/net/wireless/ath/ath12k/wifi7/ahb.c | 8 ++
>> drivers/net/wireless/ath/ath12k/wifi7/hal.c | 7 ++
>> drivers/net/wireless/ath/ath12k/wifi7/hal.h | 3 +
>> .../net/wireless/ath/ath12k/wifi7/hal_qcn9274.c | 88 ++++++++++++++++++++
>> .../net/wireless/ath/ath12k/wifi7/hal_qcn9274.h | 1 +
>> drivers/net/wireless/ath/ath12k/wifi7/hw.c | 93 +++++++++++++++++++++-
>> 11 files changed, 231 insertions(+), 21 deletions(-)
>> ---
>> base-commit: 15551ababf6d4e857f2101366a0c3eaa86dd822c
>> change-id: 20260331-ath12k-ipq5424-cddb63a46a97
>>
>
> only nit in patch 2/6, so for patches 2-6/6:
>
> Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
It does not work like this. Replying to cover letter causes that all
patches will get it. Provide detailed review and response to each email
in such case.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH v2 1/4] dt-bindings: sound: Add ti,tas675x
From: Krzysztof Kozlowski @ 2026-04-04 5:20 UTC (permalink / raw)
To: Sen Wang
Cc: linux-sound, broonie, lgirdwood, robh, krzk+dt, conor+dt,
devicetree, perex, tiwai, shenghao-ding, kevin-lu, baojun.xu,
niranjan.hy, l-badrinarayanan, devarsht, v-singh1, linux-kernel
In-Reply-To: <0a73ae00-5d57-4701-88dc-9a861d44a2c5@ti.com>
On 04/04/2026 05:40, Sen Wang wrote:
> On 4/3/26 02:19, Krzysztof Kozlowski wrote:
>> On 03/04/2026 02:40, Sen Wang wrote:
>>>>> diff --git a/Documentation/devicetree/bindings/sound/ti,tas675x.yaml b/Documentation/devicetree/bindings/sound/ti,tas675x.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..23e4cc77b4ae
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/sound/ti,tas675x.yaml
>>>>> @@ -0,0 +1,278 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/sound/ti,tas675x.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Texas Instruments TAS675x Audio Amplifier
>>>>> +
>>>>> +maintainers:
>>>>> + - Sen Wang <sen@ti.com>
>>>>> +
>>>>> +description: |
>>>>
>>>> Do not need '|' unless you need to preserve formatting.
>>>>
>>>>> + The TAS675x family (TAS6754, TAS67524) are four-channel, digital-input,
>>>>
>>>> And devices are not compatible?
>>>>
>>>
>>> They're compatible, and I didn't have any differentiators for this
>>> initial driver. So I should only keep one.
>>> And also rename ti,tas675x.yaml to ti,tas67524.yaml.
>>
>> No, you should express compatibility. See writing bindings, writing
>> schema, example schema docs or DTS101 talk.
>>
>
> Thank you for clarifying Krzysztof, DTS101 talk is immensely helpful.
>
> Regarding the compatibles, if I use ti,tas67524 as a fallback:
>
> compatible:
> oneOf:
> - items:
> - enum:
> - ti,tas6754
> - const: ti,tas67524
> - const: ti,tas67524
>
> Does this look correct? I've also seen some bindings use 'enum' even for
> single values under oneOf, but I'm assuming 'const' is preferred for
> single entries as advocated in the example schema?
Concept is correct. You have incomplete indentation, but this will be
pointed out by yamllint during dt_binding_check, so be sure that
yamlling and dtschema Python packages are installed.
Best regards,
Krzysztof
^ permalink raw reply
* Re: [PATCH] arm64: dts: qcom: sm8750: Enable cpufreq cooling devices
From: Gaurav Kohli @ 2026-04-04 3:46 UTC (permalink / raw)
To: Dmitry Baryshkov, aastha.pandey
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
In-Reply-To: <ybptzcfs45xn2tkjm4vzxm4y56bh5m6yuzvzhagoifdycrqgdh@hzvad3pg3dcm>
On 4/4/2026 1:34 AM, Dmitry Baryshkov wrote:
> On Fri, Apr 03, 2026 at 05:26:33PM +0530, Aastha Pandey via B4 Relay wrote:
>> From: Aastha Pandey <aastha.pandey@oss.qualcomm.com>
>>
>> Add cooling-cells property to the CPU nodes to support cpufreq
>> cooling devices.
>>
>> Signed-off-by: Aastha Pandey <aastha.pandey@oss.qualcomm.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm8750.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
>
thanks for raising this patch, looks good:
Reviewed-by: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>
^ permalink raw reply
* [PATCH 2/2] dt-bindings: display: simple: Move Innolux G156HCE-L01 panel to dual-link
From: Marek Vasut @ 2026-04-04 3:42 UTC (permalink / raw)
To: devicetree
Cc: Marek Vasut, Conor Dooley, David Airlie, Jessica Zhang,
Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Rob Herring, Sam Ravnborg, Simona Vetter,
Thierry Reding, Thomas Zimmermann, dri-devel, linux-kernel
In-Reply-To: <20260404034321.341210-1-marex@nabladev.com>
The Innolux G156HCE-L01 15.6" 1920x1080 24bpp dual-link LVDS TFT panel
is exactly that, dual-link LVDS panel. Move it into the correct schema,
which is panel-simple-lvds-dual-ports.yaml.
Fixes: 3c5e8aa44dfc ("dt-bindings: display: simple: Add Innolux G156HCE-L01 panel")
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Jessica Zhang <jesszhan0024@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
.../bindings/display/panel/panel-simple-lvds-dual-ports.yaml | 2 ++
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
index 2215bc10bd67c..8a2f6feafd375 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
@@ -44,6 +44,8 @@ properties:
- auo,t215hvn01
# BOE AV123Z7M-N17 12.3" (1920x720) LVDS TFT LCD panel
- boe,av123z7m-n17
+ # InnoLux 15.6" FHD (1920x1080) TFT LCD panel
+ - innolux,g156hce-l01
# Kaohsiung Opto-Electronics Inc. 10.1" WUXGA (1920 x 1200) LVDS TFT LCD panel
- koe,tx26d202vm0bwa
# Lincoln Technology Solutions, LCD185-101CT 10.1" TFT 1920x1200
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index eec78daf946cc..1abdc8698a865 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -178,8 +178,6 @@ properties:
- innolux,g121xce-l01
# InnoLux 15.0" G150XGE-L05 XGA (1024x768) TFT LCD panel
- innolux,g150xge-l05
- # InnoLux 15.6" FHD (1920x1080) TFT LCD panel
- - innolux,g156hce-l01
# InnoLux 13.3" FHD (1920x1080) TFT LCD panel
- innolux,n133hse-ea1
# InnoLux 15.6" WXGA TFT LCD panel
--
2.53.0
^ permalink raw reply related
* [PATCH 1/2] dt-bindings: display: simple: Move AUO 21.5" FHD to dual-link
From: Marek Vasut @ 2026-04-04 3:42 UTC (permalink / raw)
To: devicetree
Cc: Marek Vasut, Conor Dooley, David Airlie, Jessica Zhang,
Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Rob Herring, Sam Ravnborg, Simona Vetter,
Thierry Reding, Thomas Zimmermann, dri-devel, linux-kernel
AU Optronics Corporation 21.5" FHD (1920x1080) color TFT LCD panel
is a dual-link LVDS panel. Move it into the correct schema, which is
panel-simple-lvds-dual-ports.yaml.
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Jessica Zhang <jesszhan0024@gmail.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liu Ying <victor.liu@nxp.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
.../bindings/display/panel/panel-simple-lvds-dual-ports.yaml | 2 ++
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 --
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
index 548f5ac14500a..2215bc10bd67c 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
@@ -40,6 +40,8 @@ properties:
- auo,g185han01
# AU Optronics Corporation 19.0" (1280x1024) TFT LCD panel
- auo,g190ean01
+ # AU Optronics Corporation 21.5" FHD (1920x1080) color TFT LCD panel
+ - auo,t215hvn01
# BOE AV123Z7M-N17 12.3" (1920x720) LVDS TFT LCD panel
- boe,av123z7m-n17
# Kaohsiung Opto-Electronics Inc. 10.1" WUXGA (1920 x 1200) LVDS TFT LCD panel
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 9b8fa03f7cbc4..eec78daf946cc 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -61,8 +61,6 @@ properties:
- auo,p238han01
# AU Optronics Corporation 31.5" FHD (1920x1080) TFT LCD panel
- auo,p320hvn03
- # AU Optronics Corporation 21.5" FHD (1920x1080) color TFT LCD panel
- - auo,t215hvn01
# Shanghai AVIC Optoelectronics 7" 1024x600 color TFT-LCD panel
- avic,tm070ddh03
# BOE AV101HDT-a10 10.1" 1280x720 LVDS panel
--
2.53.0
^ permalink raw reply related
* [PATCH] dt-bindings: display: bridge: lt9211: Require data-lanes on DSI input ports
From: Marek Vasut @ 2026-04-04 3:40 UTC (permalink / raw)
To: devicetree
Cc: Marek Vasut, Andrzej Hajda, Conor Dooley, David Airlie,
Jernej Skrabec, Jonas Karlman, Krzysztof Kozlowski,
Laurent Pinchart, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Rob Herring, Robert Foss, Simona Vetter,
Thomas Zimmermann, dri-devel, linux-kernel
The Lontium LT9211 is capable of 1..4 DSI lanes per input DSI port,
describe the lane count for each input port in the schema.
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Simona Vetter <simona@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org
---
NOTE: For example Linux kernel driver does already use that information
and fails to probe if it is missing. There are currently no intree
users for this binding, so no new warnings will be generated once
this is applied, but a new user is about to be added.
---
.../display/bridge/lontium,lt9211.yaml | 37 ++++++++++++++++++-
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml
index 9a6e9b25d14a9..5264fb2b68b78 100644
--- a/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt9211.yaml
@@ -36,18 +36,50 @@ properties:
properties:
port@0:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description:
Primary MIPI DSI port-1 for MIPI input or
LVDS port-1 for LVDS input or DPI input.
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ description: array of physical DSI data lane indexes.
+ minItems: 1
+ items:
+ - const: 1
+ - const: 2
+ - const: 3
+ - const: 4
+
port@1:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
+ unevaluatedProperties: false
description:
Additional MIPI port-2 for MIPI input or LVDS port-2
for LVDS input. Used in combination with primary
port-1 to drive higher resolution displays
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-lanes:
+ description: array of physical DSI data lane indexes.
+ minItems: 1
+ items:
+ - const: 1
+ - const: 2
+ - const: 3
+ - const: 4
+
port@2:
$ref: /schemas/graph.yaml#/properties/port
description:
@@ -99,6 +131,7 @@ examples:
reg = <0>;
endpoint {
+ data-lanes = <1 2 3 4>;
remote-endpoint = <&dsi0_out>;
};
};
--
2.53.0
^ permalink raw reply related
* Re: [PATCH v2 1/4] dt-bindings: sound: Add ti,tas675x
From: Sen Wang @ 2026-04-04 3:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-sound, broonie, lgirdwood, robh, krzk+dt, conor+dt,
devicetree, perex, tiwai, shenghao-ding, kevin-lu, baojun.xu,
niranjan.hy, l-badrinarayanan, devarsht, v-singh1, linux-kernel
In-Reply-To: <02517021-74cc-4023-98f2-fc7a485b2d2f@kernel.org>
On 4/3/26 02:19, Krzysztof Kozlowski wrote:
> On 03/04/2026 02:40, Sen Wang wrote:
>>>> diff --git a/Documentation/devicetree/bindings/sound/ti,tas675x.yaml b/Documentation/devicetree/bindings/sound/ti,tas675x.yaml
>>>> new file mode 100644
>>>> index 000000000000..23e4cc77b4ae
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/sound/ti,tas675x.yaml
>>>> @@ -0,0 +1,278 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/sound/ti,tas675x.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Texas Instruments TAS675x Audio Amplifier
>>>> +
>>>> +maintainers:
>>>> + - Sen Wang <sen@ti.com>
>>>> +
>>>> +description: |
>>>
>>> Do not need '|' unless you need to preserve formatting.
>>>
>>>> + The TAS675x family (TAS6754, TAS67524) are four-channel, digital-input,
>>>
>>> And devices are not compatible?
>>>
>>
>> They're compatible, and I didn't have any differentiators for this
>> initial driver. So I should only keep one.
>> And also rename ti,tas675x.yaml to ti,tas67524.yaml.
>
> No, you should express compatibility. See writing bindings, writing
> schema, example schema docs or DTS101 talk.
>
Thank you for clarifying Krzysztof, DTS101 talk is immensely helpful.
Regarding the compatibles, if I use ti,tas67524 as a fallback:
compatible:
oneOf:
- items:
- enum:
- ti,tas6754
- const: ti,tas67524
- const: ti,tas67524
Does this look correct? I've also seen some bindings use 'enum' even for
single values under oneOf, but I'm assuming 'const' is preferred for
single entries as advocated in the example schema?
Also, my apologies for the premature v3 series; Sorry for the noise.
Lesson learned and will only send a proper v4 once all discussions are
settled.
Best Regards,
Sen Wang
>
> Best regards,
> Krzysztof
^ permalink raw reply
* [PATCH] ASoC: dt-bindings: ti,tas2552: Add sound-dai-cells
From: Marek Vasut @ 2026-04-04 3:36 UTC (permalink / raw)
To: devicetree
Cc: Marek Vasut, Baojun Xu, Conor Dooley, Kevin Lu,
Krzysztof Kozlowski, Liam Girdwood, Mark Brown, Rob Herring,
Shenghao Ding, linux-kernel, linux-sound
Add missing sound-sai-cells for this codec into schema.
At the same time, drop trailing spaces from description.
Fixes: 506e0825a4c9 ("ASoC: dt-bindings: Convert ti,tas2552 to DT schema")
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Baojun Xu <baojun.xu@ti.com>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Kevin Lu <kevin-lu@ti.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Shenghao Ding <shenghao-ding@ti.com>
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-sound@vger.kernel.org
---
Documentation/devicetree/bindings/sound/ti,tas2552.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/ti,tas2552.yaml b/Documentation/devicetree/bindings/sound/ti,tas2552.yaml
index 10369aa5f0a86..7c7a9e624b898 100644
--- a/Documentation/devicetree/bindings/sound/ti,tas2552.yaml
+++ b/Documentation/devicetree/bindings/sound/ti,tas2552.yaml
@@ -12,8 +12,8 @@ maintainers:
- Baojun Xu <baojun.xu@ti.com>
description: >
- The TAS2552 can receive its reference clock via MCLK, BCLK, IVCLKIN pin or
- use the internal 1.8MHz. This CLKIN is used by the PLL. In addition to PLL,
+ The TAS2552 can receive its reference clock via MCLK, BCLK, IVCLKIN pin or
+ use the internal 1.8MHz. This CLKIN is used by the PLL. In addition to PLL,
the PDM reference clock is also selectable: PLL, IVCLKIN, BCLK or MCLK.
For system integration the dt-bindings/sound/tas2552.h header file provides
@@ -34,6 +34,9 @@ properties:
maxItems: 1
description: gpio pin to enable/disable the device
+ '#sound-dai-cells':
+ const: 0
+
required:
- compatible
- reg
@@ -54,6 +57,7 @@ examples:
audio-codec@41 {
compatible = "ti,tas2552";
reg = <0x41>;
+ #sound-dai-cells = <0>;
vbat-supply = <®_vbat>;
iovdd-supply = <®_iovdd>;
avdd-supply = <®_avdd>;
--
2.53.0
^ permalink raw reply related
* Re: media: iris: enable SM8350 and SC8280XP support
From: Steev Klimaszewski @ 2026-04-04 3:31 UTC (permalink / raw)
To: dmitry.baryshkov
Cc: abhinav.kumar, andersson, bod, bryan.odonoghue, conor+dt, david,
devicetree, dikshita.agarwal, johan+linaro, konrad.dybcio,
konradybcio, krzk+dt, linux-arm-msm, linux-kernel, linux-media,
mchehab, robh, stanimir.varbanov, threeway, vikash.garodia
In-Reply-To: <CAO9ioeUjYrR6fWSxm2DP-AhEMa8ZxSKE5CfQq=s9BhAqWA-5=A@mail.gmail.com>
Hi Bryan, Dmitry, Vikash,
> > > But these logs don't capture, which buffers are causing the IOMMU error.
> >
> > I'd be interested to see if we can run this test on venus - instead of iris.
> At least when I tried testing it, venus wouldn't even boot the
> firmware on SC8280XP, citing UC_REGION error:
> 2026-04-03T01:51:05.376407+03:00 rohan kernel: qcom-venus
> aa00000.video-codec: non legacy binding
> 2026-04-03T01:51:05.437232+03:00 rohan kernel: qcom-venus
> aa00000.video-codec: invalid setting for UC_REGION
> 2026-04-03T01:51:05.437838+03:00 rohan kernel: qcom-venus
> aa00000.video-codec: failed to reset venus core
> 2026-04-03T01:51:05.437850+03:00 rohan kernel: qcom-venus
> aa00000.video-codec: probe with driver qcom-venus failed with error
> -22
The same is observed on the X13s, so venus doesn't load.
> I think it was captured by Steev:
> > This is much better than the previous venus patchset where accessing the
> > hardware decoding would cause the machine to hard reset at least!
Indeed, the older venus patches would simply force the system to hard reset in
EL1, and in EL2 there is a fault (but the system recovers without the hard
reset.)
I do have a further question, isn't the information we need somewhere inside a
TZ managed context bank? Can we even see in there from userspace? I really am
out of my league here, but I'm willing to do any testing needed on the hardware
and I can use b4 with the best of them ;)
-- steev
^ permalink raw reply
* Re: [PATCH v2 2/3] iio: adc: qcom-pm8xxx-xoadc: remove redundant error logging in pm8xxx_read_raw
From: Antony Kurniawan Soemardi @ 2026-04-04 3:26 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Jonathan Cameron, David Lechner, Nuno Sá,
Andy Shevchenko, linux-arm-msm, devicetree, linux-kernel,
linux-iio, phone-devel
In-Reply-To: <35urrjc3koye5zhlxatdsr7t2djuml5ueyhhazcucow3q3g5f2@pomnrrcwu7qr>
On 4/4/2026 4:54 AM, Dmitry Baryshkov wrote:
> Does it also prevent users from spamming the dmesg?
It should be for no such channel case. The only remaining error logs
from pm8xxx_read_raw are timeout errors, which I don’t think would
result in immediate spamming. Or should we remove the dev_err (at
pm8xxx_read_channel_rsv) on timeout errors too?
--
Thanks,
Antony K. S.
^ permalink raw reply
* Re: [PATCH 2/2] PCI: amd-mdb: Add amd,versal2-cpm6-host compatible
From: Manivannan Sadhasivam @ 2026-04-04 3:15 UTC (permalink / raw)
To: Sai Krishna Musham
Cc: bhelgaas, lpieralisi, kw, robh, krzk+dt, conor+dt, cassel,
linux-pci, devicetree, linux-kernel, michal.simek,
bharat.kumar.gogada, thippeswamy.havalige
In-Reply-To: <20260402180006.486229-3-sai.krishna.musham@amd.com>
On Thu, Apr 02, 2026 at 11:30:06PM +0530, Sai Krishna Musham wrote:
> Add "amd,versal2-cpm6-host" to the OF match table of the AMD MDB PCIe
> host controller driver.
>
> The Versal2 CPM6 host controller is DesignWare-based and supports
> PCIe Gen6 operation at up to 64 GT/s per lane. It is currently
> handled by the same driver and match data (NULL) as the existing
> MDB host controller, but CPM6 uses a newer IP revision and differs
> in legacy INTx register offsets.
>
> Use a separate compatible to allow CPM6-specific handling once legacy
> interrupt support is validated.
>
> Signed-off-by: Sai Krishna Musham <sai.krishna.musham@amd.com>
> ---
> drivers/pci/controller/dwc/pcie-amd-mdb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-amd-mdb.c b/drivers/pci/controller/dwc/pcie-amd-mdb.c
> index 3c6e837465bb..325bf7aad657 100644
> --- a/drivers/pci/controller/dwc/pcie-amd-mdb.c
> +++ b/drivers/pci/controller/dwc/pcie-amd-mdb.c
> @@ -511,6 +511,9 @@ static const struct of_device_id amd_mdb_pcie_of_match[] = {
> {
> .compatible = "amd,versal2-mdb-host",
> },
> + {
> + .compatible = "amd,versal2-cpm6-host",
As Krzysztof commented, if the PCIe IP is compatible with an older version,
'amd,versal2-mdb-host' in this case, you don't need to add the new compatible
to the driver. Just document the new one with fallback to the old compatible in
the binding and let the driver work with the old compatible.
- Mani
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply
* Re: [PATCH] of/platform: Don't include reserved memory compatibles that aren't needed
From: Daniel Palmer @ 2026-04-04 2:22 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: robh, saravanak, devicetree, linux-kernel
In-Reply-To: <20260401-rousing-stylish-toucan-44bddf@quoll>
Hi Krzysztof,
On Wed, 1 Apr 2026 at 19:54, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, Apr 01, 2026 at 06:57:35AM +0900, Daniel Palmer wrote:
> > There are a number of very platform specific compatibles for reserved
> > memory that the vast majority of people don't need and they waste
> > 196/200 bytes each.
>
> We don't want #ifdefs in the code because they are more difficult to
> maintain and review. Following your approach we would need to add such
> ifdefs in multiple other places, so I am not convinced it is worth.
I sort of disagree here. At the moment these compatibles are not
coupled to the code that uses them at all.
If that code gets deleted or moved for some reason, the Kconfig symbol
they belong to will disappear but since these compatibles aren't
coupled to them and are in a file on the other side of the kernel
it'll be easy to miss them.
If they are wrapped in something that links them back to where they
are used grep or whatever indexer can spot them.
> And this file should not be having different rules than rest of drivers.
There are other places with #ifdefs in match tables. It would be nice
if there was a nicer way to do it in C but there doesn't seem to be.
It would be nice if vendor specific stuff wasn't in the core code but
I don't see a nice way of fixing that either.
And if you want to see some of the more crazy examples of match tables
take a look here:
https://elixir.bootlin.com/linux/v7.0-rc6/source/drivers/cpufreq/cpufreq-dt-platdev.c
Since these matches are not the size of the compatible string but
actually 200 bytes on 64 bit machines the two megatables in that
driver will consume about 40K. It doesn't seem like much but DT is
being used by systems that have megabytes of RAM like a RISC-V
softcore on an FPGA. I think they might prefer to have a 40K of usable
memory over 40K of tables that don't contain any values that are
actually used on their machine ever... and it could be cleaned up
easily by wrapping each of the vendor specific chunks in the Kconfig
symbol for their platform.
Cheers,
Daniel
^ permalink raw reply
* Re: [PATCH RFC 0/2] clk: scmi: DT support for SCMI clock rate rounding modes (per‑clock policy)
From: Peng Fan @ 2026-04-04 1:53 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sudeep Holla, Cristian Marussi, Brian Masney
Cc: linux-kernel, linux-clk, devicetree, arm-scmi, linux-arm-kernel,
Peng Fan
In-Reply-To: <20260306-scmi-clk-round-v1-0-61e2a5df9051@nxp.com>
Hi All,
On Fri, Mar 06, 2026 at 02:20:11PM +0800, Peng Fan (OSS) wrote:
>The ARM SCMI specification (DEN0056E) defines rounding‑mode flags for the
>CLOCK_RATE_SET command, allowing a client to request that the firmware
>round a requested clock rate down, up, or autonomously choose the
>closest achievable rate.
Would you please give a look and give some feedback?
Thanks,
Peng
>This series introduces DT support in the SCMI clock provider to carry a
>per‑clock rounding policy from the device tree into the SCMI protocol.
>
>Patch 1 adds dt‑bindings constants for rounding modes:
>ROUND_DOWN, ROUND_UP, ROUND_AUTO.
>
>Patch 2 extends the SCMI clock provider to optionally support
>"#clock-cells = <2>", where the second cell encodes the rounding mode.
>The first consumer that references a given clock latches the per‑clock
>policy. Subsequent consumers of the same clock must specify the same
>mode; otherwise, the request is rejected to avoid non‑deterministic
>behavior. The selected mode is passed through to the SCMI Clock protocol
>and mapped to the corresponding CLOCK_SET_* flag.
>
>Patch 2 includes changes to drivers/clk/clk-scmi.c and drivers/firmware
>arm_scmi/clock.c, it is hard to separate the changes without breaking,
>so I put the changes in one patch.
>
>This design adopts a per‑clock policy model, not per‑consumer. The rounding
>mode is applied by the provider per clock (index).
>All consumers of the same clock must agree on the rounding mode.
>Conflicting per‑consumer requests for the same clock are invalid and
>are rejected during phandle translation.
>
>This avoids silent clobbering and preserves deterministic behavior.
>
>Existing device trees using #clock-cells = <1> continue to work and
>default to ROUND_DOWN, exactly as before.
>
>Signed-off-by: Peng Fan <peng.fan@nxp.com>
>---
>Peng Fan (2):
> dt-bindings: clock: Add SCMI clock rounding mode declarations
> clk: scmi: Add support for two #clock-cells to pass rate rounding mode
>
> drivers/clk/clk-scmi.c | 62 +++++++++++++++++++++++++++++++++++++--
> drivers/firmware/arm_scmi/clock.c | 15 ++++++++--
> include/dt-bindings/clock/scmi.h | 13 ++++++++
> include/linux/scmi_protocol.h | 8 ++++-
> 4 files changed, 92 insertions(+), 6 deletions(-)
>---
>base-commit: 3f9cd19e764b782706dbaacc69e502099cb014ba
>change-id: 20260306-scmi-clk-round-1615258cf0fa
>
>Best regards,
>--
>Peng Fan <peng.fan@nxp.com>
>
^ permalink raw reply
* Re: (subset) [PATCH 05/15] dt-bindings: rtc: ingenic,rtc: Use generic power-controller schema
From: Peng Fan @ 2026-04-04 1:33 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Rafael J. Wysocki,
Ulf Hansson, Florian Fainelli,
Broadcom internal kernel review list, Ray Jui, Scott Branden,
Saenz Julienne, Lee Jones, Liam Girdwood, Mark Brown,
Shree Ramamoorthy, Jerome Neanne, Paul Cercueil, Dmitry Osipenko,
Heiko Stuebner, Joseph Chen, Chris Zhong, Zhang Qing,
Sebastian Reichel, Andreas Kemnade, Jonathan Neuschäfer,
Lubomir Rintel, Julien Panis, Matti Vaittinen, Alexander Kurz,
Krzysztof Kozlowski, André Draszik, devicetree, linux-kernel,
linux-rpi-kernel, linux-arm-kernel, linux-rtc, linux-rockchip,
linux-samsung-soc, Peng Fan
In-Reply-To: <177523251875.1559844.9690289848283345069.b4-ty@b4>
Hi Alexandre,
On Fri, Apr 03, 2026 at 06:09:00PM +0200, Alexandre Belloni wrote:
>On Mon, 16 Mar 2026 22:47:40 +0800, Peng Fan (OSS) wrote:
>> Convert the binding to use the generic power-controller schema instead by
>> referencing power-controller.yaml and removing the local
>> `system-power-controller` property definition.
>
>Applied, thanks!
Thanks, but patch [01/15] has not been accepted, so please drop 05/15.
Thanks,
Peng
>
>[05/15] dt-bindings: rtc: ingenic,rtc: Use generic power-controller schema
> https://git.kernel.org/abelloni/c/0452290110cc
>
>Best regards,
>
>--
>Alexandre Belloni, co-owner and COO, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com
>
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox