Re: [PATCH v2 11/14] arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: missing samsung,sysreg in exynos8855-clock DT binding schema
--

commit 66386d316c3e67ff06e1d52fb1215f90cf5a7e17
Author: Raghav Sharma <raghav.s@samsung.com>

arm64: dts: exynos8855: add cmu_top & cmu_peric clock DT nodes

This commit adds the required device tree nodes for the cmu_top and
cmu_peric blocks. It also adds the sysreg_peric node, which contains
the DRCG and MEMCLK SFR bits used in the clock driver.

> diff --git a/arch/arm64/boot/dts/exynos/exynos8855.dtsi b/arch/arm64/boot/dts/exynos/exynos8855.dtsi
> index 0333b80eba845..2e5dc79d66bc7 100644
> --- a/arch/arm64/boot/dts/exynos/exynos8855.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos8855.dtsi
[ ... ]
> @@ -170,12 +171,43 @@ pinctrl_cmgp: pinctrl@12030000 {
[ ... ]
> +		cmu_peric: clock-controller@15400000 {
> +			compatible = "samsung,exynos8855-cmu-peric";
> +			reg = <0x15400000 0x10000>;
> +			#clock-cells = <1>;
> +
> +			clocks = <&oscclk>,
> +				 <&cmu_top CLKCMU_DOUT_PERIC_NOC>,
> +				 <&cmu_top CLKCMU_DOUT_PERIC_MMC_CARD>,
> +				 <&cmu_top CLKCMU_DOUT_PERIC_IP>;
> +			clock-names = "oscclk",
> +				      "bus",
> +				      "mmc_card",
> +				      "ip";
> +			samsung,sysreg = <&sysreg_peric>;

[Severity: Low]
Does this undocumented property cause make dtbs_check validation to fail?

The samsung,sysreg property is assigned here in the cmu_peric device tree
node, but it does not appear to be defined in the corresponding binding schema
Documentation/devicetree/bindings/clock/samsung,exynos8855-clock.yaml.

Since the schema enforces additionalProperties: false, adding an undocumented
property here violates the schema. It also appears follow-up patches in the
series continue to add samsung,sysreg properties for other CMU blocks (e.g.,
sysreg_usb, sysreg_peris) without updating the schema to allow it. Should the
binding schema be updated to define samsung,sysreg?

> +		};
> +
> +		sysreg_peric: syscon@15420000 {
> +			compatible = "samsung,exynos8855-peric-sysreg",
> +				      "syscon";
> +			reg = <0x15420000 0x10000>;
> +			clocks = <&cmu_peric CLK_GOUT_SYSREG_PERIC>;
> +		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261009120137.2801911-1-raghav.s@samsung.com?part=11