Re: [PATCH 2/5] arm64: dts: imx8qxp: Add display controller subsystem

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: Missing power-domains and compatible override for dc0_irqsteer
--

commit ae70e9d2f5935bf44872ed0bd30be554653b06e0
Author: Liu Ying <victor.liu@nxp.com>

arm64: dts: imx8qxp: Add display controller subsystem

Add display controller subsystem in i.MX8qxp SoC.

> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dc0.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dc0.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dc0.dtsi
[ ... ]
> +dc0_subsys: bus@56000000 {
[ ... ]
> +	dc0_irqsteer: interrupt-controller@56000000 {
> +		compatible = "fsl,imx-irqsteer";
> +		reg = <0x56000000 0x1000>;
> +		interrupt-controller;
> +		interrupt-parent = <&gic>;
> +		#interrupt-cells = <1>;
[ ... ]
> +		clocks = <&dc0_lis_lpcg IMX_LPCG_CLK_4>;
> +		clock-names = "ipg";
> +		fsl,channel = <0>;
> +		fsl,num-irqs = <512>;
> +	};

[Severity: Medium]
Is the dc0_irqsteer node missing a power-domains property?

If it lacks power-domains = <&pd IMX_SC_R_DC_0>;, could this trigger a bus
fault (SError) during boot or suspend/resume cycles if the irqsteer driver
accesses its registers when the IMX_SC_R_DC_0 power domain is off?

> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-dc.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp-ss-dc.dtsi
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-dc.dtsi
> @@ -0,0 +1,236 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Copyright 2024 NXP
> + */
> +
> +&dc0 {
> +	compatible = "fsl,imx8qxp-dc";
> +};

[Severity: Medium]
Should there be an override for &dc0_irqsteer in this file to set its
SoC-specific compatible string?

For example, setting compatible = "fsl,imx8qxp-irqsteer", "fsl,imx-irqsteer";
here would ensure the node matches correctly. Omitting the SoC-specific
compatible string might mask the missing power domain violation from
dtbs_check and prevent SoC-specific driver quirks from applying.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013111737.998282-1-alexander.stein@ew.tq-group.com?part=2