Re: [PATCH 1/5] dt-bindings: crypto: add Rambus CryptoManager Hub

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: impossible 'not: {}' compatible constraint and missing examples
--

commit 113cff11f8b766425bbb8e592b3c6da3fc635bbd
Author: Alex Ousherovitch <aousherovitch@rambus.com>

dt-bindings: crypto: add Rambus CryptoManager Hub

Add device tree binding schema for the Rambus CryptoManager Hub (CMH)
hardware crypto accelerator.  The binding describes the parent
SoC-level node with its SIC register region and one queue@N child
node per mailbox the host owns.

> diff --git a/Documentation/devicetree/bindings/crypto/rambus,cmh-v1030.yaml b/Documentation/devicetree/bindings/crypto/rambus,cmh-v1030.yaml
> new file mode 100644
> index 0000000000000..fb05cc636df66
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rambus,cmh-v1030.yaml
> @@ -0,0 +1,144 @@

[ ... ]

> +properties:
> +  compatible:
> +    items:
> +      - not: {}
> +        description: SoC-specific compatible, e.g. vendor,soc-cmh

[Severity: Low]
Will this unconditionally reject all inputs? Since the empty schema {}
matches any value, the not: {} constraint under properties:compatible will
fail validation for any string.

Usually not: {} is used within a oneOf fallback branch to enforce
SoC-specific compatibles, but there are no valid alternatives provided
here.

> +      - const: rambus,cmh-v1030

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - "#address-cells"
> +  - "#size-cells"
> +
> +additionalProperties: false

[Severity: Low]
Is there an examples section missing from the end of this file?

Without an examples section, make dt_binding_check won't instantiate any
examples to validate against the schema. This omission avoids checking the
schema and seems to hide the fact that the not: {} constraint on the
compatible string makes it impossible to validate.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013174847.2192609-1-aousherovitch@rambus.com?part=1