Re: [PATCH 3/5] crypto: cmh - add key/datastore infrastructure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] crypto: cmh: missing implementation for QSE and HCQ VCQ builders
--

commit edeafa889ed6c19c029045fbf5064008f9e6f3d7
Author: Alex Ousherovitch <aousherovitch@rambus.com>

crypto: cmh - add key/datastore infrastructure

This commit adds the CMH key and datastore system object layer shared by
the algorithm drivers. It implements context staging, DMA mapping, and
VCQ builder functions.

> diff --git a/drivers/crypto/cmh/include/cmh_sys.h b/drivers/crypto/cmh/include/cmh_sys.h
> new file mode 100644
> index 0000000000000..47c19e2f72a93
> --- /dev/null
> +++ b/drivers/crypto/cmh/include/cmh_sys.h

[ ... ]

> +/* QSE core VCQ builders */
> +void vcq_add_qse_flush(struct vcq_cmd *slot, u32 core_id);

[Severity: Low]
Are the implementations for the QSE and HCQ VCQ builders missing?
They are declared here in the header, but they do not appear to be implemented
in cmh_sys.c or used anywhere in the current tree.

Since these prototypes constitute dead code right now, should their
declarations be deferred until the patches that introduce the QSE and HCQ
drivers?

> +void vcq_add_qse_ml_kem_keygen(struct vcq_cmd *slot, u32 core_id, u32 k, u32 flags,
> +			       u64 seed, u64 z, u64 ek, u64 dk, u32 dk_type,
> +			       bool masked);

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261013174847.2192609-1-aousherovitch@rambus.com?part=3