Re: [PATCH 06/10] ARM: dts: omap: dm816x: Update USB node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: unit-address does not match the first address in the reg property
--

commit dbd2586a39796c2f0baed5e3349e527c7000f5a0
Author: Andrew Goodbody <andrew.goodbody@linaro.org>

ARM: dts: omap: dm816x: Update USB node

USB node was not working correctly with DMA enabled as the supporting
code had been updated without updating this SoC's device tree. Bring the
device tree more up to date so that it works with DMA enabled.

> diff --git a/arch/arm/boot/dts/ti/omap/dm816x.dtsi b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> index 7f3ef3a00ab86..5be9efc607855 100644
> --- a/arch/arm/boot/dts/ti/omap/dm816x.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/dm816x.dtsi
[ ... ]
> @@ -574,18 +574,27 @@ uart3: serial@48024000 {
[ ... ]
> -			usb0: usb@47401000 {
> +			usb0: usb@1000 {
>  				compatible = "ti,musb-dm816";
> -				reg = <0x47401400 0x400
> -				       0x47401000 0x200>;
> +				reg = <0x1400 0x400>,
> +				      <0x1000 0x200>;

[Severity: Low]
Should the unit address match the first address in the reg property? The unit
address is @1000 but the first reg starts at 0x1400. Should this be usb@1400?

[ ... ]
> @@ -622,10 +631,10 @@ &cppi41dma 11 1 &cppi41dma 12 1
>  					"tx14", "tx15";
>  			};
>  
> -			usb1: usb@47401800 {
> +			usb1: usb@1800 {
>  				compatible = "ti,musb-dm816";
> -				reg = <0x47401c00 0x400
> -				       0x47401800 0x200>;
> +				reg = <0x1c00 0x400>,
> +				      <0x1800 0x200>;

[Severity: Low]
Does this node have a similar mismatch? The unit address is @1800 but the
first reg starts at 0x1c00. Should it be usb@1c00?

[ ... ]
> @@ -662,12 +671,12 @@ &cppi41dma 26 1 &cppi41dma 27 1
>  					"tx14", "tx15";
>  			};
>  
> -			cppi41dma: dma-controller@47402000 {
> +			cppi41dma: dma-controller@2000 {
>  				compatible = "ti,am3359-cppi41";
> -				reg = <0x47400000 0x1000>,
> -				      <0x47402000 0x1000>,
> -				      <0x47403000 0x1000>,
> -				      <0x47404000 0x4000>;
> +				reg =  <0x0000 0x1000>,
> +				       <0x2000 0x1000>,
> +				       <0x3000 0x1000>,
> +				       <0x4000 0x4000>;

[Severity: Low]
Is it expected for the unit address to be @2000 when the first reg starts at
0x0000? Should this be dma-controller@0?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-patch-ektor5-dm8168-dts-v1-0-b4ce30217028@linaro.org?part=6