Re: [PATCH v2 5/5] arm64: dts: exynos: Add initial support for Samsung Galaxy Watch FE

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] arm64: dts: exynos: missing Makefile entry for exynos5515-lucky7.dtb
- [Medium] arm64: dts: exynos: undocumented and unsupported samsung,exynos5515-wdt enabled
--

commit 0d8def366a8d338fb8397be7ac629d0ddc3e5c1d
Author: Aiden Isik <aidenisik@member.fsf.org>

arm64: dts: exynos: Add initial support for Samsung Galaxy Watch FE

This commit adds the initial device tree source for the Samsung Galaxy
Watch FE (SM-R861/SM-R866, codenamed lucky7) based on the Exynos5515 SoC,
with support for memory, reserved memory regions, and the bootloader
framebuffer.

> diff --git a/arch/arm64/boot/dts/exynos/exynos5515-lucky7.dts b/arch/arm64/boot/dts/exynos/exynos5515-lucky7.dts
> new file mode 100644
> index 0000000000000..e80a0f0948cb7
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos5515-lucky7.dts
> @@ -0,0 +1,219 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Samsung Galaxy Watch FE (lucky7/SM-R861/SM-R866) device tree source
> + *
> + * Copyright (c) 2026 Aiden Isik <aidenisik+git@member.fsf.org>
> + */
> +
> +/dts-v1/;
> +#include "exynos5515.dtsi"
> +
> +/ {
> +	compatible = "samsung,lucky7", "samsung,exynos5515";
> +	chassis-type = "watch";
> +	model = "Samsung Galaxy Watch FE (SM-R861/SM-R866)";

[Severity: Medium]
Should arch/arm64/boot/dts/exynos/Makefile also be updated to include
exynos5515-lucky7.dtb under dtb-$(CONFIG_ARCH_EXYNOS):

arch/arm64/boot/dts/exynos/Makefile:
dtb-$(CONFIG_ARCH_EXYNOS) += \
	exynos2200-g0s.dtb		\
	exynos5433-tm2.dtb		\
	exynos5433-tm2e.dtb		\
	exynos7-espresso.dtb		\

Without an entry in arch/arm64/boot/dts/exynos/Makefile,
exynos5515-lucky7.dts will not be compiled into exynos5515-lucky7.dtb during
make dtbs, and both exynos5515-lucky7.dts and exynos5515.dtsi will be
skipped during make dtbs_check schema validation.

[ ... ]

> +&oscclk {
> +	clock-frequency = <26000000>;
> +};
> +
> +&watchdog {
> +	status = "okay";
> +};

[Severity: Medium]
Will enabling the watchdog node here pass dtbs_check or bind to a driver at
runtime?

In arch/arm64/boot/dts/exynos/exynos5515.dtsi, the watchdog node is defined
with no fallback compatible string:

		watchdog: watchdog@10050000 {
			compatible = "samsung,exynos5515-wdt";
			reg = <0x10050000 0x100>;
			clocks = <&cmu_peri CLK_GOUT_PERI_WDT0_PCLK>,
				 <&oscclk>;
			clock-names = "watchdog",
				      "watchdog_src";
			interrupts = <GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>;
			samsung,syscon-phandle = <&pmu_system_controller>;

			status = "disabled";
		};

However, "samsung,exynos5515-wdt" is not documented in
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml, nor is it
present in s3c2410_wdt_match[] in drivers/watchdog/s3c2410_wdt.c:

static const struct of_device_id s3c2410_wdt_match[] = {
	{ .compatible = "google,gs101-wdt",
	  .data = &drv_data_gs101_cl0 },
	{ .compatible = "samsung,s3c6410-wdt",
	  .data = &drv_data_s3c6410 },
	{ .compatible = "samsung,exynos5250-wdt",
	  .data = &drv_data_exynos5250 },
	{ .compatible = "samsung,exynos5420-wdt",
	  .data = &drv_data_exynos5420 },
	{ .compatible = "samsung,exynos7-wdt",
	  .data = &drv_data_exynos7 },
	{ .compatible = "samsung,exynos850-wdt",
	  .data = &drv_data_exynos850_cl0 },

Additionally, if the hardware is compatible with an existing two-clock
variant such as "samsung,exynos850-wdt", both
Documentation/devicetree/bindings/watchdog/samsung-wdt.yaml and
s3c2410_get_wdt_drv_data() in drivers/watchdog/s3c2410_wdt.c require the
samsung,cluster-index property, which is not present in watchdog@10050000.

Should the binding and driver support (or an appropriate fallback compatible
and samsung,cluster-index property) be in place before enabling &watchdog?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019-for-next-lucky7-v2-0-c4ecab4b1c4c@member.fsf.org?part=5