Re: [PATCH v2 1/5] dt-bindings: soc: samsung: exynos-sysreg: Add compatibles for Exynos5515

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dt-bindings: soc: samsung: missing clocks condition for exynos5515 sysreg
--

commit 780d375e416e5c58dedc0e1cdf45e84c270a29e6
Author: Aiden Isik <aidenisik@member.fsf.org>

dt-bindings: soc: samsung: exynos-sysreg: Add compatibles for Exynos5515

This commit adds Exynos5515 sysreg compatible strings for the top, peri,
and fsys blocks to the Samsung Exynos sysreg Device Tree binding schema.

> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index fcdb9ffd26448..c6731a3ea1c47 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -29,6 +29,9 @@ properties:
>                - samsung,exynos3-sysreg
>                - samsung,exynos4-sysreg
>                - samsung,exynos5-sysreg
> +              - samsung,exynos5515-fsys-sysreg
> +              - samsung,exynos5515-peri-sysreg
> +              - samsung,exynos5515-top-sysreg
>                - samsung,exynos7870-cam0-sysreg
>                - samsung,exynos7870-disp-sysreg
>                - samsung,exynos8895-fsys0-sysreg

[Severity: Medium]
Should samsung,exynos5515-fsys-sysreg and samsung,exynos5515-peri-sysreg also
be added to the allOf conditional block that requires clocks?

In include/dt-bindings/clock/samsung,exynos5515-cmu.h and
drivers/clk/samsung/clk-exynos5515.c, CMU_PERI and CMU_FSYS register
dedicated PCLK gate clocks for their respective SYSREG blocks in
peri_gate_clks and fsys_gate_clks:

drivers/clk/samsung/clk-exynos5515.c:
	/* SYSREG */
	GATE(CLK_GOUT_PERI_SYSREG_PCLK, "gout_peri_sysreg_pclk",
	     "mout_pll_peri_bus_user",
	     CLK_CON_GAT_CLK_BLK_PERI_UID_SYSREG_PERI_IPCLKPORT_PCLK,
	     21, 0, 0),
...
	/* SYSREG */
	GATE(CLK_GOUT_FSYS_SYSREG_PCLK, "gout_fsys_sysreg_pclk",
	     "mout_pll_fsys_bus_user",
	     CLK_CON_GAT_GOUT_BLK_FSYS_UID_SYSREG_FSYS_IPCLKPORT_PCLK,
	     21, 0, 0),

However, in Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml,
the allOf block sets clocks: false in the else branch when a compatible
string is not listed in the if enum:

  - if:
      properties:
        compatible:
          contains:
            enum:
              - google,gs101-dpu-sysreg
              ...
              - samsung,exynos990-peric1-sysreg
    then:
      required:
        - clocks
    else:
      properties:
        clocks: false

Without listing samsung,exynos5515-fsys-sysreg and
samsung,exynos5515-peri-sysreg in that enum, won't schema validation reject
Device Tree nodes that specify CLK_GOUT_FSYS_SYSREG_PCLK or
CLK_GOUT_PERI_SYSREG_PCLK, while allowing unclocked nodes where
of_syscon_register() cannot attach the PCLK via regmap_mmio_attach_clk()?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019-for-next-lucky7-v2-0-c4ecab4b1c4c@member.fsf.org?part=1