Re: [PATCH 2/3] arm64: dts: qcom: lemans: Add Draco EVK SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] arm64: dts: qcom: lemans-draco-evk-som: swapped USB QMP PHY supplies
--

commit 8560cf8c07ec29ddb7e6a2feb1b5ebde75e47b48
Author: Gopikishan Thawre <gopikishan.thawre@oss.qualcomm.com>

arm64: dts: qcom: lemans: Add Draco EVK SoM platform

This commit introduces the device tree for the SA8775P/QCS9100-based LeMans
Draco EVK SoM, configuring RPMH regulators, remoteproc instances, UFS, USB,
GPU, and video processing unit nodes.

> diff --git a/arch/arm64/boot/dts/qcom/lemans-draco-evk-som.dtsi b/arch/arm64/boot/dts/qcom/lemans-draco-evk-som.dtsi
> new file mode 100644
> index 0000000000000..6b7971bcdc934
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-draco-evk-som.dtsi
> @@ -0,0 +1,401 @@

[ ... ]

> +&ufs_mem_phy {
> +	vdda-phy-supply = <&vreg_l4a>;
> +	vdda-pll-supply = <&vreg_l1c>;
> +
> +	status = "okay";
> +};
> +
> +&usb_0 {
> +	status = "okay";
> +};
> +
> +&usb_0_hsphy {
> +	vdda-pll-supply = <&vreg_l7a>;
> +	vdda18-supply = <&vreg_l6c>;
> +	vdda33-supply = <&vreg_l9a>;
> +
> +	status = "okay";
> +};
> +
> +&usb_0_qmpphy {
> +	vdda-phy-supply = <&vreg_l1c>;
> +	vdda-pll-supply = <&vreg_l7a>;
> +
> +	status = "okay";
> +};
> +
> +&usb_1 {
> +	dr_mode = "host";
> +
> +	status = "okay";
> +};
> +
> +&usb_1_hsphy {
> +	vdda-pll-supply = <&vreg_l7a>;
> +	vdda18-supply = <&vreg_l6c>;
> +	vdda33-supply = <&vreg_l9a>;
> +
> +	status = "okay";
> +};
> +
> +&usb_1_qmpphy {
> +	vdda-phy-supply = <&vreg_l1c>;
> +	vdda-pll-supply = <&vreg_l7a>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Are vdda-phy-supply and vdda-pll-supply swapped in both usb_0_qmpphy and
usb_1_qmpphy?

Earlier in this file, vreg_l7a is configured as the 0.72V-0.95V rail and
vreg_l1c is configured as the 1.14V-1.26V rail:

    vreg_l7a: ldo7 {
        regulator-name = "vreg_l7a";
        regulator-min-microvolt = <720000>;
        regulator-max-microvolt = <950000>;
        ...
    };

    vreg_l1c: ldo1 {
        regulator-name = "vreg_l1c";
        regulator-min-microvolt = <1140000>;
        regulator-max-microvolt = <1260000>;
        ...
    };

On SA8775P/QCS9100 QMP PHYs, vdda-phy-supply is the lower-voltage (~0.88V)
core supply and vdda-pll-supply is the higher-voltage (~1.2V) PLL supply
(matching ufs_mem_phy above, as well as the fix for other LeMans boards in
commit 932113c3c778 ("arm64: dts: qcom: lemans: Fix swapped USB QMP PHY
vdda-phy/vdda-pll supplies")).

In drivers/phy/qualcomm/phy-qcom-qmp-usb.c, qmp_phy_vreg_l[] specifies
different initial loads for the two supplies:

    static const struct regulator_bulk_data qmp_phy_vreg_l[] = {
        { .supply = "vdda-phy", .init_load_uA = 21800, },
        { .supply = "vdda-pll", .init_load_uA = 36000, },
    };

Because both vreg_l7a and vreg_l1c set regulator-allow-set-load, having these
supplies swapped causes the PHY driver to vote the 21.8 mA PHY load onto the
1.2V PLL rail (vreg_l1c) and the 36 mA PLL load onto the 0.88V PHY core rail
(vreg_l7a).

Should both usb_0_qmpphy and usb_1_qmpphy use vdda-phy-supply = <&vreg_l7a>
and vdda-pll-supply = <&vreg_l1c> instead?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019-lemans-draco-final-changes-bringup-v1-0-dcabe94f1074@oss.qualcomm.com?part=2